iwlwifi: don't include iwl-dev.h from iwl-devtrace.h

iwl-devtrace.h is used to declare and define trace points and
including iwl-dev.h from the file, which in turn includes other
generic headers, can lead to problems like generating duplicate copies
of generic trace points depending on the order of includes.  Don't
include iwl-dev.h from iwl-devtrace.h but include it from its users -
iwl-io.h and iwl-devtrace.c.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Cc: Zhu Yi <yi.zhu@intel.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
This commit is contained in:
Tejun Heo 2010-03-23 15:55:39 +09:00
Родитель 57f4c226d1
Коммит ed391f4ebf
3 изменённых файлов: 3 добавлений и 1 удалений

Просмотреть файл

@ -28,6 +28,8 @@
/* sparse doesn't like tracepoint macros */ /* sparse doesn't like tracepoint macros */
#ifndef __CHECKER__ #ifndef __CHECKER__
#include "iwl-dev.h"
#define CREATE_TRACE_POINTS #define CREATE_TRACE_POINTS
#include "iwl-devtrace.h" #include "iwl-devtrace.h"

Просмотреть файл

@ -28,7 +28,6 @@
#define __IWLWIFI_DEVICE_TRACE #define __IWLWIFI_DEVICE_TRACE
#include <linux/tracepoint.h> #include <linux/tracepoint.h>
#include "iwl-dev.h"
#if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__) #if !defined(CONFIG_IWLWIFI_DEVICE_TRACING) || defined(__CHECKER__)
#undef TRACE_EVENT #undef TRACE_EVENT

Просмотреть файл

@ -31,6 +31,7 @@
#include <linux/io.h> #include <linux/io.h>
#include "iwl-dev.h"
#include "iwl-debug.h" #include "iwl-debug.h"
#include "iwl-devtrace.h" #include "iwl-devtrace.h"