crypto: testmgr - add panic_on_fail module parameter
Add a module parameter cryptomgr.panic_on_fail which causes the kernel to panic if any crypto self-tests fail. Use cases: - More easily detect crypto self-test failures by boot testing, e.g. on KernelCI. - Get a bug report if syzkaller manages to use the template system to instantiate an algorithm that fails its self-tests. The command-line option "fips=1" already does this, but it also makes other changes not wanted for general testing, such as disabling "unapproved" algorithms. panic_on_fail just does what it says. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Родитель
f6e9af8766
Коммит
eda69b0c06
|
@ -45,6 +45,9 @@ static bool notests;
|
||||||
module_param(notests, bool, 0644);
|
module_param(notests, bool, 0644);
|
||||||
MODULE_PARM_DESC(notests, "disable crypto self-tests");
|
MODULE_PARM_DESC(notests, "disable crypto self-tests");
|
||||||
|
|
||||||
|
static bool panic_on_fail;
|
||||||
|
module_param(panic_on_fail, bool, 0444);
|
||||||
|
|
||||||
#ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
|
#ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
|
||||||
static bool noextratests;
|
static bool noextratests;
|
||||||
module_param(noextratests, bool, 0644);
|
module_param(noextratests, bool, 0644);
|
||||||
|
@ -4109,8 +4112,9 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
|
||||||
type, mask);
|
type, mask);
|
||||||
|
|
||||||
test_done:
|
test_done:
|
||||||
if (fips_enabled && rc)
|
if (rc && (fips_enabled || panic_on_fail))
|
||||||
panic("%s: %s alg self test failed in fips mode!\n", driver, alg);
|
panic("alg: self-tests for %s (%s) failed in %s mode!\n",
|
||||||
|
driver, alg, fips_enabled ? "fips" : "panic_on_fail");
|
||||||
|
|
||||||
if (fips_enabled && !rc)
|
if (fips_enabled && !rc)
|
||||||
pr_info("alg: self-tests for %s (%s) passed\n", driver, alg);
|
pr_info("alg: self-tests for %s (%s) passed\n", driver, alg);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче