net: wimax: i2400m: control.c: Cleaning up conjunction always evaluates to false
Logical conjunction always evaluates to false: minor < 2 && minor > 1 I guess what you wanted is rather: minor > 2 || minor < 1 This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
655aa39306
Коммит
f05d435bde
|
@ -1061,7 +1061,7 @@ int i2400m_firmware_check(struct i2400m *i2400m)
|
|||
goto error_bad_major;
|
||||
}
|
||||
result = 0;
|
||||
if (minor < I2400M_HDIv_MINOR_2 && minor > I2400M_HDIv_MINOR)
|
||||
if (minor > I2400M_HDIv_MINOR_2 || minor < I2400M_HDIv_MINOR)
|
||||
dev_warn(dev, "untested minor fw version %u.%u.%u\n",
|
||||
major, minor, branch);
|
||||
/* Yes, we ignore the branch -- we don't have to track it */
|
||||
|
|
Загрузка…
Ссылка в новой задаче