phy: HiSilicon: Fix copy and paste bug in error handling
This should check ">pmctrl" instead of "->sysctrl". This bug could
potentially lead to a crash if we dereference the error pointer.
Fixes: 73075011ff
("phy: HiSilicon: Add driver for Kirin 970 PCIe PHY")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20211117074843.GE5237@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Родитель
a1b6c81ba4
Коммит
f0ae8685b2
|
@ -757,8 +757,8 @@ static int hi3670_pcie_phy_get_resources(struct hi3670_pcie_phy *phy,
|
|||
return PTR_ERR(phy->sysctrl);
|
||||
|
||||
phy->pmctrl = syscon_regmap_lookup_by_compatible("hisilicon,hi3670-pmctrl");
|
||||
if (IS_ERR(phy->sysctrl))
|
||||
return PTR_ERR(phy->sysctrl);
|
||||
if (IS_ERR(phy->pmctrl))
|
||||
return PTR_ERR(phy->pmctrl);
|
||||
|
||||
/* clocks */
|
||||
phy->phy_ref_clk = devm_clk_get(dev, "phy_ref");
|
||||
|
|
Загрузка…
Ссылка в новой задаче