x86/mm/init: Fix incorrect page size in init_memory_mapping() printks
With 32-bit non-PAE kernels, we have 2 page sizes available (at most): 4k and 4M. Enabling PAE replaces that 4M size with a 2M one (which 64-bit systems use too). But, when booting a 32-bit non-PAE kernel, in one of our early-boot printouts, we say: init_memory_mapping: [mem 0x00000000-0x000fffff] [mem 0x00000000-0x000fffff] page 4k init_memory_mapping: [mem 0x37000000-0x373fffff] [mem 0x37000000-0x373fffff] page 2M init_memory_mapping: [mem 0x00100000-0x36ffffff] [mem 0x00100000-0x003fffff] page 4k [mem 0x00400000-0x36ffffff] page 2M init_memory_mapping: [mem 0x37400000-0x377fdfff] [mem 0x37400000-0x377fdfff] page 4k Which is obviously wrong. There is no 2M page available. This is probably because of a badly-named variable: in the map_range code: PG_LEVEL_2M. Instead of renaming all the PG_LEVEL_2M's. This patch just fixes the printout: init_memory_mapping: [mem 0x00000000-0x000fffff] [mem 0x00000000-0x000fffff] page 4k init_memory_mapping: [mem 0x37000000-0x373fffff] [mem 0x37000000-0x373fffff] page 4M init_memory_mapping: [mem 0x00100000-0x36ffffff] [mem 0x00100000-0x003fffff] page 4k [mem 0x00400000-0x36ffffff] page 4M init_memory_mapping: [mem 0x37400000-0x377fdfff] [mem 0x37400000-0x377fdfff] page 4k BRK [0x03206000, 0x03206fff] PGTABLE Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Yinghai Lu <yinghai@kernel.org> Link: http://lkml.kernel.org/r/20150210212030.665EC267@viggo.jf.intel.com Signed-off-by: Borislav Petkov <bp@suse.de>
This commit is contained in:
Родитель
bfa76d4957
Коммит
f15e05186c
|
@ -238,6 +238,31 @@ static void __init_refok adjust_range_page_size_mask(struct map_range *mr,
|
|||
}
|
||||
}
|
||||
|
||||
static const char *page_size_string(struct map_range *mr)
|
||||
{
|
||||
static const char str_1g[] = "1G";
|
||||
static const char str_2m[] = "2M";
|
||||
static const char str_4m[] = "4M";
|
||||
static const char str_4k[] = "4k";
|
||||
|
||||
if (mr->page_size_mask & (1<<PG_LEVEL_1G))
|
||||
return str_1g;
|
||||
/*
|
||||
* 32-bit without PAE has a 4M large page size.
|
||||
* PG_LEVEL_2M is misnamed, but we can at least
|
||||
* print out the right size in the string.
|
||||
*/
|
||||
if (IS_ENABLED(CONFIG_X86_32) &&
|
||||
!IS_ENABLED(CONFIG_X86_PAE) &&
|
||||
mr->page_size_mask & (1<<PG_LEVEL_2M))
|
||||
return str_4m;
|
||||
|
||||
if (mr->page_size_mask & (1<<PG_LEVEL_2M))
|
||||
return str_2m;
|
||||
|
||||
return str_4k;
|
||||
}
|
||||
|
||||
static int __meminit split_mem_range(struct map_range *mr, int nr_range,
|
||||
unsigned long start,
|
||||
unsigned long end)
|
||||
|
@ -333,8 +358,7 @@ static int __meminit split_mem_range(struct map_range *mr, int nr_range,
|
|||
for (i = 0; i < nr_range; i++)
|
||||
printk(KERN_DEBUG " [mem %#010lx-%#010lx] page %s\n",
|
||||
mr[i].start, mr[i].end - 1,
|
||||
(mr[i].page_size_mask & (1<<PG_LEVEL_1G))?"1G":(
|
||||
(mr[i].page_size_mask & (1<<PG_LEVEL_2M))?"2M":"4k"));
|
||||
page_size_string(&mr[i]));
|
||||
|
||||
return nr_range;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче