drm: imx: fix compiler warning with gcc-12
[ Upstream commit7aefd8b538
] Gcc-12 correctly warned about this code using a non-NULL pointer as a truth value: drivers/gpu/drm/imx/ipuv3-crtc.c: In function ‘ipu_crtc_disable_planes’: drivers/gpu/drm/imx/ipuv3-crtc.c:72:21: error: the comparison will always evaluate as ‘true’ for the address of ‘plane’ will never be NULL [-Werror=address] 72 | if (&ipu_crtc->plane[1] && plane == &ipu_crtc->plane[1]->base) | ^ due to the extraneous '&' address-of operator. Philipp Zabel points out that The mistake had no adverse effect since the following condition doesn't actually dereference the NULL pointer, but the intent of the code was obviously to check for it, not to take the address of the member. Fixes:eb8c88808c
("drm/imx: add deferred plane disabling") Acked-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
9c1fb2e938
Коммит
f1fec5ccbe
|
@ -69,7 +69,7 @@ static void ipu_crtc_disable_planes(struct ipu_crtc *ipu_crtc,
|
||||||
drm_atomic_crtc_state_for_each_plane(plane, old_crtc_state) {
|
drm_atomic_crtc_state_for_each_plane(plane, old_crtc_state) {
|
||||||
if (plane == &ipu_crtc->plane[0]->base)
|
if (plane == &ipu_crtc->plane[0]->base)
|
||||||
disable_full = true;
|
disable_full = true;
|
||||||
if (&ipu_crtc->plane[1] && plane == &ipu_crtc->plane[1]->base)
|
if (ipu_crtc->plane[1] && plane == &ipu_crtc->plane[1]->base)
|
||||||
disable_partial = true;
|
disable_partial = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче