batman-adv: Place kref_get for orig_ifinfo near use
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems caused by incorrect reference counting. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
Родитель
09537d1869
Коммит
f257b99bec
|
@ -386,6 +386,7 @@ batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node,
|
|||
orig_ifinfo->if_outgoing = if_outgoing;
|
||||
INIT_HLIST_NODE(&orig_ifinfo->list);
|
||||
kref_init(&orig_ifinfo->refcount);
|
||||
|
||||
kref_get(&orig_ifinfo->refcount);
|
||||
hlist_add_head_rcu(&orig_ifinfo->list,
|
||||
&orig_node->ifinfo_list);
|
||||
|
|
Загрузка…
Ссылка в новой задаче