ASoC: topology: allow for partial dailink stream_name
Merge series from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>: The topology file and the machine driver rely on common definitions for the dailink stream_name. To avoid any backwards-compatibility problems, the machine driver stream names are set in stone and cannot be modified. This is problematic when we try to name some of the topology widgets after the stream_name, since the widget name is limited to 44 characters tools/include/uapi/sound/asound.h:#define SNDRV_CTL_ELEM_ID_NAME_MAXLEN 44 Existing examples include "Analog Playback and Capture" for HDaudio dailinks, which leaves less than 20 chars to identify widgets/controls with a meaningful name. Since the 44-char limit is part of the UAPI definitions, we assumed there is no way to increase it. This patchset suggests instead a partial match which allows topology files to use a shorter stream_name, which in turn allows for self-explanatory widget names that comply with the 44-char limit. This should not break any existing setup but with the introduction of a partial match new dailinks should be named carefully to avoid confusions between e.g. 'link1' and 'link10'. The last patch fixes such an issue in the 'nocodec' test topology used by Intel.
This commit is contained in:
Коммит
f2d4aa7e97
|
@ -2030,11 +2030,11 @@ static struct snd_soc_dai_link *snd_soc_find_dai_link(struct snd_soc_card *card,
|
||||||
if (link->id != id)
|
if (link->id != id)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
if (name && (!link->name || strcmp(name, link->name)))
|
if (name && (!link->name || !strstr(link->name, name)))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
if (stream_name && (!link->stream_name
|
if (stream_name && (!link->stream_name ||
|
||||||
|| strcmp(stream_name, link->stream_name)))
|
!strstr(link->stream_name, stream_name)))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
return link;
|
return link;
|
||||||
|
|
|
@ -1562,7 +1562,11 @@ void hda_set_mach_params(struct snd_soc_acpi_mach *mach,
|
||||||
|
|
||||||
mach_params = &mach->mach_params;
|
mach_params = &mach->mach_params;
|
||||||
mach_params->platform = dev_name(sdev->dev);
|
mach_params->platform = dev_name(sdev->dev);
|
||||||
mach_params->num_dai_drivers = desc->ops->num_drv;
|
if (IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC_DEBUG_SUPPORT) &&
|
||||||
|
sof_debug_check_flag(SOF_DBG_FORCE_NOCODEC))
|
||||||
|
mach_params->num_dai_drivers = SOF_SKL_NUM_DAIS_NOCODEC;
|
||||||
|
else
|
||||||
|
mach_params->num_dai_drivers = desc->ops->num_drv;
|
||||||
mach_params->dai_drivers = desc->ops->drv;
|
mach_params->dai_drivers = desc->ops->drv;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -414,10 +414,12 @@
|
||||||
(HDA_DSP_BDL_SIZE / sizeof(struct sof_intel_dsp_bdl))
|
(HDA_DSP_BDL_SIZE / sizeof(struct sof_intel_dsp_bdl))
|
||||||
|
|
||||||
/* Number of DAIs */
|
/* Number of DAIs */
|
||||||
|
#define SOF_SKL_NUM_DAIS_NOCODEC 8
|
||||||
|
|
||||||
#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)
|
#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC)
|
||||||
#define SOF_SKL_NUM_DAIS 15
|
#define SOF_SKL_NUM_DAIS 15
|
||||||
#else
|
#else
|
||||||
#define SOF_SKL_NUM_DAIS 8
|
#define SOF_SKL_NUM_DAIS SOF_SKL_NUM_DAIS_NOCODEC
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
/* Intel HD Audio SRAM Window 0*/
|
/* Intel HD Audio SRAM Window 0*/
|
||||||
|
|
|
@ -1073,7 +1073,7 @@ static int sof_connect_dai_widget(struct snd_soc_component *scomp,
|
||||||
list_for_each_entry(rtd, &card->rtd_list, list) {
|
list_for_each_entry(rtd, &card->rtd_list, list) {
|
||||||
/* does stream match DAI link ? */
|
/* does stream match DAI link ? */
|
||||||
if (!rtd->dai_link->stream_name ||
|
if (!rtd->dai_link->stream_name ||
|
||||||
strcmp(w->sname, rtd->dai_link->stream_name))
|
!strstr(rtd->dai_link->stream_name, w->sname))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
for_each_rtd_cpu_dais(rtd, i, cpu_dai) {
|
for_each_rtd_cpu_dais(rtd, i, cpu_dai) {
|
||||||
|
|
Загрузка…
Ссылка в новой задаче