fbdev: vesafb: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Родитель
94bada5828
Коммит
f3db09aae1
|
@ -485,7 +485,7 @@ err_release_region:
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int vesafb_remove(struct platform_device *pdev)
|
static void vesafb_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct fb_info *info = platform_get_drvdata(pdev);
|
struct fb_info *info = platform_get_drvdata(pdev);
|
||||||
|
|
||||||
|
@ -494,8 +494,6 @@ static int vesafb_remove(struct platform_device *pdev)
|
||||||
|
|
||||||
/* vesafb_destroy takes care of info cleanup */
|
/* vesafb_destroy takes care of info cleanup */
|
||||||
unregister_framebuffer(info);
|
unregister_framebuffer(info);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct platform_driver vesafb_driver = {
|
static struct platform_driver vesafb_driver = {
|
||||||
|
@ -503,7 +501,7 @@ static struct platform_driver vesafb_driver = {
|
||||||
.name = "vesa-framebuffer",
|
.name = "vesa-framebuffer",
|
||||||
},
|
},
|
||||||
.probe = vesafb_probe,
|
.probe = vesafb_probe,
|
||||||
.remove = vesafb_remove,
|
.remove_new = vesafb_remove,
|
||||||
};
|
};
|
||||||
|
|
||||||
module_platform_driver(vesafb_driver);
|
module_platform_driver(vesafb_driver);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче