isdn: cleanup: make buffer smaller
This showed up in my audit because we use strcpy() to copy "ds" into a 32 character buffer inside the isdn_tty_dial() function. But it turns out that we only ever use the first 32 characters so it's OK. I have changed the declaration to make the static checkers happy. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
017d79ef00
Коммит
f417f5e4ba
|
@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info)
|
|||
{
|
||||
atemu *m = &info->emu;
|
||||
char *p;
|
||||
char ds[40];
|
||||
char ds[ISDN_MSNLEN];
|
||||
|
||||
#ifdef ISDN_DEBUG_AT
|
||||
printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
|
||||
|
@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info)
|
|||
break;
|
||||
case '3':
|
||||
p++;
|
||||
sprintf(ds, "\r\n%d", info->emu.charge);
|
||||
snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);
|
||||
isdn_tty_at_cout(ds, info);
|
||||
break;
|
||||
default:;
|
||||
|
|
Загрузка…
Ссылка в новой задаче