ARM: amba: Don't read past the end of sysfs "driver_override" buffer
commitd2ffed5185
upstream. When printing the driver_override parameter when it is 4095 and 4094 bytes long, the printing code would access invalid memory because we need count + 1 bytes for printing. Cfr. commits4efe874aac
("PCI: Don't read past the end of sysfs "driver_override" buffer") andbf563b01c2
("driver core: platform: Don't read past the end of "driver_override" buffer"). Fixes:3cf3857134
("ARM: 8256/1: driver coamba: add device binding path 'driver_override'") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Todd Kjos <tkjos@google.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
23abff7b98
Коммит
f671ee8de3
|
@ -84,7 +84,8 @@ static ssize_t driver_override_store(struct device *_dev,
|
||||||
struct amba_device *dev = to_amba_device(_dev);
|
struct amba_device *dev = to_amba_device(_dev);
|
||||||
char *driver_override, *old, *cp;
|
char *driver_override, *old, *cp;
|
||||||
|
|
||||||
if (count > PATH_MAX)
|
/* We need to keep extra room for a newline */
|
||||||
|
if (count >= (PAGE_SIZE - 1))
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
driver_override = kstrndup(buf, count, GFP_KERNEL);
|
driver_override = kstrndup(buf, count, GFP_KERNEL);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче