perf tools: include wrapper for magic.h
perf is currently including magic.h directly from the kernel. If the glibc magic.h is also included, this leads to warnings that the constants are redefined. This happens on some systems (e.g. Android). Redefinition errors on Android: In file included from util/util.h:79:0, from util/cache.h:5, from util/abspath.c:1: util/../../../include/linux/magic.h:5:0: error: "AFFS_SUPER_MAGIC" redefined [-Werror] bionic/libc/include/sys/vfs.h:53:0: note: this is the location of the previous definition util/../../../include/linux/magic.h:19:0: error: "EFS_SUPER_MAGIC" redefined [-Werror] bionic/libc/include/sys/vfs.h:61:0: note: this is the location of the previous definition util/../../../include/linux/magic.h:26:0: error: "HPFS_SUPER_MAGIC" redefined [-Werror] bionic/libc/include/sys/vfs.h:67:0: note: this is the location of the previous definition Only two constants from magic.h are used by perf (DEBUGFS_MAGIC and SYSFS_MAGIC). This fix provides a wrapper for magic.h that includes only these constants instead of including the kernel header file directly. Signed-off-by: Irina Tirdea <irina.tirdea@intel.com> Acked-by: Pekka Enberg <penberg@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Irina Tirdea <irina.tirdea@intel.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/1347315303-29906-2-git-send-email-irina.tirdea@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Родитель
2814eb0572
Коммит
f8fcd77621
|
@ -264,6 +264,7 @@ LIB_H += util/include/linux/ctype.h
|
||||||
LIB_H += util/include/linux/kernel.h
|
LIB_H += util/include/linux/kernel.h
|
||||||
LIB_H += util/include/linux/list.h
|
LIB_H += util/include/linux/list.h
|
||||||
LIB_H += util/include/linux/export.h
|
LIB_H += util/include/linux/export.h
|
||||||
|
LIB_H += util/include/linux/magic.h
|
||||||
LIB_H += util/include/linux/poison.h
|
LIB_H += util/include/linux/poison.h
|
||||||
LIB_H += util/include/linux/prefetch.h
|
LIB_H += util/include/linux/prefetch.h
|
||||||
LIB_H += util/include/linux/rbtree.h
|
LIB_H += util/include/linux/rbtree.h
|
||||||
|
|
|
@ -0,0 +1,12 @@
|
||||||
|
#ifndef _PERF_LINUX_MAGIC_H_
|
||||||
|
#define _PERF_LINUX_MAGIC_H_
|
||||||
|
|
||||||
|
#ifndef DEBUGFS_MAGIC
|
||||||
|
#define DEBUGFS_MAGIC 0x64626720
|
||||||
|
#endif
|
||||||
|
|
||||||
|
#ifndef SYSFS_MAGIC
|
||||||
|
#define SYSFS_MAGIC 0x62656572
|
||||||
|
#endif
|
||||||
|
|
||||||
|
#endif
|
|
@ -70,7 +70,7 @@
|
||||||
#include <sys/socket.h>
|
#include <sys/socket.h>
|
||||||
#include <sys/ioctl.h>
|
#include <sys/ioctl.h>
|
||||||
#include <inttypes.h>
|
#include <inttypes.h>
|
||||||
#include "../../../include/linux/magic.h"
|
#include <linux/magic.h>
|
||||||
#include "types.h"
|
#include "types.h"
|
||||||
#include <sys/ttydefaults.h>
|
#include <sys/ttydefaults.h>
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче