cdc-wdm endianness fixes
* wMaxPacketSize is le16; copying it to a field of local structure and then using that field as host-endian (size of object to be allocated) is broken. * bMaxPacketSize0 is 8-bit; feeding it to le16_to_cpu() is bogus and since the result is used as host-endian, it's not even misspelled cpu_to_le16(). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
76e6f2526f
Коммит
fa4144b758
|
@ -611,8 +611,8 @@ next_desc:
|
|||
goto err;
|
||||
}
|
||||
|
||||
desc->wMaxPacketSize = ep->wMaxPacketSize;
|
||||
desc->bMaxPacketSize0 = cpu_to_le16(udev->descriptor.bMaxPacketSize0);
|
||||
desc->wMaxPacketSize = le16_to_cpu(ep->wMaxPacketSize);
|
||||
desc->bMaxPacketSize0 = udev->descriptor.bMaxPacketSize0;
|
||||
|
||||
desc->orq = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);
|
||||
if (!desc->orq)
|
||||
|
|
Загрузка…
Ссылка в новой задаче