pinctrl: mediatek: fix global-out-of-bounds issue
commit 2d5446da5a
upstream.
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20211110071900.4490-2-zhiyong.tao@mediatek.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
aa50406f36
Коммит
fb563baa3e
|
@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
|
|||
desc = (const struct mtk_pin_desc *)hw->soc->pins;
|
||||
*gpio_chip = &hw->chip;
|
||||
|
||||
/* Be greedy to guess first gpio_n is equal to eint_n */
|
||||
if (desc[eint_n].eint.eint_n == eint_n)
|
||||
/*
|
||||
* Be greedy to guess first gpio_n is equal to eint_n.
|
||||
* Only eint virtual eint number is greater than gpio number.
|
||||
*/
|
||||
if (hw->soc->npins > eint_n &&
|
||||
desc[eint_n].eint.eint_n == eint_n)
|
||||
*gpio_n = eint_n;
|
||||
else
|
||||
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
|
||||
|
|
Загрузка…
Ссылка в новой задаче