atm: br2684: Fix oops due to skb->dev being NULL
This oops have been already fixed with commit27141666b6
atm: [br2684] Fix oops due to skb->dev being NULL It happens that if a packet arrives in a VC between the call to open it on the hardware and the call to change the backend to br2684, br2684_regvcc processes the packet and oopses dereferencing skb->dev because it is NULL before the call to br2684_push(). but have been introduced again with commitb6211ae7f2
atm: Use SKB queue and list helpers instead of doing it by-hand. Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
98e77438ae
Коммит
fbe5e29ec1
|
@ -558,12 +558,13 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
|
|||
spin_unlock_irqrestore(&rq->lock, flags);
|
||||
|
||||
skb_queue_walk_safe(&queue, skb, tmp) {
|
||||
struct net_device *dev = skb->dev;
|
||||
struct net_device *dev;
|
||||
|
||||
br2684_push(atmvcc, skb);
|
||||
dev = skb->dev;
|
||||
|
||||
dev->stats.rx_bytes -= skb->len;
|
||||
dev->stats.rx_packets--;
|
||||
|
||||
br2684_push(atmvcc, skb);
|
||||
}
|
||||
|
||||
/* initialize netdev carrier state */
|
||||
|
|
Загрузка…
Ссылка в новой задаче