netlink: Don't shift with UB on nlk->ngroups
[ Upstream commit61f4b23769
] On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in hang during boot. Check for 0 ngroups and use (unsigned long long) as a type to shift. Fixes:7acf9d4237
("netlink: Do not subscribe to non-existent groups"). Reported-by: kernel test robot <rong.a.chen@intel.com> Signed-off-by: Dmitry Safonov <dima@arista.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
e208cda5f1
Коммит
fffd3058ea
|
@ -976,7 +976,11 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
|
|||
if (err)
|
||||
return err;
|
||||
}
|
||||
groups &= (1UL << nlk->ngroups) - 1;
|
||||
|
||||
if (nlk->ngroups == 0)
|
||||
groups = 0;
|
||||
else
|
||||
groups &= (1ULL << nlk->ngroups) - 1;
|
||||
|
||||
bound = nlk->bound;
|
||||
if (bound) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче