Ilya Dryomov 4cf7e2a305 rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings ... commit 2237ceb71f89837ac47c5dce2aaa2c2b3a337a3c upstream. Every time a watch is reestablished after getting lost, we need to update the cookie which involves quiescing exclusive lock. For this, we transition from RBD_LOCK_STATE_LOCKED to RBD_LOCK_STATE_QUIESCING roughly for the duration of rbd_reacquire_lock() call. If the mapping is exclusive and I/O happens to arrive in this time window, it's failed with EROFS (later translated to EIO) based on the wrong assumption in rbd_img_exclusive_lock() -- "lock got released?" check there stopped making sense with commit a2b1da0979 ("rbd: lock should be quiesced on reacquire"). To make it worse, any such I/O is added to the acquiring list before EROFS is returned and this sets up for violating rbd_lock_del_request() precondition that the request is either on the running list or not on any list at all -- see commit ded080c86b3f ("rbd: don't move requests to the running list on errors"). rbd_lock_del_request() ends up processing these requests as if they were on the running list which screws up quiescing_wait completion counter and ultimately leads to rbd_assert(!completion_done(&rbd_dev->quiescing_wait)); being triggered on the next watch error. Cc: stable@vger.kernel.org # 06ef84c4e9c4: rbd: rename RBD_LOCK_STATE_RELEASING and releasing_wait Cc: stable@vger.kernel.org Fixes: 637cd06053 ("rbd: new exclusive lock wait/wake code") Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-08-19 05:45:22 +02:00
..
aoe	aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts	2024-03-26 18:21:15 -04:00
drbd	…
mtip32xx	…
null_blk	null_blk: fix validation of block size	2024-07-27 10:46:09 +02:00
paride	pcd: fix error codes in pcd_init_unit()	2023-09-19 12:23:04 +02:00
rnbd	block/rnbd-srv: Check for unlikely string overflow	2024-02-23 08:54:43 +01:00
rsxx	…
xen-blkback	…
zram	…
Kconfig	…
Makefile	…
amiflop.c	…
ataflop.c	…
brd.c	…
cryptoloop.c	…
floppy.c	…
loop.c	block: rename GENHD_FL_NO_PART_SCAN to GENHD_FL_NO_PART	2023-09-19 12:23:02 +02:00
loop.h	…
n64cart.c	block: rename GENHD_FL_NO_PART_SCAN to GENHD_FL_NO_PART	2023-09-19 12:23:02 +02:00
nbd.c	nbd: null check for nla_nest_start	2024-03-26 18:21:14 -04:00
pktcdvd.c	…
ps3disk.c	…
ps3vram.c	…
rbd.c	rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings	2024-08-19 05:45:22 +02:00
rbd_types.h	…
sunvdc.c	…
swim.c	…
swim3.c	…
swim_asm.S	…
virtio_blk.c	virtio-blk: Ensure no requests in virtqueues before deleting vqs.	2024-03-01 13:21:47 +01:00
xen-blkfront.c	…
z2ram.c	…