GUO Zihua a38e02265c ima: Avoid blocking in RCU read-side critical section ... commit 9a95c5bfbf02a0a7f5983280fe284a0ff0836c34 upstream. A panic happens in ima_match_policy: BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 PGD 42f873067 P4D 0 Oops: 0000 [#1] SMP NOPTI CPU: 5 PID: 1286325 Comm: kubeletmonit.sh Kdump: loaded Tainted: P Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 RIP: 0010:ima_match_policy+0x84/0x450 Code: 49 89 fc 41 89 cf 31 ed 89 44 24 14 eb 1c 44 39 7b 18 74 26 41 83 ff 05 74 20 48 8b 1b 48 3b 1d f2 b9 f4 00 0f 84 9c 01 00 00 <44> 85 73 10 74 ea 44 8b 6b 14 41 f6 c5 01 75 d4 41 f6 c5 02 74 0f RSP: 0018:ff71570009e07a80 EFLAGS: 00010207 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000200 RDX: ffffffffad8dc7c0 RSI: 0000000024924925 RDI: ff3e27850dea2000 RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffffabfce739 R10: ff3e27810cc42400 R11: 0000000000000000 R12: ff3e2781825ef970 R13: 00000000ff3e2785 R14: 000000000000000c R15: 0000000000000001 FS: 00007f5195b51740(0000) GS:ff3e278b12d40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000010 CR3: 0000000626d24002 CR4: 0000000000361ee0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: ima_get_action+0x22/0x30 process_measurement+0xb0/0x830 ? page_add_file_rmap+0x15/0x170 ? alloc_set_pte+0x269/0x4c0 ? prep_new_page+0x81/0x140 ? simple_xattr_get+0x75/0xa0 ? selinux_file_open+0x9d/0xf0 ima_file_check+0x64/0x90 path_openat+0x571/0x1720 do_filp_open+0x9b/0x110 ? page_counter_try_charge+0x57/0xc0 ? files_cgroup_alloc_fd+0x38/0x60 ? __alloc_fd+0xd4/0x250 ? do_sys_open+0x1bd/0x250 do_sys_open+0x1bd/0x250 do_syscall_64+0x5d/0x1d0 entry_SYSCALL_64_after_hwframe+0x65/0xca Commit c7423dbdbc ("ima: Handle -ESTALE returned by ima_filter_rule_match()") introduced call to ima_lsm_copy_rule within a RCU read-side critical section which contains kmalloc with GFP_KERNEL. This implies a possible sleep and violates limitations of RCU read-side critical sections on non-PREEMPT systems. Sleeping within RCU read-side critical section might cause synchronize_rcu() returning early and break RCU protection, allowing a UAF to happen. The root cause of this issue could be described as follows: | Thread A | Thread B | | |ima_match_policy | | | rcu_read_lock | |ima_lsm_update_rule | | | synchronize_rcu | | | | kmalloc(GFP_KERNEL)| | | sleep | ==> synchronize_rcu returns early | kfree(entry) | | | | entry = entry->next| ==> UAF happens and entry now becomes NULL (or could be anything). | | entry->action | ==> Accessing entry might cause panic. To fix this issue, we are converting all kmalloc that is called within RCU read-side critical section to use GFP_ATOMIC. Fixes: c7423dbdbc ("ima: Handle -ESTALE returned by ima_filter_rule_match()") Cc: stable@vger.kernel.org Signed-off-by: GUO Zihua <guozihua@huawei.com> Acked-by: John Johansen <john.johansen@canonical.com> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com> [PM: fixed missing comment, long lines, !CONFIG_IMA_LSM_RULES case] Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-07-18 13:07:34 +02:00
..
avtab.c	selinux: constify some avtab function arguments	2021-05-10 21:35:02 -04:00
avtab.h	selinux: constify some avtab function arguments	2021-05-10 21:35:02 -04:00
conditional.c	selinux: fix double free of cond_list on error paths	2022-02-08 18:34:02 +01:00
conditional.h	selinux: refactor changing booleans	2020-08-17 21:00:33 -04:00
constraint.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
context.c	selinux: hash context structure directly	2020-04-17 16:04:34 -04:00
context.h	selinux: move context hashing under sidtab	2020-04-17 16:04:38 -04:00
ebitmap.c	selinux: mark some global variables __ro_after_init	2021-01-12 10:08:55 -05:00
ebitmap.h	selinux: hash context structure directly	2020-04-17 16:04:34 -04:00
hashtab.c	selinux: fix bad cleanup on error in hashtab_duplicate()	2022-05-25 09:57:27 +02:00
hashtab.h	selinux: refactor changing booleans	2020-08-17 21:00:33 -04:00
mls.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
mls.h	selinux: hash context structure directly	2020-04-17 16:04:34 -04:00
mls_types.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
policydb.c	selinux: set next pointer before attaching to list	2023-08-30 16:18:17 +02:00
policydb.h	selinux: Add boundary check in put_entry()	2022-08-17 14:23:05 +02:00
services.c	ima: Avoid blocking in RCU read-side critical section	2024-07-18 13:07:34 +02:00
services.h	selinux: convert policy read-write lock to RCU	2020-08-25 08:34:47 -04:00
sidtab.c	selinux: enable use of both GFP_KERNEL and GFP_ATOMIC in convert_context()	2022-10-29 10:12:54 +02:00
sidtab.h	selinux: enable use of both GFP_KERNEL and GFP_ATOMIC in convert_context()	2022-10-29 10:12:54 +02:00
symtab.c	selinux: prepare for inlining of hashtab functions	2020-07-09 19:05:36 -04:00
symtab.h	selinux: specialize symtab insert and search functions	2020-07-08 20:21:43 -04:00