Kuninori Morimoto 5e78ebe7c1 ASoC: simple-card: fixup asoc_simple_probe() error handling ... [ Upstream commit 41bae58df4 ] asoc_simple_probe() is used for both "DT probe" (A) and "platform probe" (B). It uses "goto err" when error case, but it is not needed for "platform probe" case (B). Thus it is using "return" directly there. static int asoc_simple_probe(...) { ^ if (...) { | ... (A) if (ret < 0) | goto err; v } else { ^ ... | if (ret < 0) (B) return -Exxx; v } ... ^ if (ret < 0) (C) goto err; v ... err: (D) simple_util_clean_reference(card); return ret; } Both case are using (C) part, and it calls (D) when err case. But (D) will do nothing for (B) case. Because of these behavior, current code itself is not wrong, but is confusable, and more, static analyzing tool will warning on (B) part (should use goto err). To avoid static analyzing tool warning, this patch uses "goto err" on (B) part. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87o7hy7mlh.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-08 17:26:44 +01:00
..
Kconfig	ASoC: Fix 7/8 spaces indentation in Kconfig	2020-11-17 17:08:45 +00:00
Makefile	…
audio-graph-card.c	ASoC: audio-graph-card: fix refcount leak of cpu_ep in __graph_for_each_link()	2022-12-31 13:14:45 +01:00
simple-card-utils.c	ASoC: simple-card-utils: Set sysclk on all components	2022-04-08 14:23:13 +02:00
simple-card.c	ASoC: simple-card: fixup asoc_simple_probe() error handling	2023-11-08 17:26:44 +01:00