Michal Hocko dd33ad7b25 memory_hotplug: cond_resched in __remove_pages ... We have received a bug report that unbinding a large pmem (>1TB) can result in a soft lockup: NMI watchdog: BUG: soft lockup - CPU#9 stuck for 23s! [ndctl:4365] [...] Supported: Yes CPU: 9 PID: 4365 Comm: ndctl Not tainted 4.12.14-94.40-default #1 SLE12-SP4 Hardware name: Intel Corporation S2600WFD/S2600WFD, BIOS SE5C620.86B.01.00.0833.051120182255 05/11/2018 task: ffff9cce7d4410c0 task.stack: ffffbe9eb1bc4000 RIP: 0010:__put_page+0x62/0x80 Call Trace: devm_memremap_pages_release+0x152/0x260 release_nodes+0x18d/0x1d0 device_release_driver_internal+0x160/0x210 unbind_store+0xb3/0xe0 kernfs_fop_write+0x102/0x180 __vfs_write+0x26/0x150 vfs_write+0xad/0x1a0 SyS_write+0x42/0x90 do_syscall_64+0x74/0x150 entry_SYSCALL_64_after_hwframe+0x3d/0xa2 RIP: 0033:0x7fd13166b3d0 It has been reported on an older (4.12) kernel but the current upstream code doesn't cond_resched in the hot remove code at all and the given range to remove might be really large. Fix the issue by calling cond_resched once per memory section. Link: http://lkml.kernel.org/r/20181031125840.23982-1-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Thumshirn <jthumshirn@suse.de> Cc: Dan Williams <dan.j.williams@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-11-03 10:09:38 -07:00
..
kasan	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
Kconfig	mm: remove CONFIG_HAVE_MEMBLOCK	2018-10-31 08:54:15 -07:00
Kconfig.debug	…
Makefile	mm: remove nobootmem	2018-10-31 08:54:16 -07:00
backing-dev.c	…
balloon_compaction.c	…
cleancache.c	…
cma.c	…
cma.h	…
cma_debug.c	…
compaction.c	psi: pressure stall information for CPU, memory, and IO	2018-10-26 16:26:32 -07:00
debug.c	mm: provide kernel parameter to allow disabling page init poisoning	2018-10-26 16:26:34 -07:00
debug_page_ref.c	…
dmapool.c	…
early_ioremap.c	…
fadvise.c	…
failslab.c	…
filemap.c	vfs: rework data cloning infrastructure	2018-11-02 09:33:08 -07:00
frame_vector.c	…
frontswap.c	…
gup.c	mm/gup.c: fix __get_user_pages_fast() comment	2018-10-31 08:54:17 -07:00
gup_benchmark.c	mm/gup_benchmark.c: prevent integer overflow in ioctl	2018-10-31 08:54:12 -07:00
highmem.c	…
hmm.c	mm/hmm: invalidate device page table at start of invalidation	2018-10-31 08:54:12 -07:00
huge_memory.c	mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask	2018-11-03 10:09:37 -07:00
hugetlb.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
hugetlb_cgroup.c	…
hwpoison-inject.c	…
init-mm.c	…
internal.h	memblock: rename __free_pages_bootmem to memblock_free_pages	2018-10-31 08:54:16 -07:00
interval_tree.c	…
khugepaged.c	mm: Convert khugepaged_scan_shmem to XArray	2018-10-21 10:46:38 -04:00
kmemleak-test.c	…
kmemleak.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
ksm.c	…
list_lru.c	…
maccess.c	…
madvise.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
memblock.c	mm/memblock.c: warn if zero alignment was requested	2018-10-31 08:54:17 -07:00
memcontrol.c	mm: handle no memcg case in memcg_kmem_charge() properly	2018-11-03 10:09:37 -07:00
memfd.c	memfd: Convert memfd_tag_pins to XArray	2018-10-21 10:46:41 -04:00
memory-failure.c	…
memory.c	mm: Fix warning in insert_pfn()	2018-10-31 08:54:17 -07:00
memory_hotplug.c	memory_hotplug: cond_resched in __remove_pages	2018-11-03 10:09:38 -07:00
mempolicy.c	mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask	2018-11-03 10:09:37 -07:00
mempool.c	…
memtest.c	…
migrate.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
mincore.c	xarray: Replace exceptional entries	2018-09-29 22:47:49 -04:00
mlock.c	…
mm_init.c	…
mmap.c	mm: brk: downgrade mmap_sem to read when shrinking	2018-10-26 16:26:35 -07:00
mmu_context.c	…
mmu_gather.c	…
mmu_notifier.c	Revert "mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks"	2018-10-26 16:25:19 -07:00
mmzone.c	…
mprotect.c	…
mremap.c	mm: mremap: downgrade mmap_sem to read when shrinking	2018-10-26 16:26:35 -07:00
msync.c	…
nommu.c	mm/gup: cache dev_pagemap while pinning pages	2018-10-26 16:38:15 -07:00
oom_kill.c	Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2018-10-24 11:22:39 +01:00
page-writeback.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
page_alloc.c	memblock: stop using implicit alignment to SMP_CACHE_BYTES	2018-10-31 08:54:16 -07:00
page_counter.c	…
page_ext.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
page_idle.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
page_io.c	for-linus-20181102	2018-11-02 11:25:48 -07:00
page_isolation.c	…
page_owner.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
page_poison.c	virtio, vhost: fixes, tweaks	2018-11-01 14:42:49 -07:00
page_vma_mapped.c	mm/rmap: map_pte() was not handling private ZONE_DEVICE page properly	2018-10-31 08:54:11 -07:00
pagewalk.c	…
percpu-internal.h	…
percpu-km.c	…
percpu-stats.c	…
percpu-vm.c	…
percpu.c	Merge branch 'for-4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu	2018-11-01 09:27:57 -07:00
pgtable-generic.c	x86/mm: Page size aware flush_tlb_mm_range()	2018-10-09 16:51:11 +02:00
process_vm_access.c	…
quicklist.c	…
readahead.c	mm: Convert __do_page_cache_readahead to XArray	2018-10-21 10:46:37 -04:00
rmap.c	mm: migration: fix migration of huge PMD shared pages	2018-10-05 16:32:04 -07:00
rodata_test.c	…
shmem.c	mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask	2018-11-03 10:09:37 -07:00
slab.c	mm, slab: combine kmalloc_caches and kmalloc_dma_caches	2018-10-26 16:26:31 -07:00
slab.h	…
slab_common.c	mm, slab: shorten kmalloc cache names for large sizes	2018-10-26 16:26:32 -07:00
slob.c	…
slub.c	mm, slab: combine kmalloc_caches and kmalloc_dma_caches	2018-10-26 16:26:31 -07:00
sparse-vmemmap.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
sparse.c	memblock: stop using implicit alignment to SMP_CACHE_BYTES	2018-10-31 08:54:16 -07:00
swap.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
swap_cgroup.c	…
swap_slots.c	…
swap_state.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
swapfile.c	mm: export add_swap_extent()	2018-10-26 16:38:15 -07:00
truncate.c	mm: Convert truncate to XArray	2018-10-21 10:46:37 -04:00
usercopy.c	…
userfaultfd.c	…
util.c	kvfree(): fix misleading comment	2018-10-26 16:26:33 -07:00
vmacache.c	mm: get rid of vmacache_flush_all() entirely	2018-09-13 15:18:04 -10:00
vmalloc.c	vfree: add debug might_sleep()	2018-10-26 16:26:33 -07:00
vmpressure.c	…
vmscan.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
vmstat.c	mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size	2018-10-26 16:26:35 -07:00
workingset.c	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
z3fold.c	…
zbud.c	…
zpool.c	…
zsmalloc.c	mm/zsmalloc.c: fix fall-through annotation	2018-10-26 16:26:35 -07:00
zswap.c	…