Andrey Zhadchenko ca54b2bfaa openvswitch: fix memory leak at failed datapath creation ... [ Upstream commit a87406f4ad ] ovs_dp_cmd_new()->ovs_dp_change()->ovs_dp_set_upcall_portids() allocates array via kmalloc. If for some reason new_vport() fails during ovs_dp_cmd_new() dp->upcall_portids must be freed. Add missing kfree. Kmemleak example: unreferenced object 0xffff88800c382500 (size 64): comm "dump_state", pid 323, jiffies 4294955418 (age 104.347s) hex dump (first 32 bytes): 5e c2 79 e4 1f 7a 38 c7 09 21 38 0c 80 88 ff ff ^.y..z8..!8..... 03 00 00 00 0a 00 00 00 14 00 00 00 28 00 00 00 ............(... backtrace: [<0000000071bebc9f>] ovs_dp_set_upcall_portids+0x38/0xa0 [<000000000187d8bd>] ovs_dp_change+0x63/0xe0 [<000000002397e446>] ovs_dp_cmd_new+0x1f0/0x380 [<00000000aa06f36e>] genl_family_rcv_msg_doit+0xea/0x150 [<000000008f583bc4>] genl_rcv_msg+0xdc/0x1e0 [<00000000fa10e377>] netlink_rcv_skb+0x50/0x100 [<000000004959cece>] genl_rcv+0x24/0x40 [<000000004699ac7f>] netlink_unicast+0x23e/0x360 [<00000000c153573e>] netlink_sendmsg+0x24e/0x4b0 [<000000006f4aa380>] sock_sendmsg+0x62/0x70 [<00000000d0068654>] ____sys_sendmsg+0x230/0x270 [<0000000012dacf7d>] ___sys_sendmsg+0x88/0xd0 [<0000000011776020>] __sys_sendmsg+0x59/0xa0 [<000000002e8f2dc1>] do_syscall_64+0x3b/0x90 [<000000003243e7cb>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: b83d23a2a3 ("openvswitch: Introduce per-cpu upcall dispatch") Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com> Link: https://lore.kernel.org/r/20220825020326.664073-1-andrey.zhadchenko@virtuozzo.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-09-08 12:28:02 +02:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	openvswitch: add trace points	2021-06-22 10:47:32 -07:00
actions.c	net: openvswitch: fix misuse of the cached connection on tuple changes	2022-06-14 18:36:26 +02:00
conntrack.c	net: openvswitch: fix misuse of the cached connection on tuple changes	2022-06-14 18:36:26 +02:00
conntrack.h	net/sched: act_api: fix miss set post_ct for ovs after do conntrack in act_ct	2021-03-16 15:22:18 -07:00
datapath.c	openvswitch: fix memory leak at failed datapath creation	2022-09-08 12:28:02 +02:00
datapath.h	openvswitch: Introduce per-cpu upcall dispatch	2021-07-16 11:06:33 -07:00
dp_notify.c	net: openvswitch: use netif_ovs_is_port() instead of opencode	2019-07-08 15:53:25 -07:00
flow.c	net: openvswitch: fix parsing of nw_proto for IPv6 fragments	2022-06-29 09:03:18 +02:00
flow.h	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
flow_netlink.c	openvswitch: fix OOB access in reserve_sfa_size()	2022-04-27 14:39:00 +02:00
flow_netlink.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
flow_table.c	openvswitch: Optimize operation for key comparison	2021-07-01 11:13:10 -07:00
flow_table.h	net: openvswitch: fix to make sure flow_lookup() is not preempted	2020-10-18 12:29:36 -07:00
meter.c	openvswitch: meter: fix race when getting now_ms.	2021-05-13 15:54:59 -07:00
meter.h	net: openvswitch: use u64 for meter bucket	2020-04-23 18:26:11 -07:00
openvswitch_trace.c	openvswitch: add trace points	2021-06-22 10:47:32 -07:00
openvswitch_trace.h	openvswitch: add trace points	2021-06-22 10:47:32 -07:00
vport-geneve.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
vport-gre.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
vport-internal_dev.c	net: openvswitch: use core API to update/provide stats	2020-11-14 16:59:32 -08:00
vport-internal_dev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
vport-netdev.c	net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it	2021-04-04 01:43:02 -07:00
vport-netdev.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
vport-vxlan.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
vport.c	ovs: clear skb->tstamp in forwarding path	2021-08-18 11:31:13 +01:00
vport.h	openvswitch: Fix a typo	2021-03-22 12:59:46 -07:00