Alexei Starovoitov d45ed4a4e3 net: fix unsafe set_memory_rw from softirq ... on x86 system with net.core.bpf_jit_enable = 1 sudo tcpdump -i eth1 'tcp port 22' causes the warning: [ 56.766097] Possible unsafe locking scenario: [ 56.766097] [ 56.780146] CPU0 [ 56.786807] ---- [ 56.793188] lock(&(&vb->lock)->rlock); [ 56.799593] <Interrupt> [ 56.805889] lock(&(&vb->lock)->rlock); [ 56.812266] [ 56.812266] *** DEADLOCK *** [ 56.812266] [ 56.830670] 1 lock held by ksoftirqd/1/13: [ 56.836838] #0: (rcu_read_lock){.+.+..}, at: [<ffffffff8118f44c>] vm_unmap_aliases+0x8c/0x380 [ 56.849757] [ 56.849757] stack backtrace: [ 56.862194] CPU: 1 PID: 13 Comm: ksoftirqd/1 Not tainted 3.12.0-rc3+ #45 [ 56.868721] Hardware name: System manufacturer System Product Name/P8Z77 WS, BIOS 3007 07/26/2012 [ 56.882004] ffffffff821944c0 ffff88080bbdb8c8 ffffffff8175a145 0000000000000007 [ 56.895630] ffff88080bbd5f40 ffff88080bbdb928 ffffffff81755b14 0000000000000001 [ 56.909313] ffff880800000001 ffff880800000000 ffffffff8101178f 0000000000000001 [ 56.923006] Call Trace: [ 56.929532] [<ffffffff8175a145>] dump_stack+0x55/0x76 [ 56.936067] [<ffffffff81755b14>] print_usage_bug+0x1f7/0x208 [ 56.942445] [<ffffffff8101178f>] ? save_stack_trace+0x2f/0x50 [ 56.948932] [<ffffffff810cc0a0>] ? check_usage_backwards+0x150/0x150 [ 56.955470] [<ffffffff810ccb52>] mark_lock+0x282/0x2c0 [ 56.961945] [<ffffffff810ccfed>] __lock_acquire+0x45d/0x1d50 [ 56.968474] [<ffffffff810cce6e>] ? __lock_acquire+0x2de/0x1d50 [ 56.975140] [<ffffffff81393bf5>] ? cpumask_next_and+0x55/0x90 [ 56.981942] [<ffffffff810cef72>] lock_acquire+0x92/0x1d0 [ 56.988745] [<ffffffff8118f52a>] ? vm_unmap_aliases+0x16a/0x380 [ 56.995619] [<ffffffff817628f1>] _raw_spin_lock+0x41/0x50 [ 57.002493] [<ffffffff8118f52a>] ? vm_unmap_aliases+0x16a/0x380 [ 57.009447] [<ffffffff8118f52a>] vm_unmap_aliases+0x16a/0x380 [ 57.016477] [<ffffffff8118f44c>] ? vm_unmap_aliases+0x8c/0x380 [ 57.023607] [<ffffffff810436b0>] change_page_attr_set_clr+0xc0/0x460 [ 57.030818] [<ffffffff810cfb8d>] ? trace_hardirqs_on+0xd/0x10 [ 57.037896] [<ffffffff811a8330>] ? kmem_cache_free+0xb0/0x2b0 [ 57.044789] [<ffffffff811b59c3>] ? free_object_rcu+0x93/0xa0 [ 57.051720] [<ffffffff81043d9f>] set_memory_rw+0x2f/0x40 [ 57.058727] [<ffffffff8104e17c>] bpf_jit_free+0x2c/0x40 [ 57.065577] [<ffffffff81642cba>] sk_filter_release_rcu+0x1a/0x30 [ 57.072338] [<ffffffff811108e2>] rcu_process_callbacks+0x202/0x7c0 [ 57.078962] [<ffffffff81057f17>] __do_softirq+0xf7/0x3f0 [ 57.085373] [<ffffffff81058245>] run_ksoftirqd+0x35/0x70 cannot reuse jited filter memory, since it's readonly, so use original bpf insns memory to hold work_struct defer kfree of sk_filter until jit completed freeing tested on x86_64 and i386 Signed-off-by: Alexei Starovoitov <ast@plumgrid.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2013-10-07 15:16:45 -04:00
..
9p	for-linus-3.12-merge minor 9p fixes and tweaks for 3.12 merge window	2013-09-11 12:34:13 -07:00
bluetooth	Bluetooth: Introduce a new HCI_RFKILLED flag	2013-09-18 12:37:27 -05:00
caif	caif: Remove my bouncing email address.	2013-04-23 13:25:51 -04:00
irda	include: Convert ethernet mac address declarations to use ETH_ALEN	2013-08-02 12:33:54 -07:00
iucv	af_iucv: fix recvmsg by replacing skb_pull() function	2013-04-08 17:16:57 -04:00
netfilter	netfilter: synproxy: fix BUG_ON triggered by corrupt TCP packets	2013-09-30 12:44:38 +02:00
netns	Revert "net: sctp: convert sctp_checksum_disable module param into sctp sysctl"	2013-08-09 13:09:41 -07:00
nfc	NFC: netlink: Add result of firmware operation to completion event	2013-08-14 01:12:58 +02:00
phonet	…
sctp	net: sctp: reorder sctp_globals to reduce cacheline usage	2013-08-29 14:55:54 -04:00
tc_act	…
act_api.h	net: Remove extern from include/net/ scheduling prototypes	2013-07-31 17:24:22 -07:00
addrconf.h	IPv6 NAT: Do not drop DNATed 6to4/6rd packets	2013-09-28 15:56:15 -04:00
af_ieee802154.h	…
af_rxrpc.h	af_rxrpc.h: Remove extern from function prototypes	2013-07-31 17:50:01 -07:00
af_unix.h	af_unix: improve STREAM behavior with fragmented memory	2013-08-10 01:16:44 -07:00
af_vsock.h	VSOCK: Move af_vsock.h and vsock_addr.h to include/net	2013-07-27 22:14:06 -07:00
ah.h	…
arp.h	arp/neighbour.h: Remove extern from function prototypes	2013-07-31 17:50:02 -07:00
atmclip.h	…
ax25.h	ax25.h: Remove extern from function prototypes	2013-07-31 17:50:02 -07:00
ax88796.h	…
busy_poll.h	net: add cpu_relax to busy poll loop	2013-08-28 17:45:48 -04:00
cfg80211-wext.h	…
cfg80211.h	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem	2013-08-29 14:08:24 -04:00
checksum.h	checksum: Remove extern from function prototypes	2013-07-31 17:50:02 -07:00
cipso_ipv4.h	…
cls_cgroup.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2013-09-05 14:54:29 -07:00
codel.h	codel: refine one condition to avoid a nul rec_inv_sqrt	2012-08-10 16:52:54 -07:00
compat.h	…
datalink.h	…
dcbevent.h	…
dcbnl.h	…
dn.h	…
dn_dev.h	…
dn_fib.h	decnet: Parse netlink attributes on our own	2013-03-22 10:31:16 -04:00
dn_neigh.h	…
dn_nsp.h	…
dn_route.h	decnet: use correct RCU API to deref sk_dst_cache field	2013-01-28 00:15:27 -05:00
dsa.h	…
dsfield.h	ipv6: Optimize ipv6_change_dsfield().	2013-01-09 23:59:53 -08:00
dst.h	tunnels: harmonize cleanup done on skb on rx path	2013-09-04 00:27:26 -04:00
dst_ops.h	net: Fix warnings in dst_ops.h	2012-07-19 10:43:03 -07:00
esp.h	…
ethoc.h	…
fib_rules.h	fib_rules: reorder struct fib_rules fields	2013-08-03 11:53:54 -07:00
firewire.h	firewire net, ipv4 arp: Extend hardware address and remove driver-level packet inspection.	2013-03-26 12:32:13 -04:00
flow.h	ipv4: Add FLOWI_FLAG_KNOWN_NH	2012-10-08 17:42:36 -04:00
flow_keys.h	flow_keys: include thoff into flow_keys for later usage	2013-03-20 12:14:36 -04:00
garp.h	…
gen_stats.h	net_sched: add 64bit rate estimators	2013-06-11 02:51:03 -07:00
genetlink.h	genl: Hold reference on correct module while netlink-dump.	2013-08-28 17:19:17 -04:00
gre.h	net: gre: move GSO functions to gre_offload	2013-07-03 14:37:39 -07:00
gro_cells.h	gro: Fix kcalloc argument order	2013-01-27 22:46:33 -05:00
icmp.h	ipv4: fix error handling in icmp_protocol.	2013-02-22 15:10:18 -05:00
ieee80211_radiotap.h	mac80211: add radiotap flag and handling for 5/10 MHz	2013-07-16 09:58:05 +03:00
ieee802154.h	…
ieee802154_netdev.h	ieee802154/nl-mac.c: make some MLME operations optional	2013-04-08 12:00:16 -04:00
if_inet6.h	net: ipv6: mld: fix v1/v2 switchback timeout to rfc3810, 9.12.	2013-09-04 14:53:20 -04:00
inet6_connection_sock.h	ipv6: Add helper inet6_csk_update_pmtu().	2012-07-16 03:44:56 -07:00
inet6_hashtables.h	ipv6: use a stronger hash for tcp	2013-02-21 18:15:58 -05:00
inet_common.h	net-tcp: Fast Open client - sendmsg(MSG_FASTOPEN)	2012-07-19 11:02:03 -07:00
inet_connection_sock.h	tcp: Tail loss probe (TLP)	2013-03-12 08:30:34 -04:00
inet_ecn.h	net: Correct comparisons and calculations using skb->tail and skb-transport_header	2013-05-28 23:49:07 -07:00
inet_frag.h	net: frag, fix race conditions in LRU list maintenance	2013-05-06 11:06:51 -04:00
inet_hashtables.h	hlist: drop the node parameter from iterators	2013-02-27 19:10:24 -08:00
inet_sock.h	ipv4: remove is_data also from ip_options documentation.	2013-06-12 03:13:50 -07:00
inet_timewait_sock.h	hlist: drop the node parameter from iterators	2013-02-27 19:10:24 -08:00
inetpeer.h	ipv4: Maintain redirect and PMTU info in struct rtable again.	2012-07-10 22:40:14 -07:00
ip.h	ip: generate unique IP identificator if local fragmentation is allowed	2013-09-19 14:11:15 -04:00
ip6_checksum.h	ipv6: move csum_ipv6_magic() and udp6_csum_init() into static library	2013-01-08 17:56:10 -08:00
ip6_fib.h	ipv6: prevent fib6_run_gc() contention	2013-08-01 14:16:20 -07:00
ip6_route.h	ipv6: move ip6_dst_hoplimit() into core kernel	2013-08-31 22:29:59 -04:00
ip6_tunnel.h	tunnels: harmonize cleanup done on skb on xmit path	2013-09-04 00:27:25 -04:00
ip_fib.h	ipv4: remove fib_update_nh_saddrs() declaration.	2013-07-02 00:33:52 -07:00
ip_tunnels.h	tunnels: harmonize cleanup done on skb on xmit path	2013-09-04 00:27:25 -04:00
ip_vs.h	ipvs: make the service replacement more robust	2013-09-18 14:39:03 -05:00
ipcomp.h	…
ipconfig.h	…
ipv6.h	ipv6: move ip6_dst_hoplimit() into core kernel	2013-08-31 22:29:59 -04:00
ipx.h	…
iw_handler.h	…
lapb.h	…
lib80211.h	hostap: Don't use create_proc_read_entry()	2013-04-29 15:41:56 -04:00
llc.h	llc: Remove stray reference to sysctl_llc_station_ack_timeout.	2012-09-17 13:13:24 -04:00
llc_c_ac.h	…
llc_c_ev.h	…
llc_c_st.h	…
llc_conn.h	…
llc_if.h	llc: Use normal etherdevice.h tests	2013-09-03 22:34:47 -04:00
llc_pdu.h	…
llc_s_ac.h	…
llc_s_ev.h	…
llc_s_st.h	…
llc_sap.h	…
mac80211.h	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem	2013-08-29 14:08:24 -04:00
mac802154.h	mac802154: add wpan device-class support	2012-06-26 21:06:11 -07:00
mip6.h	…
mld.h	net: ipv6: mld: get rid of MLDV2_MRC and simplify calculation	2013-09-04 14:53:20 -04:00
mrp.h	mrp: add periodictimer to allow retries when packets get lost	2013-09-23 16:53:52 -04:00
ndisc.h	ipv6: don't call fib6_run_gc() until routing is ready	2013-09-11 17:04:09 -04:00
neighbour.h	arp/neighbour.h: Remove extern from function prototypes	2013-07-31 17:50:02 -07:00
net_namespace.h	net: Delay default_device_exit_batch until no devices are unregistering v2	2013-09-28 15:09:15 -07:00
net_ratelimit.h	…
netdma.h	…
netevent.h	ipv6 netevent: Remove old_neigh from netevent_redirect.	2013-01-14 15:04:59 -05:00
netlabel.h	userns: Convert the audit loginuid to be a kuid	2012-09-17 18:08:54 -07:00
netlink.h	netlink: Rename pid to portid to avoid confusion	2012-09-10 15:30:41 -04:00
netprio_cgroup.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2013-09-05 14:54:29 -07:00
netrom.h	hlist: drop the node parameter from iterators	2013-02-27 19:10:24 -08:00
nexthop.h	…
nl802154.h	…
p8022.h	…
ping.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-06-05 16:37:30 -07:00
pkt_cls.h	net: Remove extern from include/net/ scheduling prototypes	2013-07-31 17:24:22 -07:00
pkt_sched.h	qdisc: allow setting default queuing discipline	2013-08-31 00:32:32 -04:00
protocol.h	net: Remove code duplication between offload structures	2012-11-15 17:39:51 -05:00
psnap.h	…
raw.h	…
rawv6.h	…
red.h	…
regulatory.h	regulatory: use RCU to protect last_request	2013-01-03 13:01:30 +01:00
request_sock.h	net: remove a stale comment for dl_next	2013-04-22 15:55:48 -04:00
rose.h	…
route.h	xfrm: introduce helper for safe determination of mtu	2013-08-14 13:09:07 +02:00
rtnetlink.h	rtnetlink: Remove passing of attributes into rtnl_doit functions	2013-03-22 10:31:16 -04:00
sch_generic.h	qdisc: make args to qdisc_create_default const	2013-08-31 18:09:45 -04:00
scm.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-04-22 20:32:51 -04:00
secure_seq.h	net: net_secret should not depend on TCP	2013-09-28 15:19:40 -07:00
slhc_vj.h	…
snmp.h	net: avoid reloads in SNMP_UPD_PO_STATS	2012-08-06 13:40:47 -07:00
sock.h	net: fix unsafe set_memory_rw from softirq	2013-10-07 15:16:45 -04:00
stp.h	…
tcp.h	tcp: Change return value of tcp_rcv_established()	2013-09-04 00:27:28 -04:00
tcp_memcontrol.h	…
tcp_states.h	…
timewait_sock.h	…
transp_v6.h	transp_v6.h: style neatening	2013-06-04 16:43:42 -07:00
udp.h	pktgen: Add UDPCSUM flag to support UDP checksums	2013-07-27 22:16:36 -07:00
udplite.h	…
vsock_addr.h	VSOCK: Move af_vsock.h and vsock_addr.h to include/net	2013-07-27 22:14:06 -07:00
vxlan.h	vxlan: Notify drivers for listening UDP port changes	2013-09-05 12:44:30 -04:00
wext.h	…
wimax.h	…
wpan-phy.h	…
x25.h	…
x25device.h	…
xfrm.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-09-05 14:58:52 -04:00