Oliver Neukum dd125fcd58 Revert "xhci: add quirk for host controllers that don't update endpoint DCS" ... commit 5bef4b3cb9 upstream. This reverts commit 5255660b20. This quirk breaks at least the following hardware: 0b:00.0 0c03: 1106:3483 (rev 01) (prog-if 30 [XHCI]) Subsystem: 1106:3483 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 66 Region 0: Memory at fb400000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] MSI: Enable+ Count=1/4 Maskable- 64bit+ Address: 00000000fee007b8 Data: 0000 Capabilities: [c4] Express (v2) Endpoint, MSI 00 DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- SlotPowerLimit 89W DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq- RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+ MaxPayload 128 bytes, MaxReadReq 512 bytes DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+ TransPend- LnkCap: Port #0, Speed 5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s <2us, L1 <16us ClockPM+ Surprise- LLActRep- BwNot- ASPMOptComp- LnkCtl: ASPM Disabled; RCB 64 bytes, Disabled- CommClk+ ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- LnkSta: Speed 5GT/s, Width x1 TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt- DevCap2: Completion Timeout: Range B, TimeoutDis+ NROPrPrP- LTR- 10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix- EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit- FRS- TPHComp- ExtTPHComp- AtomicOpsCap: 32bit- 64bit- 128bitCAS- DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- 10BitTagReq- OBFF Disabled, AtomicOpsCtl: ReqEn- LnkCtl2: Target Link Speed: 5GT/s, EnterCompliance- SpeedDis- Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS- Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB preshoot LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete- EqualizationPhase1- EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest- Retimer- 2Retimers- CrosslinkRes: unsupported Capabilities: [100 v1] Advanced Error Reporting UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol- UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol- UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol- CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr- CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+ AERCap: First Error Pointer: 00, ECRCGenCap- ECRCGenEn- ECRCChkCap- ECRCChkEn- MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap- HeaderLog: 00000000 00000000 00000000 00000000 Kernel driver in use: xhci_hcd Kernel modules: xhci_pci with the quirk enabled it fails early with [ 0.754373] pci 0000:0b:00.0: xHCI HW did not halt within 32000 usec status = 0x1000 [ 0.754419] pci 0000:0b:00.0: quirk_usb_early_handoff+0x0/0x7a0 took 31459 usecs [ 2.228048] xhci_hcd 0000:0b:00.0: xHCI Host Controller [ 2.228053] xhci_hcd 0000:0b:00.0: new USB bus registered, assigned bus number 7 [ 2.260073] xhci_hcd 0000:0b:00.0: Host halt failed, -110 [ 2.260079] xhci_hcd 0000:0b:00.0: can't setup: -110 [ 2.260551] xhci_hcd 0000:0b:00.0: USB bus 7 deregistered [ 2.260624] xhci_hcd 0000:0b:00.0: init 0000:0b:00.0 fail, -110 [ 2.260639] xhci_hcd: probe of 0000:0b:00.0 failed with error -110 The hardware in question is an external PCIe card. It looks to me like the quirk needs to be narrowed down. But this needs information about the hardware showing the issue this quirk is to fix. So for now a clean revert. Signed-off-by: Oliver Neukum <oneukum@suse.com> Fixes: 5255660b20 ("xhci: add quirk for host controllers that don't update endpoint DCS") Cc: stable <stable@kernel.org> Link: https://lore.kernel.org/r/20230713112830.21773-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-08-03 10:22:43 +02:00
..
Kconfig	usb: host: remove dead EHCI support for on-chip PMC MSP71xx USB controller	2021-08-18 15:32:19 +02:00
Makefile	usb: xhci-mtk: support to build xhci-mtk-hcd.ko	2021-03-10 09:37:17 +01:00
bcma-hcd.c	USB: bcma: Make GPIO explicitly optional	2022-11-26 09:24:44 +01:00
ehci-atmel.c	…
ehci-brcm.c	USB: ehci_brcm_hub_control: Improve port index sanitizing	2022-01-27 11:04:26 +01:00
ehci-dbg.c	…
ehci-exynos.c	…
ehci-fsl.c	usb: host: ehci-fsl: Fix module alias	2023-01-24 07:22:46 +01:00
ehci-fsl.h	…
ehci-grlib.c	…
ehci-hcd.c	usb: ehci: handshake CMD_RUN instead of STS_HALT	2021-11-12 15:05:47 +01:00
ehci-hub.c	usb: host: move EH SINGLE_STEP_SET_FEATURE implementation to core	2021-05-13 16:01:59 +02:00
ehci-mem.c	…
ehci-mv.c	USB: EHCI: ehci-mv: improve error handling in mv_ehci_enable()	2021-07-21 10:04:41 +02:00
ehci-npcm7xx.c	…
ehci-omap.c	usb: ehci-omap: Fix PM disable depth umbalance in ehci_hcd_omap_probe	2020-12-09 14:33:45 +01:00
ehci-orion.c	usb: ehci-orion: Handle errors of clk_prepare_enable() in probe	2021-08-26 13:09:34 +02:00
ehci-pci.c	usb: ehci: add pci device support for Aspeed platforms	2022-04-13 20:59:04 +02:00
ehci-platform.c	usb: ehci: handshake CMD_RUN instead of STS_HALT	2021-11-12 15:05:47 +01:00
ehci-ppc-of.c	usb: host: Fix refcount leak in ehci_hcd_ppc_of_probe	2022-08-17 14:23:41 +02:00
ehci-ps3.c	powerpc/ps3: make system bus's remove and shutdown callbacks return void	2020-12-04 01:01:22 +11:00
ehci-q.c	usb: host: move EH SINGLE_STEP_SET_FEATURE implementation to core	2021-05-13 16:01:59 +02:00
ehci-sched.c	…
ehci-sh.c	…
ehci-spear.c	…
ehci-st.c	…
ehci-sysfs.c	…
ehci-timer.c	…
ehci-xilinx-of.c	…
ehci.h	usb: ehci: handshake CMD_RUN instead of STS_HALT	2021-11-12 15:05:47 +01:00
fhci-dbg.c	…
fhci-hcd.c	…
fhci-hub.c	…
fhci-mem.c	…
fhci-q.c	…
fhci-sched.c	…
fhci-tds.c	…
fhci.h	…
fotg210-hcd.c	USB: fotg210: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:36 +01:00
fotg210.h	usb: host: fotg210: fix the actual_length of an iso packet	2021-07-21 10:03:42 +02:00
fsl-mph-dr-of.c	…
isp116x-hcd.c	USB: isp116x: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:36 +01:00
isp116x.h	USB: host: isp116x: remove dentry pointer for debugfs	2021-03-10 09:37:15 +01:00
isp1362-hcd.c	USB: isp1362: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:36 +01:00
isp1362.h	USB: host: isp1362: remove dentry pointer for debugfs	2021-03-10 09:37:15 +01:00
max3421-hcd.c	usb: max-3421: Fix setting of I/O pins	2023-03-10 09:39:41 +01:00
ohci-at91.c	usb: ohci-at91: Fix the unhandle interrupt when resume	2023-08-03 10:22:42 +02:00
ohci-da8xx.c	…
ohci-dbg.c	…
ohci-exynos.c	…
ohci-hcd.c	…
ohci-hub.c	…
ohci-mem.c	…
ohci-nxp.c	usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe	2022-08-17 14:23:41 +02:00
ohci-omap.c	ARM: omap1: move omap15xx local bus handling to usb.c	2021-10-05 15:39:50 +02:00
ohci-pci.c	…
ohci-platform.c	…
ohci-ppc-of.c	usb: host: ohci-ppc-of: Fix refcount leak bug	2022-08-25 11:40:33 +02:00
ohci-ps3.c	powerpc/ps3: make system bus's remove and shutdown callbacks return void	2020-12-04 01:01:22 +11:00
ohci-pxa27x.c	…
ohci-q.c	…
ohci-s3c2410.c	…
ohci-sa1111.c	ARM: 9048/1: sa1111: make sa1111 bus's remove callback return void	2021-02-01 19:42:13 +00:00
ohci-sm501.c	…
ohci-spear.c	usb: host: ohci-spear: simplify calling usb_add_hcd()	2021-07-21 10:05:05 +02:00
ohci-st.c	…
ohci-tmio.c	usb: host: ohci-tmio: check return value after calling platform_get_resource()	2021-11-25 09:48:28 +01:00
ohci.h	…
oxu210hp-hcd.c	drivers: usb: host: Fix deadlock in oxu_bus_suspend()	2022-06-14 18:36:21 +02:00
pci-quirks.c	…
pci-quirks.h	…
r8a66597-hcd.c	…
r8a66597.h	…
sl811-hcd.c	USB: sl811: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:35 +01:00
sl811.h	USB: host: sl811: remove dentry pointer for debugfs	2021-03-10 09:37:15 +01:00
sl811_cs.c	usb: host: Mundane spello fix in the file sl811_cs.c	2021-03-18 09:02:27 +01:00
ssb-hcd.c	…
u132-hcd.c	usb: host: u132-hcd: remove redundant continue statements	2021-06-17 15:31:50 +02:00
uhci-debug.c	…
uhci-grlib.c	…
uhci-hcd.c	USB: uhci: fix memory leak with using debugfs_lookup()	2023-03-11 13:57:35 +01:00
uhci-hcd.h	USB: host: uhci: remove dentry pointer for debugfs	2021-03-10 09:37:15 +01:00
uhci-hub.c	…
uhci-pci.c	USB: UHCI: adjust zhaoxin UHCI controllers OverCurrent bit value	2023-05-24 17:36:52 +01:00
uhci-platform.c	usb: uhci: add aspeed ast2600 uhci support	2022-01-27 11:04:34 +01:00
uhci-q.c	…
xhci-dbg.c	…
xhci-dbgcap.c	xhci: dbc: Fix memory leak in xhci_alloc_dbc()	2022-10-26 12:34:19 +02:00
xhci-dbgcap.h	xhci: dbc: Rename xhci_dbc_init and xhci_dbc_exit	2022-07-29 17:25:27 +02:00
xhci-dbgtty.c	xhci: dbc: create and remove dbc structure in dbgtty driver.	2022-07-29 17:25:26 +02:00
xhci-debugfs.c	xhci: fix debugfs register accesses while suspended	2023-05-11 23:00:16 +09:00
xhci-debugfs.h	…
xhci-ext-caps.c	xhci: ext-caps: Use software node API with the properties	2021-02-05 10:08:19 +01:00
xhci-ext-caps.h	usb: xhci: Increase timeout for HC halt	2021-05-13 14:47:36 +02:00
xhci-histb.c	…
xhci-hub.c	xhci: Add grace period after xHC start to prevent premature runtime suspend.	2022-09-08 12:28:06 +02:00
xhci-mem.c	xhci: Show ZHAOXIN xHCI root hub speed correctly	2023-07-23 13:47:54 +02:00
xhci-mtk-sch.c	usb: xhci-mtk: fix bandwidth release issue	2022-09-08 12:28:07 +02:00
xhci-mtk.c	usb: xhci-mtk: set the dma max_seg_size	2023-08-03 10:22:42 +02:00
xhci-mtk.h	usb: xhci-mtk: allow bandwidth table rollover	2021-08-27 10:24:51 +02:00
xhci-mvebu.c	usb: host: xhci: mvebu: Iterate over array indexes instead of using pointer math	2023-03-11 13:57:37 +01:00
xhci-mvebu.h	usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720	2021-02-03 11:26:47 +01:00
xhci-pci-renesas.c	USB/Thunderbolt patches for 5.15-rc1	2021-09-01 09:59:34 -07:00
xhci-pci.c	Revert "xhci: add quirk for host controllers that don't update endpoint DCS"	2023-08-03 10:22:43 +02:00
xhci-pci.h	usb: renesas-xhci: Remove renesas_xhci_pci_exit()	2021-07-21 10:05:59 +02:00
xhci-plat.c	usb: host: xhci-plat: suspend/resume clks for brcm	2022-10-26 12:35:46 +02:00
xhci-plat.h	usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720	2021-02-03 11:26:47 +01:00
xhci-rcar.c	usb: host: xhci-rcar: remove leftover quirk handling	2023-05-11 23:00:31 +09:00
xhci-rcar.h	…
xhci-ring.c	Revert "xhci: add quirk for host controllers that don't update endpoint DCS"	2023-08-03 10:22:43 +02:00
xhci-tegra.c	Revert "usb: xhci: tegra: Fix error check"	2023-08-03 10:22:42 +02:00
xhci-trace.c	…
xhci-trace.h	xhci: fix even more unsafe memory usage in xhci tracing	2021-08-26 13:06:02 +02:00
xhci.c	xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu	2023-04-13 16:48:20 +02:00
xhci.h	xhci: Show ZHAOXIN xHCI root hub speed correctly	2023-07-23 13:47:54 +02:00