Xiu Jianfeng 4a557910bb cgroup: Do not corrupt task iteration when rebinding subsystem ... commit 6f363f5aa8 upstream. We found a refcount UAF bug as follows: refcount_t: addition on 0; use-after-free. WARNING: CPU: 1 PID: 342 at lib/refcount.c:25 refcount_warn_saturate+0xa0/0x148 Workqueue: events cpuset_hotplug_workfn Call trace: refcount_warn_saturate+0xa0/0x148 __refcount_add.constprop.0+0x5c/0x80 css_task_iter_advance_css_set+0xd8/0x210 css_task_iter_advance+0xa8/0x120 css_task_iter_next+0x94/0x158 update_tasks_root_domain+0x58/0x98 rebuild_root_domains+0xa0/0x1b0 rebuild_sched_domains_locked+0x144/0x188 cpuset_hotplug_workfn+0x138/0x5a0 process_one_work+0x1e8/0x448 worker_thread+0x228/0x3e0 kthread+0xe0/0xf0 ret_from_fork+0x10/0x20 then a kernel panic will be triggered as below: Unable to handle kernel paging request at virtual address 00000000c0000010 Call trace: cgroup_apply_control_disable+0xa4/0x16c rebind_subsystems+0x224/0x590 cgroup_destroy_root+0x64/0x2e0 css_free_rwork_fn+0x198/0x2a0 process_one_work+0x1d4/0x4bc worker_thread+0x158/0x410 kthread+0x108/0x13c ret_from_fork+0x10/0x18 The race that cause this bug can be shown as below: (hotplug cpu) | (umount cpuset) mutex_lock(&cpuset_mutex) | mutex_lock(&cgroup_mutex) cpuset_hotplug_workfn | rebuild_root_domains | rebind_subsystems update_tasks_root_domain | spin_lock_irq(&css_set_lock) css_task_iter_start | list_move_tail(&cset->e_cset_node[ss->id] while(css_task_iter_next) | &dcgrp->e_csets[ss->id]); css_task_iter_end | spin_unlock_irq(&css_set_lock) mutex_unlock(&cpuset_mutex) | mutex_unlock(&cgroup_mutex) Inside css_task_iter_start/next/end, css_set_lock is hold and then released, so when iterating task(left side), the css_set may be moved to another list(right side), then it->cset_head points to the old list head and it->cset_pos->next points to the head node of new list, which can't be used as struct css_set. To fix this issue, switch from all css_sets to only scgrp's css_sets to patch in-flight iterators to preserve correct iteration, and then update it->cset_head as well. Reported-by: Gaosheng Cui <cuigaosheng1@huawei.com> Link: https://www.spinics.net/lists/cgroups/msg37935.html Suggested-by: Michal Koutný <mkoutny@suse.com> Link: https://lore.kernel.org/all/20230526114139.70274-1-xiujianfeng@huaweicloud.com/ Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> Fixes: 2d8f243a5e ("cgroup: implement cgroup->e_csets[]") Cc: stable@vger.kernel.org # v3.16+ Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-06-28 10:29:43 +02:00
..
Makefile	cgroup: Add misc cgroup controller	2021-04-04 13:34:46 -04:00
cgroup-internal.h	memcg: fix possible use-after-free in memcg_write_event_control()	2022-12-14 11:37:19 +01:00
cgroup-v1.c	cgroup: Add missing cpus_read_lock() to cgroup_attach_task_all()	2022-09-23 14:15:52 +02:00
cgroup.c	cgroup: Do not corrupt task iteration when rebinding subsystem	2023-06-28 10:29:43 +02:00
cpuset.c	cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach()	2023-04-20 12:13:55 +02:00
debug.c	kernel: cgroup: fix misuse of %x	2019-05-06 08:47:48 -07:00
freezer.c	cgroup: freezer: don't change task and cgroups status unnecessarily	2019-11-07 07:38:41 -08:00
legacy_freezer.c	cgroup: rename freezer.c into legacy_freezer.c	2019-04-19 11:26:48 -07:00
misc.c	svm/sev: Register SEV and SEV-ES ASIDs to the misc controller	2021-04-04 13:34:46 -04:00
namespace.c	memcg: enable accounting for new namesapces and struct nsproxy	2021-09-03 09:58:12 -07:00
pids.c	clone3: allow spawning processes into cgroups	2020-02-12 17:57:51 -05:00
rdma.c	cgroup: fix spelling mistakes	2021-05-24 12:45:26 -04:00
rstat.c	cgroup: Fix rootcg cpu.stat guest double counting	2021-11-18 19:16:45 +01:00