Jerry Snitselaar f2b32ce1cc iommu/vt-d: clean up pr_irq if request_threaded_irq fails ... [ Upstream commit 72d5481138 ] It is unlikely request_threaded_irq will fail, but if it does for some reason we should clear iommu->pr_irq in the error path. Also intel_svm_finish_prq shouldn't try to clean up the page request interrupt if pr_irq is 0. Without these, if request_threaded_irq were to fail the following occurs: fail with no fixes: [ 0.683147] ------------[ cut here ]------------ [ 0.683148] NULL pointer, cannot free irq [ 0.683158] WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:1632 irq_domain_free_irqs+0x126/0x140 [ 0.683160] Modules linked in: [ 0.683163] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc2 #3 [ 0.683165] Hardware name: /NUC7i3BNB, BIOS BNKBL357.86A.0036.2017.0105.1112 01/05/2017 [ 0.683168] RIP: 0010:irq_domain_free_irqs+0x126/0x140 [ 0.683169] RSP: 0000:ffffc90000037ce8 EFLAGS: 00010292 [ 0.683171] RAX: 000000000000001d RBX: ffff880276283c00 RCX: ffffffff81c5e5e8 [ 0.683172] RDX: 0000000000000001 RSI: 0000000000000096 RDI: 0000000000000246 [ 0.683174] RBP: ffff880276283c00 R08: 0000000000000000 R09: 000000000000023c [ 0.683175] R10: 0000000000000007 R11: 0000000000000000 R12: 000000000000007a [ 0.683176] R13: 0000000000000001 R14: 0000000000000000 R15: 0000010010000000 [ 0.683178] FS: 0000000000000000(0000) GS:ffff88027ec80000(0000) knlGS:0000000000000000 [ 0.683180] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.683181] CR2: 0000000000000000 CR3: 0000000001c09001 CR4: 00000000003606e0 [ 0.683182] Call Trace: [ 0.683189] intel_svm_finish_prq+0x3c/0x60 [ 0.683191] free_dmar_iommu+0x1ac/0x1b0 [ 0.683195] init_dmars+0xaaa/0xaea [ 0.683200] ? klist_next+0x19/0xc0 [ 0.683203] ? pci_do_find_bus+0x50/0x50 [ 0.683205] ? pci_get_dev_by_id+0x52/0x70 [ 0.683208] intel_iommu_init+0x498/0x5c7 [ 0.683211] pci_iommu_init+0x13/0x3c [ 0.683214] ? e820__memblock_setup+0x61/0x61 [ 0.683217] do_one_initcall+0x4d/0x1a0 [ 0.683220] kernel_init_freeable+0x186/0x20e [ 0.683222] ? set_debug_rodata+0x11/0x11 [ 0.683225] ? rest_init+0xb0/0xb0 [ 0.683226] kernel_init+0xa/0xff [ 0.683229] ret_from_fork+0x1f/0x30 [ 0.683259] Code: 89 ee 44 89 e7 e8 3b e8 ff ff 5b 5d 44 89 e7 44 89 ee 41 5c 41 5d 41 5e e9 a8 84 ff ff 48 c7 c7 a8 71 a7 81 31 c0 e8 6a d3 f9 ff <0f> ff 5b 5d 41 5c 41 5d 41 5 e c3 0f 1f 44 00 00 66 2e 0f 1f 84 [ 0.683285] ---[ end trace f7650e42792627ca ]--- with iommu->pr_irq = 0, but no check in intel_svm_finish_prq: [ 0.669561] ------------[ cut here ]------------ [ 0.669563] Trying to free already-free IRQ 0 [ 0.669573] WARNING: CPU: 3 PID: 1 at kernel/irq/manage.c:1546 __free_irq+0xa4/0x2c0 [ 0.669574] Modules linked in: [ 0.669577] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc2 #4 [ 0.669579] Hardware name: /NUC7i3BNB, BIOS BNKBL357.86A.0036.2017.0105.1112 01/05/2017 [ 0.669581] RIP: 0010:__free_irq+0xa4/0x2c0 [ 0.669582] RSP: 0000:ffffc90000037cc0 EFLAGS: 00010082 [ 0.669584] RAX: 0000000000000021 RBX: 0000000000000000 RCX: ffffffff81c5e5e8 [ 0.669585] RDX: 0000000000000001 RSI: 0000000000000086 RDI: 0000000000000046 [ 0.669587] RBP: 0000000000000000 R08: 0000000000000000 R09: 000000000000023c [ 0.669588] R10: 0000000000000007 R11: 0000000000000000 R12: ffff880276253960 [ 0.669589] R13: ffff8802762538a4 R14: ffff880276253800 R15: ffff880276283600 [ 0.669593] FS: 0000000000000000(0000) GS:ffff88027ed80000(0000) knlGS:0000000000000000 [ 0.669594] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.669596] CR2: 0000000000000000 CR3: 0000000001c09001 CR4: 00000000003606e0 [ 0.669602] Call Trace: [ 0.669616] free_irq+0x30/0x60 [ 0.669620] intel_svm_finish_prq+0x34/0x60 [ 0.669623] free_dmar_iommu+0x1ac/0x1b0 [ 0.669627] init_dmars+0xaaa/0xaea [ 0.669631] ? klist_next+0x19/0xc0 [ 0.669634] ? pci_do_find_bus+0x50/0x50 [ 0.669637] ? pci_get_dev_by_id+0x52/0x70 [ 0.669639] intel_iommu_init+0x498/0x5c7 [ 0.669642] pci_iommu_init+0x13/0x3c [ 0.669645] ? e820__memblock_setup+0x61/0x61 [ 0.669648] do_one_initcall+0x4d/0x1a0 [ 0.669651] kernel_init_freeable+0x186/0x20e [ 0.669653] ? set_debug_rodata+0x11/0x11 [ 0.669656] ? rest_init+0xb0/0xb0 [ 0.669658] kernel_init+0xa/0xff [ 0.669661] ret_from_fork+0x1f/0x30 [ 0.669662] Code: 7a 08 75 0e e9 c3 01 00 00 4c 39 7b 08 74 57 48 89 da 48 8b 5a 18 48 85 db 75 ee 89 ee 48 c7 c7 78 67 a7 81 31 c0 e8 4c 37 fa ff <0f> ff 48 8b 34 24 4c 89 ef e 8 0e 4c 68 00 49 8b 46 40 48 8b 80 [ 0.669688] ---[ end trace 58a470248700f2fc ]--- Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Joerg Roedel <joro@8bytes.org> Cc: Ashok Raj <ashok.raj@intel.com> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> Reviewed-by: Ashok Raj <ashok.raj@intel.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-03-24 11:01:26 +01:00
..
Kconfig	iommu/qcom: Depend on HAS_DMA to fix compile error	2017-09-19 15:30:41 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
amd_iommu.c	iommu/amd: Limit the IOVA page range to the specified addresses	2017-12-20 10:10:26 +01:00
amd_iommu_init.c	iommu/amd: pr_err() strings should end with newlines	2017-09-27 17:01:35 +02:00
amd_iommu_proto.h	IOMMU Updates for Linux v4.14	2017-09-09 15:03:24 -07:00
amd_iommu_types.h	IOMMU Updates for Linux v4.14	2017-09-09 15:03:24 -07:00
amd_iommu_v2.c	IOMMU Updates for Linux v4.14	2017-09-09 15:03:24 -07:00
arm-smmu-regs.h	iommu/arm-smmu: Split out register defines	2017-08-15 17:34:48 +02:00
arm-smmu-v3.c	iommu/arm-smmu-v3: Cope with duplicated Stream IDs	2018-01-10 09:31:21 +01:00
arm-smmu.c	Merge branches 'arm/exynos', 'arm/renesas', 'arm/rockchip', 'arm/omap', 'arm/mediatek', 'arm/tegra', 'arm/qcom', 'arm/smmu', 'ppc/pamu', 'x86/vt-d', 'x86/amd', 's390' and 'core' into next	2017-09-01 11:31:42 +02:00
dma-iommu.c	IOMMU Updates for Linux v4.13	2017-07-12 10:00:04 -07:00
dmar.c	iommu/vt-d: Fix harmless section mismatch warning	2017-09-19 11:44:46 +02:00
exynos-iommu.c	iommu/exynos: Remove initconst attribute to avoid potential kernel oops	2017-10-12 10:25:11 +02:00
fsl_pamu.c	Merge branches 'arm/exynos', 'arm/renesas', 'arm/rockchip', 'arm/omap', 'arm/mediatek', 'arm/tegra', 'arm/qcom', 'arm/smmu', 'ppc/pamu', 'x86/vt-d', 'x86/amd', 's390' and 'core' into next	2017-09-01 11:31:42 +02:00
fsl_pamu.h	iommu/pamu: Fix PAMU boot crash	2017-08-23 16:28:09 +02:00
fsl_pamu_domain.c	Merge branches 'arm/exynos', 'arm/renesas', 'arm/rockchip', 'arm/omap', 'arm/mediatek', 'arm/tegra', 'arm/qcom', 'arm/smmu', 'ppc/pamu', 'x86/vt-d', 'x86/amd', 's390' and 'core' into next	2017-09-01 11:31:42 +02:00
fsl_pamu_domain.h	iommu/pamu: Fix PAMU boot crash	2017-08-23 16:28:09 +02:00
intel-iommu.c	iommu/vt-d: Fix scatterlist offset handling	2017-12-14 09:52:55 +01:00
intel-svm.c	iommu/vt-d: clean up pr_irq if request_threaded_irq fails	2018-03-24 11:01:26 +01:00
intel_irq_remapping.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
io-pgtable-arm-v7s.c	iommu/io-pgtable-arm-v7s: Need dma-sync while there is no QUIRK_NO_DMA	2017-09-27 16:56:17 +02:00
io-pgtable-arm.c	iommu/io-pgtable: Sanitise map/unmap addresses	2017-07-20 10:30:28 +01:00
io-pgtable.c	iommu/io-pgtable: Fix a brace coding style issue.	2016-04-05 15:34:29 +02:00
io-pgtable.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iommu-sysfs.c	iommu: Fix wrong freeing of iommu_device->dev	2017-08-15 13:58:48 +02:00
iommu-traces.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iommu.c	Merge branches 'arm/exynos', 'arm/renesas', 'arm/rockchip', 'arm/omap', 'arm/mediatek', 'arm/tegra', 'arm/qcom', 'arm/smmu', 'ppc/pamu', 'x86/vt-d', 'x86/amd', 's390' and 'core' into next	2017-09-01 11:31:42 +02:00
iova.c	iommu/iova: Add flush timer	2017-08-15 18:23:52 +02:00
ipmmu-vmsa.c	iommu/ipmmu-vmsa: Make ipmmu_gather_ops const	2017-08-30 15:10:53 +02:00
irq_remapping.c	x86/cpufeature: Replace cpu_has_apic with boot_cpu_has() usage	2016-04-13 11:37:41 +02:00
irq_remapping.h	iommu, x86: Setup Posted-Interrupts capability for Intel iommu	2015-06-12 11:33:52 +02:00
msm_iommu.c	iommu/msm: Add iommu_group support	2017-08-10 00:03:50 +02:00
msm_iommu.h	iommu/msm: Make use of iommu_device_register interface	2017-02-10 13:44:57 +01:00
msm_iommu_hw-8xxx.h	iommu/msm: Move mach includes to iommu directory	2013-08-06 11:18:03 -07:00
mtk_iommu.c	iommu/mediatek: Limit the physical address in 32bit for v7s	2017-09-27 16:58:28 +02:00
mtk_iommu.h	iommu/mediatek: Merge 2 M4U HWs into one iommu domain	2017-08-22 16:37:59 +02:00
mtk_iommu_v1.c	iommu/mediatek: Fix driver name	2017-12-20 10:10:24 +01:00
of_iommu.c	iommu/of: Remove PCI host bridge node check	2017-09-22 12:05:43 +02:00
omap-iommu-debug.c	iommu/omap: Align code with open parenthesis	2016-04-05 17:53:20 +02:00
omap-iommu.c	iommu/omap: Use DMA-API for performing cache flushes	2017-08-04 11:59:29 +02:00
omap-iommu.h	iommu/omap: Use DMA-API for performing cache flushes	2017-08-04 11:59:29 +02:00
omap-iopgtable.h	iommu/omap: Use BIT(x) macros in omap-iopgtable.h	2015-08-03 16:04:42 +02:00
qcom_iommu.c	iommu: qcom: annotate PM functions as __maybe_unused	2017-08-28 11:24:52 +02:00
rockchip-iommu.c	Merge branches 'arm/exynos', 'arm/renesas', 'arm/rockchip', 'arm/omap', 'arm/mediatek', 'arm/tegra', 'arm/qcom', 'arm/smmu', 'ppc/pamu', 'x86/vt-d', 'x86/amd', 's390' and 'core' into next	2017-09-01 11:31:42 +02:00
s390-iommu.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tegra-gart.c	iommu/tegra-gart: Add support for struct iommu_device	2017-08-17 16:31:34 +02:00
tegra-smmu.c	arm/tegra: Call bus_set_iommu() after iommu_device_register()	2017-08-30 17:28:32 +02:00