WSL2-Linux-Kernel/net/mptcp
Paolo Abeni cee4034a3d mptcp: fix lockdep false positive in mptcp_pm_nl_create_listen_socket()
Christoph reports a lockdep splat in the mptcp_subflow_create_socket()
error path, when such function is invoked by
mptcp_pm_nl_create_listen_socket().

Such code path acquires two separates, nested socket lock, with the
internal lock operation lacking the "nested" annotation. Adding that
in sock_release() for mptcp's sake only could be confusing.

Instead just add a new lockclass to the in-kernel msk socket,
re-initializing the lockdep infra after the socket creation.

Fixes: ad2171009d ("mptcp: fix locking for in-kernel listener creation")
Cc: stable@vger.kernel.org
Reported-by: Christoph Paasch <cpaasch@apple.com>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/354
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-03-10 21:42:56 -08:00
..
Kconfig
Makefile
bpf.c
crypto.c
crypto_test.c
ctrl.c
diag.c
fastopen.c
mib.c
mib.h
mptcp_diag.c
options.c
pm.c
pm_netlink.c mptcp: fix lockdep false positive in mptcp_pm_nl_create_listen_socket() 2023-03-10 21:42:56 -08:00
pm_userspace.c
protocol.c mptcp: fix UaF in listener shutdown 2023-03-10 21:42:56 -08:00
protocol.h mptcp: fix UaF in listener shutdown 2023-03-10 21:42:56 -08:00
sockopt.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-02-09 12:25:40 -08:00
subflow.c mptcp: avoid setting TCP_CLOSE state twice 2023-03-10 21:42:56 -08:00
syncookies.c
token.c
token_test.c