Marek Belisko 62d2feb980 staging: iio: hmc5843: Fix crash in probe function. ... Fix crash after issuing: echo hmc5843 0x1e > /sys/class/i2c-dev/i2c-2/device/new_device [ 37.180999] device: '2-001e': device_add [ 37.188293] bus: 'i2c': add device 2-001e [ 37.194549] PM: Adding info for i2c:2-001e [ 37.200958] bus: 'i2c': driver_probe_device: matched device 2-001e with driver hmc5843 [ 37.210815] bus: 'i2c': really_probe: probing driver hmc5843 with device 2-001e [ 37.224884] HMC5843 initialized [ 37.228759] ------------[ cut here ]------------ [ 37.233612] kernel BUG at mm/slab.c:505! [ 37.237701] Internal error: Oops - BUG: 0 [#1] PREEMPT [ 37.243103] Modules linked in: [ 37.246337] CPU: 0 Not tainted (3.3.1-gta04+ #28) [ 37.251647] PC is at kfree+0x84/0x144 [ 37.255493] LR is at kfree+0x20/0x144 [ 37.259338] pc : [<c00b408c>] lr : [<c00b4028>] psr: 40000093 [ 37.259368] sp : de249cd8 ip : 0000000c fp : 00000090 [ 37.271362] r10: 0000000a r9 : de229eac r8 : c0236274 [ 37.276855] r7 : c09d6490 r6 : a0000013 r5 : de229c00 r4 : de229c10 [ 37.283691] r3 : c0f00218 r2 : 00000400 r1 : c0eea000 r0 : c00b4028 [ 37.290527] Flags: nZcv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user [ 37.298095] Control: 10c5387d Table: 9e1d0019 DAC: 00000015 [ 37.304107] Process sh (pid: 91, stack limit = 0xde2482f0) [ 37.309844] Stack: (0xde249cd8 to 0xde24a000) [ 37.314422] 9cc0: de229c10 de229c00 [ 37.322998] 9ce0: de229c10 ffffffea 00000005 c0236274 de140a80 c00b4798 dec00080 de140a80 [ 37.331573] 9d00: c032f37c dec00080 000080d0 00000001 de229c00 de229c10 c048d578 00000005 [ 37.340148] 9d20: de229eac 0000000a 00000090 c032fa40 00000001 00000000 00000001 de229c10 [ 37.348724] 9d40: de229eac 00000029 c075b558 00000001 00000003 00000004 de229c10 c048d594 [ 37.357299] 9d60: 00000000 60000013 00000018 205b0007 37332020 3432322e 5d343838 c0060020 [ 37.365905] 9d80: de251600 00000001 00000000 de251600 00000001 c0065a84 de229c00 de229c48 [ 37.374481] 9da0: 00000006 0048d62c de229c38 de229c00 de229c00 de1f6c00 de1f6c20 00000001 [ 37.383056] 9dc0: 00000000 c048d62c 00000000 de229c00 de229c00 de1f6c00 de1f6c20 00000001 [ 37.391632] 9de0: 00000000 c048d62c 00000000 c0330164 00000000 de1f6c20 c048d62c de1f6c00 [ 37.400207] 9e00: c0330078 de1f6c04 c078d714 de189b58 00000000 c02ccfd8 de1f6c20 c0795f40 [ 37.408782] 9e20: c0238330 00000000 00000000 c02381a8 de1b9fc0 de1f6c20 de1f6c20 de249e48 [ 37.417358] 9e40: c0238330 c0236bb0 decdbed8 de7d0f14 de1f6c20 de1f6c20 de1f6c54 de1f6c20 [ 37.425933] 9e60: 00000000 c0238030 de1f6c20 c078d7bc de1f6c20 c02377ec de1f6c20 de1f6c28 [ 37.434509] 9e80: dee64cb0 c0236138 c047c554 de189b58 00000000 c004b45c de1f6c20 de1f6cd8 [ 37.443084] 9ea0: c0edfa6c de1f6c00 dee64c68 de1f6c04 de1f6c20 dee64cb8 c047c554 de189b58 [ 37.451690] 9ec0: 00000000 c02cd634 dee64c68 de249ef4 de23b008 dee64cb0 0000000d de23b000 [ 37.460266] 9ee0: de23b007 c02cd78c 00000002 00000000 00000000 35636d68 00333438 00000000 [ 37.468841] 9f00: 00000000 00000000 001e0000 00000000 00000000 00000000 00000000 0a10cec0 [ 37.477416] 9f20: 00000002 de249f80 0000000d dee62990 de189b40 c0234d88 0000000d c010c354 [ 37.485992] 9f40: 0000000d de210f28 000acc88 de249f80 0000000d de248000 00000000 c00b7bf8 [ 37.494567] 9f60: de210f28 000acc88 de210f28 000acc88 00000000 00000000 0000000d c00b7ed8 [ 37.503143] 9f80: 00000000 00000000 0000000d 00000000 0007fa28 0000000d 000acc88 00000004 [ 37.511718] 9fa0: c000e544 c000e380 0007fa28 0000000d 00000001 000acc88 0000000d 00000000 [ 37.520294] 9fc0: 0007fa28 0000000d 000acc88 00000004 00000001 00000020 00000002 00000000 [ 37.528869] 9fe0: 00000000 beab8624 0000ea05 b6eaebac 600d0010 00000001 00000000 00000000 [ 37.537475] [<c00b408c>] (kfree+0x84/0x144) from [<c0236274>] (device_add+0x530/0x57c) [ 37.545806] [<c0236274>] (device_add+0x530/0x57c) from [<c032fa40>] (iio_device_register+0x8c8/0x990) [ 37.555480] [<c032fa40>] (iio_device_register+0x8c8/0x990) from [<c0330164>] (hmc5843_probe+0xec/0x114) [ 37.565338] [<c0330164>] (hmc5843_probe+0xec/0x114) from [<c02ccfd8>] (i2c_device_probe+0xc4/0xf8) [ 37.574737] [<c02ccfd8>] (i2c_device_probe+0xc4/0xf8) from [<c02381a8>] (driver_probe_device+0x118/0x218) [ 37.584777] [<c02381a8>] (driver_probe_device+0x118/0x218) from [<c0236bb0>] (bus_for_each_drv+0x4c/0x84) [ 37.594818] [<c0236bb0>] (bus_for_each_drv+0x4c/0x84) from [<c0238030>] (device_attach+0x78/0xa4) [ 37.604125] [<c0238030>] (device_attach+0x78/0xa4) from [<c02377ec>] (bus_probe_device+0x28/0x9c) [ 37.613433] [<c02377ec>] (bus_probe_device+0x28/0x9c) from [<c0236138>] (device_add+0x3f4/0x57c) [ 37.622650] [<c0236138>] (device_add+0x3f4/0x57c) from [<c02cd634>] (i2c_new_device+0xf8/0x19c) [ 37.631805] [<c02cd634>] (i2c_new_device+0xf8/0x19c) from [<c02cd78c>] (i2c_sysfs_new_device+0xb4/0x130) [ 37.641754] [<c02cd78c>] (i2c_sysfs_new_device+0xb4/0x130) from [<c0234d88>] (dev_attr_store+0x18/0x24) [ 37.651611] [<c0234d88>] (dev_attr_store+0x18/0x24) from [<c010c354>] (sysfs_write_file+0x10c/0x140) [ 37.661193] [<c010c354>] (sysfs_write_file+0x10c/0x140) from [<c00b7bf8>] (vfs_write+0xb0/0x178) [ 37.670410] [<c00b7bf8>] (vfs_write+0xb0/0x178) from [<c00b7ed8>] (sys_write+0x3c/0x68) [ 37.678833] [<c00b7ed8>] (sys_write+0x3c/0x68) from [<c000e380>] (ret_fast_syscall+0x0/0x3c) [ 37.687683] Code: 1593301c e5932000 e3120080 1a000000 (e7f001f2) [ 37.700775] ---[ end trace aaf805debdb69390 ]--- Client data was assigned to iio_dev structure in probe but in hmc5843_init_client function casted to private driver data structure which is wrong. Possibly calling mutex_init(&data->lock); corrupt data which the lead to above crash. Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Cc: stable <stable@vger.kernel.org> Acked-by: Jonathan Cameron <jic23@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2012-04-12 14:34:31 -07:00
..
Documentation	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
accel	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
adc	staging: iio: Convert platform_drivers to use module_platform_driver	2012-03-02 16:35:39 -08:00
addac	staging:iio: Use dev_pm_ops	2012-02-24 12:11:13 -08:00
cdc	staging:iio: Rename IIO_EVENT_CODE_EXTRACT_NUM to IIO_EVENT_CODE_EXTRACT_CHAN	2012-02-13 20:10:32 -08:00
dac	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-03-20 21:12:50 -07:00
dds	staging:iio:dds:ad9834 unwind use of is_visible for attrs.	2012-02-09 10:06:05 -08:00
gyro	The following text was taken from the original review request:	2012-03-24 10:24:31 -07:00
impedance-analyzer	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
imu	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
light	staging:iio:tsl2563 rewrite probe error handling	2012-03-07 13:36:45 -08:00
magnetometer	staging: iio: hmc5843: Fix crash in probe function.	2012-04-12 14:34:31 -07:00
meter	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
resolver	Merge branch 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging	2012-01-09 12:18:17 -08:00
trigger	staging: iio: Convert platform_drivers to use module_platform_driver	2012-03-02 16:35:39 -08:00
Kconfig	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
Makefile	staging:iio::hwmon interface client driver.	2012-02-24 12:10:03 -08:00
TODO	staging: iio: add ADI info to TODO	2010-11-09 15:46:32 -08:00
buffer.h	staging:iio: Remove declaration for non existing function	2012-02-24 12:14:03 -08:00
consumer.h	staging:iio:core add in kernel interface mapping and getting IIO channels.	2012-02-24 12:10:02 -08:00
driver.h	staging:iio:core add in kernel interface mapping and getting IIO channels.	2012-02-24 12:10:02 -08:00
events.h	staging:iio: Add missing event code extract macros	2012-02-13 20:10:32 -08:00
iio.h	staging: iio: core: Introduce debugfs support, add support for direct register access	2012-03-02 16:35:39 -08:00
iio_core.h	staging:iio: Factor out event handling into its own file	2012-02-09 10:05:06 -08:00
iio_core_trigger.h	staging:iio:triggers Remove unecessary existence checks and return val	2011-11-26 16:30:30 -08:00
iio_dummy_evgen.c	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
iio_dummy_evgen.h	staging:iio:dummy Add event support + fake event generator	2011-10-17 15:36:30 -07:00
iio_hwmon.c	staging:iio::hwmon interface client driver.	2012-02-24 12:10:03 -08:00
iio_simple_dummy.c	staging: iio: Use kcalloc instead of kzalloc to allocate array	2011-11-30 19:37:33 +09:00
iio_simple_dummy.h	staging:iio:dummy Add buffered reading support	2011-10-17 15:36:30 -07:00
iio_simple_dummy_buffer.c	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
iio_simple_dummy_events.c	staging:iio: header reorganization	2011-11-26 16:35:04 -08:00
industrialio-buffer.c	iio: core: constitfy available_scan_mask	2012-02-24 12:14:04 -08:00
industrialio-core.c	staging:iio: Fix compile error without CONFIG_DEBUG_FS	2012-03-07 13:26:52 -08:00
industrialio-event.c	staging:iio:events: Remove obsolete documentation	2012-02-13 20:10:32 -08:00
industrialio-trigger.c	Merge branch 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging	2012-01-09 12:18:17 -08:00
inkern.c	staging:iio:core add missing increment of loop index in iio_map_array_unregister()	2012-04-10 09:17:33 -07:00
kfifo_buf.c	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
kfifo_buf.h	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
machine.h	staging:iio:core add in kernel interface mapping and getting IIO channels.	2012-02-24 12:10:02 -08:00
ring_hw.h	staging:iio: replacing term ring with buffer in the IIO core.	2011-09-26 17:31:53 -07:00
ring_sw.c	drivers:staging:iio Fix typos and comments in staging iio.	2012-03-02 16:33:52 -08:00
ring_sw.h	staging:iio: Setup buffer access functions when allocating the buffer	2012-02-09 10:03:51 -08:00
sysfs.h	staging:iio: header reorganization	2011-11-26 16:35:04 -08:00
trigger.h	staging:iio: iio_trigger contains defunct owner field. Remove it.	2011-12-16 10:56:26 -08:00
trigger_consumer.h	staging:iio: treewide rename iio_triggered_ring_* to iio_triggered_buffer_*	2011-09-26 17:31:52 -07:00
types.h	staging:iio: move iio data return types into types.h for use by inkern	2012-02-24 12:10:03 -08:00