Trevor Wu 2a4f0ad59d ASoC: mediatek: mt8195: fix use-after-free in driver remove path ... [ Upstream commit dc93f0dcb4 ] During mt8195_afe_init_clock(), mt8195_audsys_clk_register() was called followed by several other devm functions. At mt8195_afe_deinit_clock() located at mt8195_afe_pcm_dev_remove(), mt8195_audsys_clk_unregister() was called. However, there was an issue with the order in which these functions were called. Specifically, the remove callback of platform_driver was called before devres released the resource, resulting in a use-after-free issue during remove time. At probe time, the order of calls was: 1. mt8195_audsys_clk_register 2. afe_priv->clk = devm_kcalloc 3. afe_priv->clk[i] = devm_clk_get At remove time, the order of calls was: 1. mt8195_audsys_clk_unregister 3. free afe_priv->clk[i] 2. free afe_priv->clk To resolve the problem, we can utilize devm_add_action_or_reset() in mt8195_audsys_clk_register() so that the remove order can be changed to 3->2->1. Fixes: 6746cc8582 ("ASoC: mediatek: mt8195: add platform driver") Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20230601033318.10408-3-trevor.wu@mediatek.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-06-14 11:13:08 +02:00
..
ac97	…
aoa	ALSA: aoa: Fix I2S device accounting	2022-11-03 23:59:18 +09:00
arm	…
atmel	…
core	ALSA: oss: avoid missing-prototype warnings	2023-06-09 10:32:26 +02:00
drivers	ALSA: mts64: fix possible null-ptr-defer in snd_mts64_interrupt	2022-12-31 13:14:16 +01:00
firewire	ALSA: firewire-digi00x: prevent potential use after free	2023-05-24 17:36:49 +01:00
hda	ALSA: hda: Fix unhandled register update during auto-suspend period	2023-05-30 13:55:30 +01:00
i2c	ALSA: i2c/cs8427: fix iec958 mixer control deactivation	2023-04-20 12:13:51 +02:00
isa	…
mips	…
oss	sound/oss/dmasound: fix 'dmasound_setup' defined but not used	2023-05-11 23:00:40 +09:00
parisc	…
pci	ALSA: hda/realtek: Add Lenovo P3 Tower platform	2023-06-14 11:13:05 +02:00
pcmcia	…
ppc	…
sh	…
soc	ASoC: mediatek: mt8195: fix use-after-free in driver remove path	2023-06-14 11:13:08 +02:00
sparc	…
spi	…
synth	ALSA: emux: Avoid potential array out-of-bound in snd_emux_xg_control()	2023-02-14 19:17:56 +01:00
usb	ALSA: usb-audio: Add a sample rate workaround for Line6 Pod Go	2023-05-24 17:36:52 +01:00
virtio	…
x86	…
xen	…
Kconfig	…
Makefile	…
ac97_bus.c	…
last.c	…
sound_core.c	…