Taehee Yoo 1962f86b42 virt_wifi: fix refcnt leak in module exit routine ... virt_wifi_newlink() calls netdev_upper_dev_link() and it internally holds reference count of lower interface. Current code does not release a reference count of the lower interface when the lower interface is being deleted. So, reference count leaks occur. Test commands: ip link add dummy0 type dummy ip link add vw1 link dummy0 type virt_wifi ip link del dummy0 Splat looks like: [ 133.787526][ T788] WARNING: CPU: 1 PID: 788 at net/core/dev.c:8274 rollback_registered_many+0x835/0xc80 [ 133.788355][ T788] Modules linked in: virt_wifi cfg80211 dummy team af_packet sch_fq_codel ip_tables x_tables unix [ 133.789377][ T788] CPU: 1 PID: 788 Comm: ip Not tainted 5.4.0-rc3+ #96 [ 133.790069][ T788] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 133.791167][ T788] RIP: 0010:rollback_registered_many+0x835/0xc80 [ 133.791906][ T788] Code: 00 4d 85 ff 0f 84 b5 fd ff ff ba c0 0c 00 00 48 89 de 4c 89 ff e8 9b 58 04 00 48 89 df e8 30 [ 133.794317][ T788] RSP: 0018:ffff88805ba3f338 EFLAGS: 00010202 [ 133.795080][ T788] RAX: ffff88805e57e801 RBX: ffff88805ba34000 RCX: ffffffffa9294723 [ 133.796045][ T788] RDX: 1ffff1100b746816 RSI: 0000000000000008 RDI: ffffffffabcc4240 [ 133.797006][ T788] RBP: ffff88805ba3f4c0 R08: fffffbfff5798849 R09: fffffbfff5798849 [ 133.797993][ T788] R10: 0000000000000001 R11: fffffbfff5798848 R12: dffffc0000000000 [ 133.802514][ T788] R13: ffff88805ba3f440 R14: ffff88805ba3f400 R15: ffff88805ed622c0 [ 133.803237][ T788] FS: 00007f2e9608c0c0(0000) GS:ffff88806cc00000(0000) knlGS:0000000000000000 [ 133.804002][ T788] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 133.804664][ T788] CR2: 00007f2e95610603 CR3: 000000005f68c004 CR4: 00000000000606e0 [ 133.805363][ T788] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 133.806073][ T788] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 133.806787][ T788] Call Trace: [ 133.807069][ T788] ? generic_xdp_install+0x310/0x310 [ 133.807612][ T788] ? lock_acquire+0x164/0x3b0 [ 133.808077][ T788] ? is_bpf_text_address+0x5/0xf0 [ 133.808640][ T788] ? deref_stack_reg+0x9c/0xd0 [ 133.809138][ T788] ? __nla_validate_parse+0x98/0x1ab0 [ 133.809944][ T788] unregister_netdevice_many.part.122+0x13/0x1b0 [ 133.810599][ T788] rtnl_delete_link+0xbc/0x100 [ 133.811073][ T788] ? rtnl_af_register+0xc0/0xc0 [ 133.811672][ T788] rtnl_dellink+0x30e/0x8a0 [ 133.812205][ T788] ? is_bpf_text_address+0x5/0xf0 [ ... ] [ 144.110530][ T788] unregister_netdevice: waiting for dummy0 to become free. Usage count = 1 This patch adds notifier routine to delete upper interface before deleting lower interface. Fixes: c7cdba31ed ("mac80211-next: rtnetlink wifi simulation device") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-10-24 14:53:49 -07:00
..
appletalk	…
arcnet	drivers: net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
bonding	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
caif	caif: no need to check return value of debugfs_create functions	2019-08-11 21:31:25 -07:00
can	drivers: net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
dsa	net: dsa: microchip: Add shared regmap mutex	2019-10-17 15:38:46 -04:00
ethernet	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
fddi	…
fjes	…
hamradio	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
hippi	…
hyperv	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
ieee802154	Merge tag 'ieee802154-for-davem-2019-09-28' of git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan	2019-09-30 17:14:45 -07:00
ipvlan	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
netdevsim	netdevsim: Fix error handling in nsim_fib_init and nsim_fib_exit	2019-10-13 11:30:14 -07:00
phy	net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag	2019-10-23 21:44:44 -07:00
plip	…
ppp	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
slip	net: delete "register" keyword	2019-08-08 18:03:42 -07:00
team	team: fix nested locking lockdep warning	2019-10-24 14:53:48 -07:00
usb	r8152: add device id for Lenovo ThinkPad USB-C Dock Gen 2	2019-10-21 12:06:41 -07:00
vmxnet3	…
wan	net/wan: dscc4: remove broken dscc4 driver	2019-09-16 09:14:41 +02:00
wimax	wimax/i2400m: remove unlikely() from WARN*() condition	2019-09-26 10:10:30 -07:00
wireless	virt_wifi: fix refcnt leak in module exit routine	2019-10-24 14:53:49 -07:00
xen-netback	xen/netback: fix error path of xenvif_connect_data()	2019-10-19 11:43:29 -07:00
Kconfig	drivers: net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
LICENSE.SRC	…
Makefile	…
Space.c	…
dummy.c	…
eql.c	…
geneve.c	Convert usage of IN_MULTICAST to ipv4_is_multicast	2019-09-05 09:38:32 +02:00
gtp.c	…
ifb.c	…
loopback.c	…
macsec.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
macvlan.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
macvtap.c	…
mdio.c	…
mii.c	…
net_failover.c	…
netconsole.c	…
nlmon.c	…
ntb_netdev.c	…
rionet.c	…
sb1000.c	…
sungem_phy.c	…
tap.c	net: tap: clean up an indentation issue	2019-09-27 20:58:35 +02:00
thunderbolt.c	…
tun.c	tun: remove possible false sharing in tun_flow_update()	2019-10-09 21:29:33 -07:00
veth.c	…
virtio_net.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
vrf.c	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
vsockmon.c	…
vxlan.c	vxlan: add adjacent link to limit depth level	2019-10-24 14:53:49 -07:00
xen-netfront.c	xen-netfront: do not use ~0U as error return value for xennet_fill_frags()	2019-10-01 21:49:51 -04:00