Charan Teja Kalla 250f71a575 dma-buf: ensure unique directory name for dmabuf stats ... commit 370704e707 upstream. The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/<ino>. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current, failure to create this directory entry can make the dma_buf_export() to fail. Now, as the get_next_ino() can definitely give a repetitive inode no causing the directory entry creation to fail with -EEXIST. This is a problem on the systems where dmabuf stats functionality is enabled on the production builds can make the dma_buf_export(), though the dmabuf memory is allocated successfully, to fail just because it couldn't create stats entry. This issue we are able to see on the snapdragon system within 13 days where there already exists a directory with inode no "122602" so dma_buf_stats_setup() failed with -EEXIST as it is trying to create the same directory entry. To make the dentry name as unique, use the dmabuf fs specific inode which is based on the simple atomic variable increment. There is tmpfs subsystem too which relies on its own inode generation rather than relying on the get_next_ino() for the same reason of avoiding the duplicate inodes[1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=e809d5f0b5c912fe981dce738f3283b2010665f0 Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com> Cc: <stable@vger.kernel.org> # 5.15.x+ Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/1652441296-1986-1-git-send-email-quic_charante@quicinc.com Signed-off-by: Christian König <christian.koenig@amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-05-25 09:57:29 +02:00
..
heaps	dma-buf: cma_heap: Fix mutex locking section	2022-03-08 19:12:37 +01:00
Kconfig	…
Makefile	…
dma-buf-sysfs-stats.c	…
dma-buf-sysfs-stats.h	…
dma-buf.c	dma-buf: ensure unique directory name for dmabuf stats	2022-05-25 09:57:29 +02:00
dma-fence-array.c	…
dma-fence-chain.c	…
dma-fence.c	…
dma-heap.c	…
dma-resv.c	…
selftest.c	…
selftest.h	…
selftests.h	…
seqno-fence.c	…
st-dma-fence-chain.c	…
st-dma-fence.c	…
sw_sync.c	…
sync_debug.c	…
sync_debug.h	…
sync_file.c	…
sync_trace.h	…
udmabuf.c	udmabuf: validate ubuf->pagecount	2022-04-08 14:23:24 +02:00