Tyler Hicks d066fd9d7e eCryptfs: don't pass up plaintext names when using filename encryption ... [ Upstream commit e86281e700 ] Both ecryptfs_filldir() and ecryptfs_readlink_lower() use ecryptfs_decode_and_decrypt_filename() to translate lower filenames to upper filenames. The function correctly passes up lower filenames, unchanged, when filename encryption isn't in use. However, it was also passing up lower filenames when the filename wasn't encrypted or when decryption failed. Since 88ae4ab980, eCryptfs refuses to lookup lower plaintext names when filename encryption is enabled so this resulted in a situation where userspace would see lower plaintext filenames in calls to getdents(2) but then not be able to lookup those filenames. An example of this can be seen when enabling filename encryption on an eCryptfs mount at the root directory of an Ext4 filesystem: $ ls -1i /lower 12 ECRYPTFS_FNEK_ENCRYPTED.FWYZD8TcW.5FV-TKTEYOHsheiHX9a-w.NURCCYIMjI8pn5BDB9-h3fXwrE-- 11 lost+found $ ls -1i /upper ls: cannot access '/upper/lost+found': No such file or directory ? lost+found 12 test With this change, the lower lost+found dentry is ignored: $ ls -1i /lower 12 ECRYPTFS_FNEK_ENCRYPTED.FWYZD8TcW.5FV-TKTEYOHsheiHX9a-w.NURCCYIMjI8pn5BDB9-h3fXwrE-- 11 lost+found $ ls -1i /upper 12 test Additionally, some potentially noisy error/info messages in the related code paths are turned into debug messages so that the logs can't be easily filled. Fixes: 88ae4ab980 ("ecryptfs_lookup(): try either only encrypted or plaintext name") Reported-by: Guenter Roeck <linux@roeck-us.net> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Tyler Hicks <tyhicks@canonical.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-06-21 04:02:42 +09:00
..
Kconfig	Minor code cleanups and new Kconfig option to disable /dev/ecryptfs	2013-03-07 12:47:24 -08:00
Makefile	eCryptfs: allow userspace messaging to be disabled	2013-03-03 23:59:59 -08:00
crypto.c	eCryptfs: don't pass up plaintext names when using filename encryption	2018-06-21 04:02:42 +09:00
debug.c	…
dentry.c	eCryptfs: Invalidate dcache entries when lower i_nlink is zero	2015-08-18 17:29:48 -05:00
ecryptfs_kernel.h	ecryptfs: fix dereference of NULL user_key_payload	2017-10-12 17:16:40 +01:00
file.c	eCryptfs: don't pass up plaintext names when using filename encryption	2018-06-21 04:02:42 +09:00
inode.c	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
keystore.c	ecryptfs: fix dereference of NULL user_key_payload	2017-10-12 17:16:40 +01:00
kthread.c	scripts/spelling.txt: add "againt" pattern and fix typo instances	2017-02-27 18:43:47 -08:00
main.c	VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)	2017-07-17 08:45:34 +01:00
messaging.c	eCryptfs: use after free in ecryptfs_release_messaging()	2017-11-30 08:40:45 +00:00
miscdev.c	ecryptfs: close rmmod race	2013-04-09 14:08:16 -04:00
mmap.c	xattr: Add __vfs_{get,set,remove}xattr helpers	2016-10-07 20:10:44 -04:00
read_write.c	fs: fix kernel_write prototype	2017-09-04 19:05:15 -04:00
super.c	eCryptfs: Do not allocate hash tfm in NORECLAIM context	2016-04-20 17:50:01 +08:00