Larry Chen f83f38fcf1 ocfs2: fix crash in ocfs2_duplicate_clusters_by_page() ... [ Upstream commit 69eb7765b9 ] ocfs2_duplicate_clusters_by_page() may crash if one of the extent's pages is dirty. When a page has not been written back, it is still in dirty state. If ocfs2_duplicate_clusters_by_page() is called against the dirty page, the crash happens. To fix this bug, we can just unlock the page and wait until the page until its not dirty. The following is the backtrace: kernel BUG at /root/code/ocfs2/refcounttree.c:2961! [exception RIP: ocfs2_duplicate_clusters_by_page+822] __ocfs2_move_extent+0x80/0x450 [ocfs2] ? __ocfs2_claim_clusters+0x130/0x250 [ocfs2] ocfs2_defrag_extent+0x5b8/0x5e0 [ocfs2] __ocfs2_move_extents_range+0x2a4/0x470 [ocfs2] ocfs2_move_extents+0x180/0x3b0 [ocfs2] ? ocfs2_wait_for_recovery+0x13/0x70 [ocfs2] ocfs2_ioctl_move_extents+0x133/0x2d0 [ocfs2] ocfs2_ioctl+0x253/0x640 [ocfs2] do_vfs_ioctl+0x90/0x5f0 SyS_ioctl+0x74/0x80 do_syscall_64+0x74/0x140 entry_SYSCALL_64_after_hwframe+0x3d/0xa2 Once we find the page is dirty, we do not wait until it's clean, rather we use write_one_page() to write it back Link: http://lkml.kernel.org/r/20180829074740.9438-1-lchen@suse.com [lchen@suse.com: update comments] Link: http://lkml.kernel.org/r/20180830075041.14879-1-lchen@suse.com [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Larry Chen <lchen@suse.com> Acked-by: Changwei Ge <ge.changwei@h3c.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Joseph Qi <jiangqi903@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2018-11-04 14:52:41 +01:00
..
cluster	ocfs2: subsystem.su_mutex is required while accessing the item->ci_parent	2018-07-22 14:28:42 +02:00
dlm	ocfs2: fix locking for res->tracking and dlm->tracking_list	2018-10-10 08:54:28 +02:00
dlmfs	…
Kconfig	…
Makefile	…
acl.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-04-26 11:02:14 +02:00
acl.h	…
alloc.c	…
alloc.h	…
aops.c	ocfs2: ip_alloc_sem should be taken in ocfs2_get_block()	2018-07-22 14:28:42 +02:00
aops.h	…
blockcheck.c	…
blockcheck.h	…
buffer_head_io.c	ocfs2: fix ocfs2 read block panic	2018-09-29 03:06:05 -07:00
buffer_head_io.h	…
dcache.c	…
dcache.h	…
dir.c	…
dir.h	…
dlmglue.c	…
dlmglue.h	…
export.c	…
export.h	…
extent_map.c	…
extent_map.h	…
file.c	…
file.h	…
filecheck.c	…
filecheck.h	…
heartbeat.c	…
heartbeat.h	…
inode.c	…
inode.h	…
ioctl.c	…
ioctl.h	…
journal.c	ocfs2: return error when we attempt to access a dirty bh in jbd2	2018-04-26 11:02:14 +02:00
journal.h	…
localalloc.c	…
localalloc.h	…
locks.c	…
locks.h	…
mmap.c	…
mmap.h	…
move_extents.c	…
move_extents.h	…
namei.c	…
namei.h	…
ocfs1_fs_compat.h	…
ocfs2.h	…
ocfs2_fs.h	…
ocfs2_ioctl.h	…
ocfs2_lockid.h	…
ocfs2_lockingver.h	…
ocfs2_trace.h	…
quota.h	…
quota_global.c	…
quota_local.c	…
refcounttree.c	ocfs2: fix crash in ocfs2_duplicate_clusters_by_page()	2018-11-04 14:52:41 +01:00
refcounttree.h	…
reservations.c	…
reservations.h	…
resize.c	…
resize.h	…
slot_map.c	…
slot_map.h	…
stack_o2cb.c	…
stack_user.c	…
stackglue.c	…
stackglue.h	…
suballoc.c	…
suballoc.h	…
super.c	…
super.h	…
symlink.c	…
symlink.h	…
sysfile.c	…
sysfile.h	…
uptodate.c	…
uptodate.h	…
xattr.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-04-26 11:02:14 +02:00
xattr.h	…