Xiaolong Huang ff8376ade4 rxrpc: fix some null-ptr-deref bugs in server_key.c ... Some function calls are not implemented in rxrpc_no_security, there are preparse_server_key, free_preparse_server_key and destroy_server_key. When rxrpc security type is rxrpc_no_security, user can easily trigger a null-ptr-deref bug via ioctl. So judgment should be added to prevent it The crash log: user@syzkaller:~$ ./rxrpc_preparse_s [ 37.956878][T15626] BUG: kernel NULL pointer dereference, address: 0000000000000000 [ 37.957645][T15626] #PF: supervisor instruction fetch in kernel mode [ 37.958229][T15626] #PF: error_code(0x0010) - not-present page [ 37.958762][T15626] PGD 4aadf067 P4D 4aadf067 PUD 4aade067 PMD 0 [ 37.959321][T15626] Oops: 0010 [#1] PREEMPT SMP [ 37.959739][T15626] CPU: 0 PID: 15626 Comm: rxrpc_preparse_ Not tainted 5.17.0-01442-gb47d5a4f6b8d #43 [ 37.960588][T15626] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014 [ 37.961474][T15626] RIP: 0010:0x0 [ 37.961787][T15626] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. [ 37.962480][T15626] RSP: 0018:ffffc9000d9abdc0 EFLAGS: 00010286 [ 37.963018][T15626] RAX: ffffffff84335200 RBX: ffff888012a1ce80 RCX: 0000000000000000 [ 37.963727][T15626] RDX: 0000000000000000 RSI: ffffffff84a736dc RDI: ffffc9000d9abe48 [ 37.964425][T15626] RBP: ffffc9000d9abe48 R08: 0000000000000000 R09: 0000000000000002 [ 37.965118][T15626] R10: 000000000000000a R11: f000000000000000 R12: ffff888013145680 [ 37.965836][T15626] R13: 0000000000000000 R14: ffffffffffffffec R15: ffff8880432aba80 [ 37.966441][T15626] FS: 00007f2177907700(0000) GS:ffff88803ec00000(0000) knlGS:0000000000000000 [ 37.966979][T15626] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 37.967384][T15626] CR2: ffffffffffffffd6 CR3: 000000004aaf1000 CR4: 00000000000006f0 [ 37.967864][T15626] Call Trace: [ 37.968062][T15626] <TASK> [ 37.968240][T15626] rxrpc_preparse_s+0x59/0x90 [ 37.968541][T15626] key_create_or_update+0x174/0x510 [ 37.968863][T15626] __x64_sys_add_key+0x139/0x1d0 [ 37.969165][T15626] do_syscall_64+0x35/0xb0 [ 37.969451][T15626] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 37.969824][T15626] RIP: 0033:0x43a1f9 Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com> Tested-by: Xiaolong Huang <butterflyhuangxx@gmail.com> Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Marc Dionne <marc.dionne@auristor.com> cc: linux-afs@lists.infradead.org Link: http://lists.infradead.org/pipermail/linux-afs/2022-March/005069.html Fixes: 12da59fcab ("rxrpc: Hand server key parsing off to the security class") Link: https://lore.kernel.org/r/164865013439.2941502.8966285221215590921.stgit@warthog.procyon.org.uk Signed-off-by: Paolo Abeni <pabeni@redhat.com>		2022-03-31 15:21:31 +02:00
..
Kconfig	net: RxRPC: make dependent Kconfig symbols be shown indented	2021-08-18 10:12:11 +01:00
Makefile	rxrpc: Split the server key type (rxrpc_s) into its own file	2020-11-23 18:09:29 +00:00
af_rxrpc.c	rxrpc: Fix fall-through warnings for Clang	2021-06-04 17:40:04 -05:00
ar-internal.h	rxrpc: Fix call timer start racing with call destruction	2022-03-31 12:25:25 +02:00
call_accept.c	rxrpc: Fix memory leak in rxrpc_lookup_local	2021-01-28 13:12:14 -08:00
call_event.c	rxrpc: Fix call timer start racing with call destruction	2022-03-31 12:25:25 +02:00
call_object.c	rxrpc: Fix call timer start racing with call destruction	2022-03-31 12:25:25 +02:00
conn_client.c	rxrpc: Fix rxrpc_peer leak in rxrpc_look_up_bundle()	2021-11-29 15:39:40 +00:00
conn_event.c	rxrpc: Merge prime_packet_security into init_connection_security	2020-11-23 18:09:30 +00:00
conn_object.c	rxrpc: Ask the security class how much space to allow in a packet	2020-11-23 19:53:11 +00:00
conn_service.c	rxrpc: Don't retain the server key in the connection	2020-11-23 18:09:29 +00:00
input.c	rxrpc: Call state should be read with READ_ONCE() under some circumstances	2021-01-13 10:38:20 -08:00
insecure.c	rxrpc: Ask the security class how much space to allow in a packet	2020-11-23 19:53:11 +00:00
key.c	rxrpc: Fix handling of an unsupported token type in rxrpc_read()	2021-01-13 10:38:00 -08:00
local_event.c	rxrpc: Fix a typo	2021-06-02 14:01:55 -07:00
local_object.c	rxrpc: Fix dependency on IPv6 in udp tunnel config	2021-02-12 16:42:05 -08:00
misc.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-11 16:42:28 +01:00
net_ns.c	rxrpc: Rewrite the client connection manager	2020-09-08 21:11:43 +01:00
output.c	rxrpc: Adjust retransmission backoff	2022-01-22 02:03:24 +00:00
peer_event.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
peer_object.c	rxrpc: Fix rxrpc_local leak in rxrpc_lookup_peer()	2021-11-29 15:40:02 +00:00
proc.c	rxrpc: Rewrite the client connection manager	2020-09-08 21:11:43 +01:00
protocol.h	rxrpc: Improve jumbo packet counting	2019-08-27 09:48:37 +01:00
recvmsg.c	afs: Don't truncate iter during data fetch	2021-04-23 10:17:26 +01:00
rtt.c	rxrpc: Fix _usecs_to_jiffies() by using usecs_to_jiffies()	2021-09-24 14:18:34 +01:00
rxkad.c	rxrpc: rxkad: Remove redundant variable offset	2021-04-27 14:05:06 -07:00
security.c	rxrpc: Hand server key parsing off to the security class	2020-11-23 18:09:29 +00:00
sendmsg.c	rxrpc: Ask the security class how much space to allow in a packet	2020-11-23 19:53:11 +00:00
server_key.c	rxrpc: fix some null-ptr-deref bugs in server_key.c	2022-03-31 15:21:31 +02:00
skbuff.c	rxrpc: Use skb_unshare() rather than skb_cow_data()	2019-08-27 10:13:46 +01:00
sysctl.c	rxrpc: Rewrite the client connection manager	2020-09-08 21:11:43 +01:00
utils.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36	2019-05-24 17:27:11 +02:00