Miklos Szeredi 21f621741a fuse: fix LOOKUP vs INIT compat handling ... Analysis from Marc: "Commit 7078187a79 ("fuse: introduce fuse_simple_request() helper") from the above pull request triggers some EIO errors for me in some tests that rely on fuse Looking at the code changes and a bit of debugging info I think there's a general problem here that fuse_get_req checks and possibly waits for fc->initialized, and this was always called first. But this commit changes the ordering and in many places fc->minor is now possibly used before fuse_get_req, and we can't be sure that fc has been initialized. In my case fuse_lookup_init sets req->out.args[0].size to the wrong size because fc->minor at that point is still 0, leading to the EIO error." Fix by moving the compat adjustments into fuse_simple_request() to after fuse_get_req(). This is also more readable than the original, since now compatibility is handled in a single function instead of cluttering each operation. Reported-by: Marc Dionne <marc.c.dionne@gmail.com> Tested-by: Marc Dionne <marc.c.dionne@gmail.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Fixes: 7078187a79 ("fuse: introduce fuse_simple_request() helper")		2015-01-06 10:45:35 +01:00
..
Kconfig	fuse: Move CUSE Kconfig entry from fs/Kconfig into fs/fuse/Kconfig	2013-01-17 13:08:45 +01:00
Makefile	…
control.c	fuse: add __exit to fuse_ctl_cleanup	2014-04-28 14:19:21 +02:00
cuse.c	fuse: flush requests on umount	2014-12-12 09:49:04 +01:00
dev.c	fuse: fix LOOKUP vs INIT compat handling	2015-01-06 10:45:35 +01:00
dir.c	fuse: fix LOOKUP vs INIT compat handling	2015-01-06 10:45:35 +01:00
file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse	2014-12-17 09:41:32 -08:00
fuse_i.h	fuse: introduce fuse_simple_request() helper	2014-12-12 09:49:05 +01:00
inode.c	fuse: fix LOOKUP vs INIT compat handling	2015-01-06 10:45:35 +01:00