Scott Mayhew 268b2cc325 nfs: don't wait on commit in nfs_commit_inode() if there were no commit requests ... commit dc4fd9ab01 upstream. If there were no commit requests, then nfs_commit_inode() should not wait on the commit or mark the inode dirty, otherwise the following BUG_ON can be triggered: [ 1917.130762] kernel BUG at fs/inode.c:578! [ 1917.130766] Oops: Exception in kernel mode, sig: 5 [#1] [ 1917.130768] SMP NR_CPUS=2048 NUMA pSeries [ 1917.130772] Modules linked in: iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi blocklayoutdriver rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache sunrpc sg nx_crypto pseries_rng ip_tables xfs libcrc32c sd_mod crc_t10dif crct10dif_generic crct10dif_common ibmvscsi scsi_transport_srp ibmveth scsi_tgt dm_mirror dm_region_hash dm_log dm_mod [ 1917.130805] CPU: 2 PID: 14923 Comm: umount.nfs4 Tainted: G ------------ T 3.10.0-768.el7.ppc64 #1 [ 1917.130810] task: c0000005ecd88040 ti: c00000004cea0000 task.ti: c00000004cea0000 [ 1917.130813] NIP: c000000000354178 LR: c000000000354160 CTR: c00000000012db80 [ 1917.130816] REGS: c00000004cea3720 TRAP: 0700 Tainted: G ------------ T (3.10.0-768.el7.ppc64) [ 1917.130820] MSR: 8000000100029032 <SF,EE,ME,IR,DR,RI> CR: 22002822 XER: 20000000 [ 1917.130828] CFAR: c00000000011f594 SOFTE: 1 GPR00: c000000000354160 c00000004cea39a0 c0000000014c4700 c0000000018cc750 GPR04: 000000000000c750 80c0000000000000 0600000000000000 04eeb76bea749a03 GPR08: 0000000000000034 c0000000018cc758 0000000000000001 d000000005e619e8 GPR12: c00000000012db80 c000000007b31200 0000000000000000 0000000000000000 GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR24: 0000000000000000 c000000000dfc3ec 0000000000000000 c0000005eefc02c0 GPR28: d0000000079dbd50 c0000005b94a02c0 c0000005b94a0250 c0000005b94a01c8 [ 1917.130867] NIP [c000000000354178] .evict+0x1c8/0x350 [ 1917.130871] LR [c000000000354160] .evict+0x1b0/0x350 [ 1917.130873] Call Trace: [ 1917.130876] [c00000004cea39a0] [c000000000354160] .evict+0x1b0/0x350 (unreliable) [ 1917.130880] [c00000004cea3a30] [c0000000003558cc] .evict_inodes+0x13c/0x270 [ 1917.130884] [c00000004cea3af0] [c000000000327d20] .kill_anon_super+0x70/0x1e0 [ 1917.130896] [c00000004cea3b80] [d000000005e43e30] .nfs_kill_super+0x20/0x60 [nfs] [ 1917.130900] [c00000004cea3c00] [c000000000328a20] .deactivate_locked_super+0xa0/0x1b0 [ 1917.130903] [c00000004cea3c80] [c00000000035ba54] .cleanup_mnt+0xd4/0x180 [ 1917.130907] [c00000004cea3d10] [c000000000119034] .task_work_run+0x114/0x150 [ 1917.130912] [c00000004cea3db0] [c00000000001ba6c] .do_notify_resume+0xcc/0x100 [ 1917.130916] [c00000004cea3e30] [c00000000000a7b0] .ret_from_except_lite+0x5c/0x60 [ 1917.130919] Instruction dump: [ 1917.130921] 7fc3f378 486734b5 60000000 387f00a0 38800003 4bdcb365 60000000 e95f00a0 [ 1917.130927] 694a0060 7d4a0074 794ad182 694a0001 <0b0a0000> 892d02a4 2f890000 40de0134 Signed-off-by: Scott Mayhew <smayhew@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-12-20 10:10:20 +01:00
..
9p	fs/9p: Compare qid.path in v9fs_test_inode	2017-11-30 08:40:49 +00:00
adfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
affs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
afs	afs: Connect up the CB.ProbeUuid	2017-12-14 09:53:15 +01:00
autofs4	autofs: fix careless error in recent commit	2017-12-20 10:10:17 +01:00
befs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
btrfs	btrfs: handle errors while updating refcounts in update_ref_for_cow	2017-12-14 09:52:54 +01:00
cachefiles	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ceph	ceph: drop negative child dentries before try pruning inode's alias	2017-12-20 10:10:19 +01:00
cifs	cifs: fix NULL deref in SMB2_read	2017-12-20 10:10:17 +01:00
coda	coda: fix 'kernel memory exposure attempt' in fsync	2017-11-24 08:37:05 +01:00
configfs	configfs: Introduce config_item_get_unless_zero()	2017-06-12 13:20:20 +02:00
cramfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
crypto	fscrypt: lock mutex before checking for bounce page pool	2017-11-30 08:40:44 +00:00
debugfs	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-07-15 12:00:42 -07:00
devpts	pty: Repair TIOCGPTPEER	2017-08-24 13:23:03 -07:00
dlm	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ecryptfs	eCryptfs: use after free in ecryptfs_release_messaging()	2017-11-30 08:40:45 +00:00
efivarfs	VFS: Kill off s_options and helpers	2017-07-11 06:09:21 -04:00
efs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
exofs	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
exportfs	…
ext2	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ext4	ext4: prevent data corruption with journaling + DAX	2017-11-30 08:40:48 +00:00
f2fs	f2fs: fix to clear FI_NO_PREALLOC	2017-12-14 09:53:14 +01:00
fat	fs/fat/inode.c: fix sb_rdonly() change	2017-12-05 11:26:29 +01:00
freevxfs	…
fscache	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fuse	fuse: fix READDIRPLUS skipping an entry	2017-10-25 16:34:27 +02:00
gfs2	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hfsplus	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hostfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hpfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hugetlbfs	fs/hugetlbfs/inode.c: fix hwpoison reserve accounting	2017-11-03 07:39:19 -07:00
isofs	isofs: fix timestamps beyond 2027	2017-11-30 08:40:45 +00:00
jbd2	Writeback error handling fixes (pile #2)	2017-07-07 19:38:17 -07:00
jffs2	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
jfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
kernfs	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
lockd	lockd: lost rollback of set_grace_period() in lockd_down_net()	2017-12-05 11:26:30 +01:00
minix	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ncpfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs	nfs: don't wait on commit in nfs_commit_inode() if there were no commit requests	2017-12-20 10:10:20 +01:00
nfs_common	…
nfsd	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-20 10:10:18 +01:00
nilfs2	nilfs2: fix race condition that causes file system corruption	2017-11-30 08:40:44 +00:00
nls	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
notify	fsnotify: fix pinning group in fsnotify_prepare_user_wait()	2017-11-30 08:40:47 +00:00
ntfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ocfs2	ocfs2: should wait dio before inode lock in ocfs2_setattr()	2017-11-24 08:37:04 +01:00
omfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
openpromfs	…
orangefs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
overlayfs	ovl: update ctx->pos on impure dir iteration	2017-12-20 10:10:18 +01:00
proc	mm, /proc/pid/pagemap: fix soft dirty marking for PMD migration entry	2017-11-03 07:39:19 -07:00
pstore	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qnx4	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qnx6	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ramfs	mm: make pagevec_lookup() update index	2017-09-06 17:27:26 -07:00
reiserfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
romfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
squashfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sysfs	…
sysv	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tracefs	VFS: Don't use save/replace_mount_options if not using generic_show_options	2017-07-06 03:31:46 -04:00
ubifs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
udf	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ufs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs	xfs: fix forgotten rcu read unlock when skipping inode reclaim	2017-12-14 09:53:09 +01:00
Kconfig	fs/Kconfig: kill CONFIG_PERCPU_RWSEM some more	2017-07-12 16:26:00 -07:00
Kconfig.binfmt	…
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
aio.c	Merge branch 'work.read_write' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 19:29:55 -07:00
anon_inodes.c	…
attr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bad_inode.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_aout.c	fs: fix kernel_read prototype	2017-09-04 19:05:15 -04:00
binfmt_elf.c	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
binfmt_elf_fdpic.c	Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-09-14 18:13:32 -07:00
binfmt_em86.c	…
binfmt_flat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_misc.c	fs/binfmt_misc.c: node could be NULL when evicting inode	2017-10-13 16:18:33 -07:00
binfmt_script.c	exec: load_script: kill the onstack interp[BINPRM_BUF_SIZE] array	2017-10-03 17:54:25 -07:00
block_dev.c	fs/mpage.c: fix mpage_writepage() for pages with buffers	2017-10-13 16:18:33 -07:00
buffer.c	fs: guard_bio_eod() needs to consider partitions	2017-11-30 08:40:45 +00:00
char_dev.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c	…
compat_binfmt_elf.c	…
compat_ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
coredump.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dax.c	dax: fix PMD faults on zero-length files	2017-11-30 08:40:53 +00:00
dcache.c	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-07-15 12:00:42 -07:00
dcookies.c	…
direct-io.c	Changes since last update:	2017-10-18 14:51:50 -04:00
drop_caches.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
eventfd.c	There has been a fair amount of activity in the docs tree this time	2017-07-03 21:13:25 -07:00
eventpoll.c	fs/epoll: use faster rb_first_cached()	2017-09-08 18:26:49 -07:00
exec.c	exec: avoid RLIMIT_STACK races with prlimit()	2017-12-05 11:26:29 +01:00
fcntl.c	fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall	2017-12-17 15:07:59 +01:00
fhandle.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file_table.c	fput: Don't reinvent the wheel but use existing llist API	2017-08-28 00:50:23 -04:00
filesystems.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs-writeback.c	writeback: rework wb_[dec|inc]_stat family of functions	2017-07-12 16:26:05 -07:00
fs_pin.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs_struct.c	…
inode.c	Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs	2017-09-13 09:11:44 -07:00
internal.h	Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs	2017-09-13 09:11:44 -07:00
ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iomap.c	fs: invalidate page cache after end_io() in dio completion	2017-10-16 12:11:56 -07:00
libfs.c	fs: convert __generic_file_fsync to use errseq_t based reporting	2017-07-06 07:02:29 -04:00
locks.c	locks: restore a warn for leaked locks on close	2017-07-21 13:57:31 -04:00
mbcache.c	ext4: xattr inode deduplication	2017-06-22 11:44:55 -04:00
mount.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mpage.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namei.c	autofs: revert "autofs: fix AT_NO_AUTOMOUNT not being honored"	2017-12-05 11:26:29 +01:00
namespace.c	vfs: fix mounting a filesystem with i_version	2017-10-17 02:22:07 -04:00
no-block.c	…
nsfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
open.c	ovl: don't allow writing ioctl on lower layer	2017-09-05 12:53:12 +02:00
pipe.c	pipe: match pipe_max_size data type with procfs	2017-12-14 09:53:08 +01:00
pnode.c	mnt: Make propagate_umount less slow for overlapping mount propagation trees	2017-05-23 08:41:17 -05:00
pnode.h	…
posix_acl.c	…
proc_namespace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
read_write.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
readdir.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
select.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
seq_file.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
signalfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
splice.c	fs: move kernel_write to fs/read_write.c	2017-09-04 19:05:15 -04:00
stack.c	…
stat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
statfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
super.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sync.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
timerfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
userfaultfd.c	userfaultfd: non-cooperative: fix fork use after free	2017-10-03 17:54:25 -07:00
utimes.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr.c	lsm: fix smack_inode_removexattr and xattr_getsecurity memleak	2017-10-04 18:03:15 +11:00