Jakub Kicinski 38b4f18d56 net: sched: gred: pass the right attribute to gred_change_table_def() ... gred_change_table_def() takes a pointer to TCA_GRED_DPS attribute, and expects it will be able to interpret its contents as struct tc_gred_sopt. Pass the correct gred attribute, instead of TCA_OPTIONS. This bug meant the table definition could never be changed after Qdisc was initialized (unless whatever TCA_OPTIONS contained both passed netlink validation and was a valid struct tc_gred_sopt...). Old behaviour: $ ip link add type dummy $ tc qdisc replace dev dummy0 parent root handle 7: \ gred setup vqs 4 default 0 $ tc qdisc replace dev dummy0 parent root handle 7: \ gred setup vqs 4 default 0 RTNETLINK answers: Invalid argument Now: $ ip link add type dummy $ tc qdisc replace dev dummy0 parent root handle 7: \ gred setup vqs 4 default 0 $ tc qdisc replace dev dummy0 parent root handle 7: \ gred setup vqs 4 default 0 $ tc qdisc replace dev dummy0 parent root handle 7: \ gred setup vqs 4 default 0 Fixes: f62d6b936d ("[PKT_SCHED]: GRED: Use central VQ change procedure") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-10-28 19:23:26 -07:00
..
Kconfig	tc: Add support for configuring the taprio scheduler	2018-10-04 13:52:23 -07:00
Makefile	tc: Add support for configuring the taprio scheduler	2018-10-04 13:52:23 -07:00
act_api.c	net: Add extack to nlmsg_parse	2018-10-08 10:39:04 -07:00
act_bpf.c	Revert "net: sched: act: add extack for lookup callback"	2018-08-31 22:50:15 -07:00
act_connmark.c	net_sched: add missing tcf_lock for act_connmark	2018-08-31 22:57:43 -07:00
act_csum.c	Revert "net: sched: act: add extack for lookup callback"	2018-08-31 22:50:15 -07:00
act_gact.c	net/sched: act_gact: disallow 'goto chain' on fallback control action	2018-10-22 19:40:55 -07:00
act_ife.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-09-04 21:33:03 -07:00
act_ipt.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-03 21:00:17 -07:00
act_meta_mark.c	…
act_meta_skbprio.c	…
act_meta_skbtcindex.c	…
act_mirred.c	net/sched: Add hardware specific counters to TC actions	2018-09-24 12:18:42 -07:00
act_nat.c	net: sched: act_nat: remove dependency on rtnl lock	2018-09-08 10:18:25 -07:00
act_pedit.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-09-04 21:33:03 -07:00
act_police.c	net/sched: act_police: disallow 'goto chain' on fallback control action	2018-10-22 19:42:50 -07:00
act_sample.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-09-18 09:33:27 -07:00
act_simple.c	Revert "net: sched: act: add extack for lookup callback"	2018-08-31 22:50:15 -07:00
act_skbedit.c	net: sched: act_skbedit: remove dependency on rtnl lock	2018-09-08 10:17:35 -07:00
act_skbmod.c	Revert "net: sched: act: add extack for lookup callback"	2018-08-31 22:50:15 -07:00
act_tunnel_key.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-09-12 22:22:42 -07:00
act_vlan.c	Revert "net: sched: act: add extack for lookup callback"	2018-08-31 22:50:15 -07:00
cls_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-19 11:03:06 -07:00
cls_basic.c	sched: fix trailing whitespace	2018-07-24 14:10:42 -07:00
cls_bpf.c	cls_bpf: Use kmemdup instead of duplicating it in cls_bpf_prog_from_ops	2018-07-29 13:19:49 -07:00
cls_cgroup.c	…
cls_flow.c	…
cls_flower.c	net_sched: convert idrinfo->lock from spinlock to a mutex	2018-10-05 00:36:31 -07:00
cls_fw.c	…
cls_matchall.c	cls_matchall: fix tcf_unbind_filter missing	2018-08-16 12:08:26 -07:00
cls_route.c	…
cls_rsvp.c	…
cls_rsvp.h	…
cls_rsvp6.c	…
cls_tcindex.c	net_sched: Fix missing res info when create new tc_index filter	2018-08-13 19:37:42 -07:00
cls_u32.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
em_canid.c	…
em_cmp.c	…
em_ipset.c	…
em_ipt.c	…
em_meta.c	…
em_nbyte.c	…
em_text.c	…
em_u32.c	…
ematch.c	…
sch_api.c	net: sched: Remove TCA_OPTIONS from policy	2018-10-24 14:35:09 -07:00
sch_atm.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_blackhole.c	…
sch_cake.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-12 21:38:46 -07:00
sch_cbq.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_cbs.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_choke.c	…
sch_codel.c	…
sch_drr.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_dsmark.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_etf.c	…
sch_fifo.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_fq.c	net_sched: sch_fq: no longer use skb_is_tcp_pure_ack()	2018-10-15 22:56:42 -07:00
sch_fq_codel.c	net: Add and use skb_mark_not_on_list().	2018-09-10 10:06:54 -07:00
sch_generic.c	net: sched: avoid writing on noop_qdisc	2018-10-10 22:49:16 -07:00
sch_gred.c	net: sched: gred: pass the right attribute to gred_change_table_def()	2018-10-28 19:23:26 -07:00
sch_hfsc.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_hhf.c	net: Add and use skb_mark_not_on_list().	2018-09-10 10:06:54 -07:00
sch_htb.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_ingress.c	…
sch_mq.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_mqprio.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_multiq.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_netem.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_pie.c	net: sched: pie: fix coding style issues	2018-10-07 20:39:01 -07:00
sch_plug.c	…
sch_prio.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_qfq.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_red.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_sfb.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_sfq.c	…
sch_skbprio.c	net/sched: add skbprio scheduler	2018-07-24 14:44:00 -07:00
sch_taprio.c	tc: Add support for configuring the taprio scheduler	2018-10-04 13:52:23 -07:00
sch_tbf.c	net: sched: rename qdisc_destroy() to qdisc_put()	2018-09-25 20:17:35 -07:00
sch_teql.c	…