Mel Gorman 8008293888 mm: vmscan: reduce throttling due to a failure to make progress -fix ... Hugh Dickins reported the following My tmpfs swapping load (tweaked to use huge pages more heavily than in real life) is far from being a realistic load: but it was notably slowed down by your throttling mods in 5.16-rc, and this patch makes it well again - thanks. But: it very quickly hit NULL pointer until I changed that last line to if (first_pgdat) consider_reclaim_throttle(first_pgdat, sc); The likely issue is that huge pages are a major component of the test workload. When this is the case, first_pgdat may never get set if compaction is ready to continue due to this check if (IS_ENABLED(CONFIG_COMPACTION) && sc->order > PAGE_ALLOC_COSTLY_ORDER && compaction_ready(zone, sc)) { sc->compaction_ready = true; continue; } If this was true for every zone in the zonelist, first_pgdat would never get set resulting in a NULL pointer exception. Link: https://lkml.kernel.org/r/20211209095453.GM3366@techsingularity.net Fixes: 1b4e3f26f9 ("mm: vmscan: Reduce throttling due to a failure to make progress") Signed-off-by: Mel Gorman <mgorman@techsingularity.net> Reported-by: Hugh Dickins <hughd@google.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Rik van Riel <riel@surriel.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Darrick J. Wong <djwong@kernel.org> Cc: Shakeel Butt <shakeelb@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2021-12-31 13:12:55 -08:00
..
damon	mm/damon/dbgfs: fix 'struct pid' leaks in 'dbgfs_target_ids_write()'	2021-12-31 09:20:12 -08:00
kasan	kasan: add kasan mode messages when kasan init	2021-11-11 09:34:35 -08:00
kfence	kfence: fix memory leak when cat kfence objects	2021-12-25 12:20:55 -08:00
Kconfig	percpu: km: ensure it is used with NOMMU (either UP or SMP)	2021-12-06 12:45:09 -05:00
Kconfig.debug	…
Makefile	mm/util: Add folio_mapping() and folio_file_mapping()	2021-09-27 09:27:30 -04:00
backing-dev.c	mm: bdi: initialize bdi_min_ratio when bdi is unregistered	2021-12-10 17:10:56 -08:00
balloon_compaction.c	…
bootmem_info.c	mm/bootmem_info.c: mark __init on register_page_bootmem_info_section	2021-09-03 09:58:14 -07:00
cleancache.c	…
cma.c	memblock: rename memblock_free to memblock_phys_free	2021-11-06 13:30:41 -07:00
cma.h	…
cma_debug.c	…
cma_sysfs.c	…
compaction.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
debug.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
debug_page_ref.c	…
debug_vm_pgtable.c	mm: debug_vm_pgtable: don't use __P000 directly	2021-11-06 13:30:33 -07:00
dmapool.c	…
early_ioremap.c	mm/early_ioremap.c: remove redundant early_ioremap_shutdown()	2021-09-08 11:50:24 -07:00
fadvise.c	…
failslab.c	…
filemap.c	filemap: remove PageHWPoison check from next_uptodate_page()	2021-12-10 17:10:55 -08:00
folio-compat.c	mm/filemap: Add FGP_STABLE	2021-10-18 07:49:41 -04:00
frontswap.c	…
gup.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
gup_test.c	…
gup_test.h	…
highmem.c	Fixes for 5.16 folios:	2021-11-25 10:13:56 -08:00
hmm.c	mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled	2021-09-08 18:45:52 -07:00
huge_memory.c	Memory folios	2021-11-01 08:47:59 -07:00
hugetlb.c	hugetlbfs: fix issue of preallocation of gigantic pages can't work	2021-12-10 17:10:56 -08:00
hugetlb_cgroup.c	hugetlb_cgroup: remove unused hugetlb_cgroup_from_counter macro	2021-11-06 13:30:39 -07:00
hugetlb_vmemmap.c	mm: hugetlb: introduce CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON	2021-06-30 20:47:26 -07:00
hugetlb_vmemmap.h	mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate	2021-06-30 20:47:25 -07:00
hwpoison-inject.c	mm: hwpoison: don't drop slab caches for offlining non-LRU page	2021-09-03 09:58:15 -07:00
init-mm.c	mm: add setup_initial_init_mm() helper	2021-07-08 11:48:21 -07:00
internal.h	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
interval_tree.c	…
io-mapping.c	…
ioremap.c	mm: move ioremap_page_range to vmalloc.c	2021-09-08 11:50:24 -07:00
khugepaged.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
kmemleak.c	mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's gfp	2021-09-08 18:45:53 -07:00
ksm.c	mm/migrate: Add folio_migrate_flags()	2021-10-18 07:49:39 -04:00
list_lru.c	mm: list_lru: only add memcg-aware lrus to the global lru list	2021-11-06 13:30:35 -07:00
maccess.c	ARM: 9115/1: mm/maccess: fix unaligned copy_{from,to}_kernel_nofault	2021-08-20 11:39:25 +01:00
madvise.c	mm: use pidfd_get_task()	2021-10-14 13:29:22 +02:00
mapping_dirty_helpers.c	mm/mapping_dirty_helpers: remove double Note in kerneldoc	2021-07-01 11:06:02 -07:00
memblock.c	arm64 fixes for -rc1	2021-11-10 11:29:30 -08:00
memcontrol.c	mm/memcg: relocate mod_objcg_mlstate(), get_obj_stock() and put_obj_stock()	2021-12-10 17:10:56 -08:00
memfd.c	mm,hugetlb: remove mlock ulimit for SHM_HUGETLB	2021-11-09 10:02:48 -08:00
memory-failure.c	mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page()	2021-12-25 12:20:56 -08:00
memory.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
memory_hotplug.c	treewide: Add missing includes masked by cgroup -> bpf dependency	2021-12-03 10:58:13 -08:00
mempolicy.c	mm: mempolicy: fix THP allocations escaping mempolicy restrictions	2021-12-25 12:20:55 -08:00
mempool.c	mm: remove spurious blkdev.h includes	2021-10-18 06:17:01 -06:00
memremap.c	mm/memcg: Convert mem_cgroup_uncharge() to take a folio	2021-09-27 09:27:31 -04:00
memtest.c	…
migrate.c	mm/migrate.c: remove MIGRATE_PFN_LOCKED	2021-11-11 09:34:35 -08:00
mincore.c	…
mlock.c	mm/memcg: Add folio_lruvec_relock_irq() and folio_lruvec_relock_irqsave()	2021-09-27 09:27:31 -04:00
mm_init.c	…
mmap.c	mm,hugetlb: remove mlock ulimit for SHM_HUGETLB	2021-11-09 10:02:48 -08:00
mmap_lock.c	mm: mmap_lock: fix disabling preemption directly	2021-07-23 17:43:28 -07:00
mmu_gather.c	…
mmu_notifier.c	…
mmzone.c	…
mprotect.c	mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey()	2021-11-06 13:30:36 -07:00
mremap.c	mm, hugepages: add mremap() support for hugepage backed vma	2021-11-06 13:30:39 -07:00
msync.c	…
nommu.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
oom_kill.c	pidfd.v5.16	2021-11-10 16:02:08 -08:00
page-writeback.c	folio: Add a function to get the host inode for a folio	2021-11-10 21:16:52 +00:00
page_alloc.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
page_counter.c	…
page_ext.c	mm/page_ext.c: fix a comment	2021-11-06 13:30:34 -07:00
page_idle.c	mm/idle_page_tracking: make PG_idle reusable	2021-09-08 11:50:24 -07:00
page_io.c	for-5.16/block-2021-10-29	2021-11-01 09:19:50 -07:00
page_isolation.c	mm/page_isolation: guard against possible putback unisolated page	2021-11-06 13:30:40 -07:00
page_owner.c	mm/page_owner.c: modify the type of argument "order" in some functions	2021-11-11 09:34:35 -08:00
page_poison.c	…
page_reporting.c	…
page_reporting.h	…
page_vma_mapped.c	mm: device exclusive memory access	2021-07-01 11:06:03 -07:00
pagewalk.c	…
percpu-internal.h	Merge branch 'for-5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu	2021-07-01 17:17:24 -07:00
percpu-km.c	percpu: flush tlb in pcpu_reclaim_populated()	2021-07-04 18:30:17 +00:00
percpu-stats.c	…
percpu-vm.c	percpu: flush tlb in pcpu_reclaim_populated()	2021-07-04 18:30:17 +00:00
percpu.c	memblock: use memblock_free for freeing virtual pointers	2021-11-06 13:30:41 -07:00
pgalloc-track.h	…
pgtable-generic.c	…
process_vm_access.c	…
ptdump.c	…
readahead.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
rmap.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
rodata_test.c	…
secretmem.c	mm/secretmem: avoid letting secretmem_users drop to zero	2021-10-28 17:18:55 -07:00
shmem.c	fs: Remove FS_THP_SUPPORT	2021-11-17 10:36:35 -05:00
shuffle.c	…
shuffle.h	…
slab.c	mm: emit the "free" trace report before freeing memory in kmem_cache_free()	2021-11-20 10:35:54 -08:00
slab.h	mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag	2021-11-20 10:35:54 -08:00
slab_common.c	mm: remove HARDENED_USERCOPY_FALLBACK	2021-11-06 13:30:43 -07:00
slob.c	mm: emit the "free" trace report before freeing memory in kmem_cache_free()	2021-11-20 10:35:54 -08:00
slub.c	mm/slub: fix endianness bug for alloc/free_traces attributes	2021-12-10 17:10:56 -08:00
sparse-vmemmap.c	mm: remove redundant smp_wmb()	2021-11-06 13:30:36 -07:00
sparse.c	memblock: use memblock_free for freeing virtual pointers	2021-11-06 13:30:41 -07:00
swap.c	mm/swap.c:put_pages_list(): reinitialise the page list	2021-11-20 10:35:54 -08:00
swap_cgroup.c	…
swap_slots.c	treewide: Add missing includes masked by cgroup -> bpf dependency	2021-12-03 10:58:13 -08:00
swap_state.c	mm/workingset: Convert workingset_refault() to take a folio	2021-10-18 07:49:40 -04:00
swapfile.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
truncate.c	vfs: keep inodes with page cache off the inode shrinker LRU	2021-11-09 10:02:48 -08:00
usercopy.c	…
userfaultfd.c	Revert "mm: shmem: don't truncate page if memory failure happens"	2021-11-13 12:03:03 -08:00
util.c	mm: Remove folio_test_single	2021-11-17 10:36:35 -05:00
vmacache.c	…
vmalloc.c	mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation	2021-11-06 13:30:37 -07:00
vmpressure.c	mm/vmpressure: fix data-race with memcg->socket_pressure	2021-11-06 13:30:40 -07:00
vmscan.c	mm: vmscan: reduce throttling due to a failure to make progress -fix	2021-12-31 13:12:55 -08:00
vmstat.c	mm: vmstat.c: make extfrag_index show more pretty	2021-11-06 13:30:42 -07:00
workingset.c	Merge branch 'akpm' (patches from Andrew)	2021-11-09 10:11:53 -08:00
z3fold.c	mm/z3fold: add kerneldoc fields for z3fold_pool	2021-07-01 11:06:03 -07:00
zbud.c	mm/zbud: add kerneldoc fields for zbud_pool	2021-07-01 11:06:03 -07:00
zpool.c	…
zsmalloc.c	mm/zsmalloc.c: close race window between zs_pool_dec_isolated() and zs_unregister_migration()	2021-11-06 13:30:43 -07:00
zswap.c	mm/zswap.c: fix two bugs in zswap_writeback_entry()	2021-06-30 20:47:31 -07:00