Randy Dunlap f64c5b235b printk: fix return value of printk.devkmsg __setup handler ... [ Upstream commit b665eae7a7 ] If an invalid option value is used with "printk.devkmsg=<value>", it is silently ignored. If a valid option value is used, it is honored but the wrong return value (0) is used, indicating that the command line option had an error and was not handled. This string is not added to init's environment strings due to init/main.c::unknown_bootoption() checking for a '.' in the boot option string and then considering that string to be an "Unused module parameter". Print a warning message if a bad option string is used. Always return 1 from the __setup handler to indicate that the command line option has been handled. Fixes: 750afe7bab ("printk: add kernel parameter to control writes to /dev/kmsg") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: Borislav Petkov <bp@suse.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: John Ogness <john.ogness@linutronix.de> Reviewed-by: John Ogness <john.ogness@linutronix.de> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> Reviewed-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20220228220556.23484-1-rdunlap@infradead.org Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-08 14:23:19 +02:00
..
Makefile	printk: Userspace format indexing support	2021-07-19 11:57:48 +02:00
braille.c	printk: Replace strncmp() with str_has_prefix()	2019-08-16 09:54:08 +02:00
braille.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
console_cmdline.h	printk: Fix preferred console selection with multiple matches	2020-02-18 09:34:42 +01:00
index.c	printk/index: Fix -Wunused-function warning	2021-08-27 16:42:44 +02:00
internal.h	Merge branch 'rework/printk_safe-removal' into for-linus	2021-08-30 16:36:10 +02:00
printk.c	printk: fix return value of printk.devkmsg __setup handler	2022-04-08 14:23:19 +02:00
printk_ringbuffer.c	Merge branch 'printk-rework' into for-linus	2021-01-21 16:06:21 +01:00
printk_ringbuffer.h	printk: rectify kernel-doc for prb_rec_init_wr()	2021-01-26 11:17:51 +01:00
printk_safe.c	printk: remove NMI tracking	2021-07-26 15:09:44 +02:00