Shaohua Li 3ef1c33f98 block-throttle: avoid double charge ... commit 111be88398 upstream. If a bio is throttled and split after throttling, the bio could be resubmited and enters the throttling again. This will cause part of the bio to be charged multiple times. If the cgroup has an IO limit, the double charge will significantly harm the performance. The bio split becomes quite common after arbitrary bio size change. To fix this, we always set the BIO_THROTTLED flag if a bio is throttled. If the bio is cloned/split, we copy the flag to new bio too to avoid a double charge. However, cloned bio could be directed to a new disk, keeping the flag be a problem. The observation is we always set new disk for the bio in this case, so we can clear the flag in bio_set_dev(). This issue exists for a long time, arbitrary bio size change just makes it worse, so this should go into stable at least since v4.2. V1-> V2: Not add extra field in bio based on discussion with Tejun Cc: Vivek Goyal <vgoyal@redhat.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Shaohua Li <shli@fb.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-12-29 17:53:47 +01:00
..
partitions	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig.iosched	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
badblocks.c	badblocks: fix wrong return value in badblocks_set if badblocks are disabled	2017-12-20 10:10:26 +01:00
bfq-cgroup.c	bfq: Declare local functions static	2017-09-01 13:56:37 -06:00
bfq-iosched.c	block,bfq: Disable writeback throttling	2017-12-25 14:26:26 +01:00
bfq-iosched.h	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
bfq-wf2q.c	block, bfq: guarantee update_next_in_service always returns an eligible entity	2017-08-31 08:20:31 -06:00
bio-integrity.c	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
bio.c	block-throttle: avoid double charge	2017-12-29 17:53:47 +01:00
blk-cgroup.c	blkcg: avoid free blkcg_root when failed to alloc blkcg policy	2017-08-25 13:51:07 -06:00
blk-core.c	blk-mq: Avoid that request queue removal can trigger list corruption	2017-12-17 15:08:00 +01:00
blk-exec.c	block: introduce new block status code type	2017-06-09 09:27:32 -06:00
blk-flush.c	block: update comments to reflect REQ_FLUSH -> REQ_PREFLUSH rename	2017-08-25 10:36:54 -06:00
blk-integrity.c	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
blk-ioc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-lib.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-map.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-merge.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-cpumap.c	blk-mq: map queues to all present CPUs	2017-07-24 10:01:31 -06:00
blk-mq-debugfs.c	blk-mq-debugfs: fix device sched directory for default scheduler	2017-10-03 15:58:55 -06:00
blk-mq-debugfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-pci.c	blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL	2017-08-18 08:08:14 -06:00
blk-mq-rdma.c	block: Add rdma affinity based queue mapping helper	2017-08-08 14:58:03 -04:00
blk-mq-sched.c	blk-mq-sched: dispatch from scheduler IFF progress is made in ->dispatch	2017-12-20 10:10:27 +01:00
blk-mq-sched.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-sysfs.c	blk-mq: untangle debugfs and sysfs	2017-05-04 08:24:13 -06:00
blk-mq-tag.c	blk-mq: Make blk_mq_reinit_tagset() calls easier to read	2017-08-18 08:36:58 -06:00
blk-mq-tag.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-virtio.c	blk-mq: provide a default queue mapping for virtio device	2017-02-27 20:54:05 +02:00
blk-mq.c	block: directly insert blk-mq request from blk_insert_cloned_request()	2017-09-11 16:43:57 -06:00
blk-mq.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-settings.c	block: Warn if blk_queue_rq_timed_out() is called for a blk-mq queue	2017-08-23 12:02:30 -06:00
blk-softirq.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-stat.c	blk-stat: don't use this_cpu_ptr() in a preemptable section	2017-05-10 07:40:18 -06:00
blk-stat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-sysfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-tag.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-throttle.c	block-throttle: avoid double charge	2017-12-29 17:53:47 +01:00
blk-timeout.c	block: Fix a race between blk_cleanup_queue() and timeout handling	2017-11-30 08:40:52 +00:00
blk-wbt.c	block,bfq: Disable writeback throttling	2017-12-25 14:26:26 +01:00
blk-wbt.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-zoned.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
blk.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bounce.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bsg-lib.c	bsg-lib: fix use-after-free under memory-pressure	2017-10-04 08:35:04 -06:00
bsg.c	bsg: remove #if 0'ed code	2017-08-29 10:50:30 -06:00
cfq-iosched.c	block/cfq: cache rightmost rb_node	2017-09-08 18:26:49 -07:00
cmdline-parser.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat_ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
deadline-iosched.c	block, scheduler: convert xxx_var_store to void	2017-08-28 10:01:08 -06:00
elevator.c	block: fix warning when I/O elevator is changed as request_queue is being removed	2017-08-28 10:52:44 -06:00
genhd.c	Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block	2017-09-07 11:59:42 -07:00
ioctl.c	block: remove the discard_zeroes_data flag	2017-04-08 11:25:38 -06:00
ioprio.c	block: Add fallthrough markers to switch statements	2017-06-21 11:46:07 -06:00
kyber-iosched.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-07-03 13:08:04 -07:00
mq-deadline.c	mq-deadline: Enable auto-loading when built as module	2017-08-29 10:47:23 -06:00
noop-iosched.c	block: move existing elevator ops to union	2017-01-17 10:03:33 -07:00
opal_proto.h	block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled	2017-09-11 09:45:52 -06:00
partition-generic.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
scsi_ioctl.c	block: Change argument type of scsi_req_init()	2017-06-20 19:27:14 -06:00
sed-opal.c	block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled	2017-09-11 09:45:52 -06:00
t10-pi.c	t10-pi: Move opencoded contants to common header	2017-07-03 16:56:25 -06:00