Paolo Abeni c22ee3a067 net/sched: act_pedit: sanitize shift argument before usage ... [ Upstream commit 4d42d54a7d ] syzbot was able to trigger an Out-of-Bound on the pedit action: UBSAN: shift-out-of-bounds in net/sched/act_pedit.c:238:43 shift exponent 1400735974 is too large for 32-bit type 'unsigned int' CPU: 0 PID: 3606 Comm: syz-executor151 Not tainted 5.18.0-rc5-syzkaller-00165-g810c2f0a3f86 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 ubsan_epilogue+0xb/0x50 lib/ubsan.c:151 __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x187 lib/ubsan.c:322 tcf_pedit_init.cold+0x1a/0x1f net/sched/act_pedit.c:238 tcf_action_init_1+0x414/0x690 net/sched/act_api.c:1367 tcf_action_init+0x530/0x8d0 net/sched/act_api.c:1432 tcf_action_add+0xf9/0x480 net/sched/act_api.c:1956 tc_ctl_action+0x346/0x470 net/sched/act_api.c:2015 rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5993 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2502 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x904/0xe00 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:725 ____sys_sendmsg+0x6e2/0x800 net/socket.c:2413 ___sys_sendmsg+0xf3/0x170 net/socket.c:2467 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7fe36e9e1b59 Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffef796fe88 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fe36e9e1b59 RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000000000003 RBP: 00007fe36e9a5d00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe36e9a5d90 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 </TASK> The 'shift' field is not validated, and any value above 31 will trigger out-of-bounds. The issue predates the git history, but syzbot was able to trigger it only after the commit mentioned in the fixes tag, and this change only applies on top of such commit. Address the issue bounding the 'shift' value to the maximum allowed by the relevant operator. Reported-and-tested-by: syzbot+8ed8fc4c57e9dcf23ca6@syzkaller.appspotmail.com Fixes: 8b796475fd ("net/sched: act_pedit: really ensure the skb is writable") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-05-25 09:57:30 +02:00
..
Kconfig	…
Makefile	…
act_api.c	net: sched: limit TC_ACT_REPEAT loops	2022-02-23 12:03:21 +01:00
act_bpf.c	…
act_connmark.c	…
act_csum.c	…
act_ct.c	netfilter: conntrack: convert to refcount_t api	2022-04-27 14:39:01 +02:00
act_ctinfo.c	…
act_gact.c	…
act_gate.c	…
act_ife.c	…
act_ipt.c	…
act_meta_mark.c	…
act_meta_skbprio.c	…
act_meta_skbtcindex.c	…
act_mirred.c	…
act_mpls.c	…
act_nat.c	…
act_pedit.c	net/sched: act_pedit: sanitize shift argument before usage	2022-05-25 09:57:30 +02:00
act_police.c	…
act_sample.c	…
act_simple.c	…
act_skbedit.c	…
act_skbmod.c	…
act_tunnel_key.c	…
act_vlan.c	…
cls_api.c	net/sched: fix initialization order when updating chain 0 head	2022-04-20 09:34:10 +02:00
cls_basic.c	…
cls_bpf.c	…
cls_cgroup.c	…
cls_flow.c	…
cls_flower.c	net/sched: flower: fix parsing of ethertype following VLAN header	2022-04-20 09:34:09 +02:00
cls_fw.c	…
cls_matchall.c	…
cls_route.c	…
cls_rsvp.c	…
cls_rsvp.h	…
cls_rsvp6.c	…
cls_tcindex.c	…
cls_u32.c	net/sched: cls_u32: fix possible leak in u32_init_knode()	2022-04-27 14:38:53 +02:00
em_canid.c	…
em_cmp.c	…
em_ipset.c	…
em_ipt.c	…
em_meta.c	…
em_nbyte.c	…
em_text.c	…
em_u32.c	…
ematch.c	…
sch_api.c	net_sched: add __rcu annotation to netdev->qdisc	2022-02-23 12:03:12 +01:00
sch_atm.c	…
sch_blackhole.c	…
sch_cake.c	…
sch_cbq.c	…
sch_cbs.c	…
sch_choke.c	…
sch_codel.c	…
sch_drr.c	…
sch_dsmark.c	…
sch_etf.c	…
sch_ets.c	…
sch_fifo.c	…
sch_fq.c	…
sch_fq_codel.c	…
sch_fq_pie.c	…
sch_frag.c	…
sch_generic.c	net_sched: add __rcu annotation to netdev->qdisc	2022-02-23 12:03:12 +01:00
sch_gred.c	…
sch_hfsc.c	…
sch_hhf.c	…
sch_htb.c	sch_htb: Fail on unsupported parameters when offload is requested	2022-02-01 17:27:13 +01:00
sch_ingress.c	…
sch_mq.c	…
sch_mqprio.c	…
sch_multiq.c	…
sch_netem.c	…
sch_pie.c	…
sch_plug.c	…
sch_prio.c	…
sch_qfq.c	…
sch_red.c	…
sch_sfb.c	…
sch_sfq.c	…
sch_skbprio.c	…
sch_taprio.c	net/sched: taprio: Check if socket flags are valid	2022-04-20 09:34:10 +02:00
sch_tbf.c	…
sch_teql.c	…