Jozsef Kadlecsik a1e1521b46 netfilter: ipset: Rework long task execution when adding/deleting entries ... [ Upstream commit 5e29dc36bd ] When adding/deleting large number of elements in one step in ipset, it can take a reasonable amount of time and can result in soft lockup errors. The patch 5f7b51bf09 ("netfilter: ipset: Limit the maximal range of consecutive elements to add/delete") tried to fix it by limiting the max elements to process at all. However it was not enough, it is still possible that we get hung tasks. Lowering the limit is not reasonable, so the approach in this patch is as follows: rely on the method used at resizing sets and save the state when we reach a smaller internal batch limit, unlock/lock and proceed from the saved state. Thus we can avoid long continuous tasks and at the same time removed the limit to add/delete large number of elements in one step. The nfnl mutex is held during the whole operation which prevents one to issue other ipset commands in parallel. Fixes: 5f7b51bf09 ("netfilter: ipset: Limit the maximal range of consecutive elements to add/delete") Reported-by: syzbot+9204e7399656300bf271@syzkaller.appspotmail.com Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-12 11:59:15 +01:00
..
6lowpan	…
9p	9p: set req refcount to zero to avoid uninitialized usage	2022-12-31 13:14:46 +01:00
802	mrp: introduce active flags to prevent UAF when applicant uninit	2022-12-31 13:14:42 +01:00
8021q	net: use eth_hw_addr_set() instead of ether_addr_copy()	2022-08-31 17:16:37 +02:00
appletalk	…
atm	net/atm: fix proc_mpc_write incorrect return value	2022-10-29 10:12:55 +02:00
ax25	net: ax25: Fix deadlock caused by skb_recv_datagram in ax25_recvmsg	2022-06-22 14:22:01 +02:00
batman-adv	batman-adv: Use netif_rx_any_context() any.	2022-07-29 17:25:07 +02:00
bluetooth	Bluetooth: RFCOMM: don't call kfree_skb() under spin_lock_irqsave()	2022-12-31 13:14:21 +01:00
bpf	bpf: Move skb->len == 0 checks into __bpf_redirect	2022-12-31 13:14:11 +01:00
bpfilter	…
bridge	bridge: switchdev: Fix memory leaks when changing VLAN protocol	2022-11-26 09:24:40 +01:00
caif	net: caif: fix double disconnect client in chnl_net_open()	2022-11-26 09:24:39 +01:00
can	can: af_can: fix NULL pointer dereference in can_rcv_filter	2022-12-14 11:37:22 +01:00
ceph	libceph: fix potential use-after-free on linger ping and resends	2022-05-25 09:57:28 +02:00
core	bpf: pull before calling skb_postpull_rcsum()	2023-01-12 11:59:08 +01:00
dcb	net: dcb: disable softirqs in dcbnl_flush_dev()	2022-03-08 19:12:52 +01:00
dccp	dccp/tcp: Reset saddr on failure after inet6?_hash_connect().	2022-12-02 17:41:07 +01:00
decnet	net: Fix data-races around sysctl_[rw]mem(_offset)?.	2022-08-03 12:03:51 +02:00
dns_resolver	…
dsa	net: dsa: tag_8021q: avoid leaking ctx on dsa_tag_8021q_register() error path	2022-12-31 13:14:21 +01:00
ethernet	move netdev_boot_setup into Space.c	2021-08-03 13:05:26 +01:00
ethtool	ethtool: avoiding integer overflow in ethtool_phys_id()	2022-12-31 13:14:42 +01:00
hsr	hsr: Synchronize sequence number updates.	2022-12-31 13:14:15 +01:00
ieee802154	net: ieee802154: fix error return code in dgram_bind()	2022-11-03 23:59:14 +09:00
ife	…
ipv4	mptcp: remove MPTCP 'ifdef' in TCP SYN cookies	2023-01-12 11:58:52 +01:00
ipv6	ipv6/sit: use DEV_STATS_INC() to avoid data-races	2022-12-31 13:14:42 +01:00
iucv	net/iucv: Replace deprecated CPU-hotplug functions.	2021-08-09 10:13:32 +01:00
kcm	kcm: close race conditions on sk_receive_queue	2022-11-26 09:24:50 +01:00
key	xfrm: Fix oops in __xfrm_state_delete()	2022-12-02 17:41:06 +01:00
l2tp	ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg	2022-06-22 14:21:58 +02:00
l3mdev	l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu	2022-04-27 14:38:53 +02:00
lapb	…
llc	llc: only change llc->dev when bind() succeeds	2022-03-28 09:58:46 +02:00
mac80211	wifi: mac80211: fix memory leak in ieee80211_if_add()	2022-12-31 13:14:14 +01:00
mac802154	mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()	2022-12-14 11:37:25 +01:00
mctp	mctp: Fix an error handling path in mctp_init()	2022-11-16 09:58:22 +01:00
mpls	net: Use u64_stats_fetch_begin_irq() for stats fetch.	2022-09-08 12:28:07 +02:00
mptcp	mptcp: remove MPTCP 'ifdef' in TCP SYN cookies	2023-01-12 11:58:52 +01:00
ncsi	net/ncsi: check for error return from call to nla_put_u32	2022-01-05 12:42:37 +01:00
netfilter	netfilter: ipset: Rework long task execution when adding/deleting entries	2023-01-12 11:59:15 +01:00
netlabel	netlabel: fix out-of-bounds memory accesses	2022-04-13 20:59:10 +02:00
netlink	net: genl: fix error path memory leak in policy dumping	2022-08-25 11:40:25 +02:00
netrom	netrom: fix api breakage in nr_setsockopt()	2022-01-27 11:04:00 +01:00
nfc	nfc: Fix potential resource leaks	2023-01-12 11:59:10 +01:00
nsh	…
openvswitch	openvswitch: Fix flow lookup to use unmasked key	2022-12-31 13:14:38 +01:00
packet	net/af_packet: make sure to pull mac header	2023-01-12 11:58:49 +01:00
phonet	phonet: refcount leak in pep_sock_accep	2022-01-11 15:35:16 +01:00
psample	…
qrtr	net: qrtr: start MHI channel after endpoit creation	2022-08-25 11:40:29 +02:00
rds	net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()	2022-10-26 12:34:49 +02:00
rfkill	rfkill: make new event layout opt-in	2022-04-08 14:23:00 +02:00
rose	rose: Fix NULL pointer dereference in rose_send_frame()	2022-11-10 18:15:29 +01:00
rxrpc	rxrpc: Fix missing unlock in rxrpc_do_sendmsg()	2022-12-31 13:14:39 +01:00
sched	net: sched: cbq: dont intepret cls results when asked to drop	2023-01-12 11:59:14 +01:00
sctp	sctp: sysctl: make extra pointers netns aware	2022-12-31 13:14:20 +01:00
smc	net/smc: Fix possible leaked pernet namespace in smc_init()	2022-11-10 18:15:31 +01:00
strparser	bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding	2021-11-18 19:17:11 +01:00
sunrpc	SUNRPC: ensure the matching upcall is in-flight upon downcall	2023-01-12 11:59:08 +01:00
switchdev	net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge	2021-08-04 12:35:07 +01:00
tipc	tipc: call tipc_lxc_xmit without holding node_read_lock	2022-12-14 11:37:29 +01:00
tls	bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes	2022-12-31 13:14:14 +01:00
unix	unix: Fix race in SOCK_SEQPACKET's unix_dgram_sendmsg()	2022-12-31 13:14:37 +01:00
vmw_vsock	net: vmw_vsock: vmci: Check memcpy_from_msg()	2022-12-31 13:14:18 +01:00
wireless	wifi: cfg80211: Fix not unregister reg_pdev when load_builtin_regdb_keys() fails	2022-12-31 13:14:14 +01:00
x25	net/x25: Fix skb leak in x25_lapb_receive_frame()	2022-11-26 09:24:41 +01:00
xdp	xsk: Fix backpressure mechanism on Tx	2022-10-26 12:34:40 +02:00
xfrm	xfrm: replay: Fix ESN wrap around for GSO	2022-12-02 17:41:02 +01:00
Kconfig	mctp: Add MCTP base	2021-07-29 15:06:49 +01:00
Makefile	mctp: Add MCTP base	2021-07-29 15:06:49 +01:00
compat.c	…
devres.c	…
socket.c	net: Fix a data-race around sysctl_somaxconn.	2022-08-31 17:16:45 +02:00
sysctl_net.c	…