John Fastabend f26349213d bpf, sockmap: Fix return codes from tcp_bpf_recvmsg_parser() ... [ Upstream commit 5b2c5540b8 ] Applications can be confused slightly because we do not always return the same error code as expected, e.g. what the TCP stack normally returns. For example on a sock err sk->sk_err instead of returning the sock_error we return EAGAIN. This usually means the application will 'try again' instead of aborting immediately. Another example, when a shutdown event is received we should immediately abort instead of waiting for data when the user provides a timeout. These tend to not be fatal, applications usually recover, but introduces bogus errors to the user or introduces unexpected latency. Before 'c5d2177a72a16' we fell back to the TCP stack when no data was available so we managed to catch many of the cases here, although with the extra latency cost of calling tcp_msg_wait_data() first. To fix lets duplicate the error handling in TCP stack into tcp_bpf so that we get the same error codes. These were found in our CI tests that run applications against sockmap and do longer lived testing, at least compared to test_sockmap that does short-lived ping/pong tests, and in some of our test clusters we deploy. Its non-trivial to do these in a shorter form CI tests that would be appropriate for BPF selftests, but we are looking into it so we can ensure this keeps working going forward. As a preview one idea is to pull in the packetdrill testing which catches some of this. Fixes: c5d2177a72 ("bpf, sockmap: Fix race in ingress receive verdict with redirect to self") Signed-off-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20220104205918.286416-1-john.fastabend@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-01-27 11:03:50 +01:00
..
bpfilter	net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"	2020-08-10 12:06:44 -07:00
netfilter	netfilter: ipt_CLUSTERIP: fix refcount leak in clusterip_tg_check()	2022-01-27 11:03:50 +01:00
Kconfig	net: ipv4: remove duplicate "the the" phrase in Kconfig text	2020-08-18 16:02:16 -07:00
Makefile	bpf: Clean up sockmap related Kconfigs	2021-02-26 12:28:03 -08:00
af_inet.c	net: fix use-after-free in tw_timer_handler	2022-01-05 12:42:39 +01:00
ah4.c	Networking changes for 5.14.	2021-06-30 15:51:09 -07:00
arp.c	net: Exempt multicast addresses from five-second neighbor lifetime	2020-11-13 14:24:39 -08:00
bpf_tcp_ca.c	bpf: Forbid bpf_ktime_get_coarse_ns and bpf_timer_* in tracing progs	2021-11-25 09:49:07 +01:00
cipso_ipv4.c	net: remove the unnecessary check in cipso_v4_doi_free	2021-09-03 13:52:29 +01:00
datagram.c	inet: stop leaking jiffies on the wire	2019-11-01 14:57:52 -07:00
devinet.c	net: return correct error code	2021-12-08 09:04:38 +01:00
esp4.c	ipsec: Remove unneeded extra variable in esp4 esp_ssg_unref()	2021-07-20 16:14:23 +02:00
esp4_offload.c	xfrm: remove description from xfrm_type struct	2021-06-09 09:38:52 +02:00
fib_frontend.c	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:04:49 +01:00
fib_lookup.h	ipv4: Fix spelling mistakes	2021-06-07 14:08:30 -07:00
fib_notifier.c	…
fib_rules.c	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:04:49 +01:00
fib_semantics.c	lwtunnel: Validate RTA_ENCAP_TYPE attribute length	2022-01-11 15:35:14 +01:00
fib_trie.c	memcg: enable accounting for IP address and routing-related objects	2021-07-20 06:00:38 -07:00
fou.c	fou: remove sparse errors	2021-08-31 12:03:33 +01:00
gre_demux.c	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
gre_offload.c	ip_gre: add csum offload support for gre header	2021-01-29 20:39:14 -08:00
icmp.c	icmp: fix icmp_ext_echo_iio parsing in icmp_build_probe	2021-10-14 07:54:47 -07:00
igmp.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-08-13 06:41:22 -07:00
inet_connection_sock.c	inet: use #ifdef CONFIG_SOCK_RX_QUEUE_MAPPING consistently	2021-12-17 10:30:13 +01:00
inet_diag.c	inet_diag: fix kernel-infoleak for UDP sockets	2021-12-22 09:32:40 +01:00
inet_fragment.c	inet: frags: batch fqdir destroy works	2020-12-12 15:08:54 -08:00
inet_hashtables.c	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 19:16:33 +01:00
inet_timewait_sock.c	net: Use generic ns_common::count	2020-08-19 14:06:36 +02:00
inetpeer.c	inetpeer: use div64_ul() and clamp_val() calculate inet_peer_threshold	2021-03-01 13:32:12 -08:00
ip_forward.c	…
ip_fragment.c	…
ip_gre.c	ip_gre: validate csum_start only on pull	2021-09-05 18:59:32 +01:00
ip_input.c	net: use indirect call helpers for dst_input	2021-02-03 14:51:39 -08:00
ip_options.c	net: clean up codestyle for net/ipv4	2020-08-25 06:28:02 -07:00
ip_output.c	net: ipv4: Fix the warning for dereference	2021-08-30 12:47:09 +01:00
ip_sockglue.c	Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""	2021-09-14 14:24:31 +01:00
ip_tunnel.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-07-31 09:14:46 -07:00
ip_tunnel_core.c	net: ip_tunnel: clean up endianness conversions	2021-01-08 19:25:35 -08:00
ip_vti.c	ip_tunnel: use ndo_siocdevprivate	2021-07-27 20:11:44 +01:00
ipcomp.c	Networking changes for 5.14.	2021-06-30 15:51:09 -07:00
ipconfig.c	net: ipconfig: Don't override command-line hostnames or domains	2021-06-02 13:27:03 -07:00
ipip.c	ip_tunnel: use ndo_siocdevprivate	2021-07-27 20:11:44 +01:00
ipmr.c	ipmr: Fix indentation issue	2021-07-07 20:52:25 -07:00
ipmr_base.c	…
metrics.c	treewide: rename nla_strlcpy to nla_strscpy.	2020-11-16 08:08:54 -08:00
netfilter.c	netfilter: Dissect flow after packet mangling	2021-04-18 22:04:16 +02:00
netlink.c	…
nexthop.c	net: nexthop: release IPv6 per-cpu dsts when replacing a nexthop group	2021-12-01 09:04:49 +01:00
ping.c	Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""	2021-09-14 14:24:31 +01:00
proc.c	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 19:16:33 +01:00
protocol.c	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
raw.c	Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""	2021-09-14 14:24:31 +01:00
raw_diag.c	net: Use nlmsg_unicast() instead of netlink_unicast()	2021-07-13 09:28:29 -07:00
route.c	ipv4: fix endianness issue in inet_rtm_getroute_build_skb()	2021-08-31 12:03:03 +01:00
syncookies.c	selinux/stable-5.11 PR 20201214	2020-12-16 11:01:04 -08:00
sysctl_net_ipv4.c	net: Introduce net.ipv4.tcp_migrate_req.	2021-06-15 18:01:05 +02:00
tcp.c	inet: fully convert sk->sk_rx_dst to RCU rules	2021-12-29 12:28:42 +01:00
tcp_bbr.c	tcp_bbr: fix u32 wrap bug in round logic if bbr_init() called after 2B packets	2021-08-11 15:00:15 -07:00
tcp_bic.c	tcp: fix stretch ACK bugs in BIC	2020-03-16 18:26:54 -07:00
tcp_bpf.c	bpf, sockmap: Fix return codes from tcp_bpf_recvmsg_parser()	2022-01-27 11:03:50 +01:00
tcp_cdg.c	…
tcp_cong.c	net: Only allow init netns to set default tcp cong to a restricted algo	2021-05-04 11:58:28 -07:00
tcp_cubic.c	tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows	2021-12-01 09:04:52 +01:00
tcp_dctcp.c	…
tcp_dctcp.h	…
tcp_diag.c	inet_diag: Move the INET_DIAG_REQ_BYTECODE nlattr to cb->data	2020-02-27 18:50:19 -08:00
tcp_fastopen.c	tcp: enable data-less, empty-cookie SYN with TFO_SERVER_COOKIE_NOT_REQD	2021-08-16 17:25:49 -07:00
tcp_highspeed.c	Replace HTTP links with HTTPS ones: IPv*	2020-07-06 13:23:03 -07:00
tcp_htcp.c	Replace HTTP links with HTTPS ones: IPv*	2020-07-06 13:23:03 -07:00
tcp_hybla.c	…
tcp_illinois.c	…
tcp_input.c	inet: fully convert sk->sk_rx_dst to RCU rules	2021-12-29 12:28:42 +01:00
tcp_ipv4.c	inet: fully convert sk->sk_rx_dst to RCU rules	2021-12-29 12:28:42 +01:00
tcp_lp.c	ipv4: tcp_lp.c: Couple of typo fixes	2021-03-28 17:31:13 -07:00
tcp_metrics.c	fixes-v5.11	2020-12-14 16:40:27 -08:00
tcp_minisocks.c	tcp: Add stats for socket migration.	2021-06-23 12:56:08 -07:00
tcp_nv.c	…
tcp_offload.c	net, gro: Set inner transport header offset in tcp/udp GRO hook	2021-08-02 10:20:56 +01:00
tcp_output.c	net: add and use skb_unclone_keeptruesize() helper	2021-11-25 09:49:08 +01:00
tcp_rate.c	…
tcp_recovery.c	tcp: more accurately check DSACKs to grow RACK reordering window	2021-07-27 20:07:21 +01:00
tcp_scalable.c	net: ipv4: delete repeated words	2020-08-24 17:31:20 -07:00
tcp_timer.c	net: sock: introduce sk_error_report	2021-06-29 11:28:21 -07:00
tcp_ulp.c	bpf: sockmap: Only check ULP for TCP sockets	2020-03-09 22:34:58 +01:00
tcp_vegas.c	tcp: use semicolons rather than commas to separate statements	2020-10-13 17:11:52 -07:00
tcp_vegas.h	…
tcp_veno.c	Replace HTTP links with HTTPS ones: IPv*	2020-07-06 13:23:03 -07:00
tcp_westwood.c	…
tcp_yeah.c	tcp_yeah: check struct yeah size at compile time	2021-06-29 11:54:36 -07:00
tunnel4.c	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
udp.c	net: udp: fix alignment problem in udp4_seq_show()	2022-01-11 15:35:18 +01:00
udp_bpf.c	net: Implement ->sock_is_readable() for UDP and AF_UNIX	2021-10-26 12:29:33 -07:00
udp_diag.c	net: Use nlmsg_unicast() instead of netlink_unicast()	2021-07-13 09:28:29 -07:00
udp_impl.h	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
udp_offload.c	fou: remove sparse errors	2021-08-31 12:03:33 +01:00
udp_tunnel_core.c	udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks	2021-01-07 12:53:29 -08:00
udp_tunnel_nic.c	udp_tunnel: Fix udp_tunnel_nic work-queue type	2021-09-13 12:38:45 +01:00
udp_tunnel_stub.c	udp_tunnel: add central NIC RX port offload infrastructure	2020-07-10 13:54:00 -07:00
udplite.c	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
xfrm4_input.c	xfrm: state: remove extract_input indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm4_output.c	xfrm: fix unused variable warning if CONFIG_NETFILTER=n	2020-05-11 15:12:27 +02:00
xfrm4_policy.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2019-12-24 22:28:54 -08:00
xfrm4_protocol.c	net: Remove the member netns_ok	2021-05-17 15:29:35 -07:00
xfrm4_state.c	xfrm: remove output_finish indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm4_tunnel.c	xfrm: remove description from xfrm_type struct	2021-06-09 09:38:52 +02:00