Fan Du c69736696c inet: fix double request socket freeing ... Eric Hugne reported following error : I'm hitting this warning on latest net-next when i try to SSH into a machine with eth0 added to a bridge (but i think the problem is older than that) Steps to reproduce: node2 ~ # brctl addif br0 eth0 [ 223.758785] device eth0 entered promiscuous mode node2 ~ # ip link set br0 up [ 244.503614] br0: port 1(eth0) entered forwarding state [ 244.505108] br0: port 1(eth0) entered forwarding state node2 ~ # [ 251.160159] ------------[ cut here ]------------ [ 251.160831] WARNING: CPU: 0 PID: 3 at include/net/request_sock.h:102 tcp_v4_err+0x6b1/0x720() [ 251.162077] Modules linked in: [ 251.162496] CPU: 0 PID: 3 Comm: ksoftirqd/0 Not tainted 4.0.0-rc3+ #18 [ 251.163334] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 251.164078] ffffffff81a8365c ffff880038a6ba18 ffffffff8162ace4 0000000000009898 [ 251.165084] 0000000000000000 ffff880038a6ba58 ffffffff8104da85 ffff88003fa437c0 [ 251.166195] ffff88003fa437c0 ffff88003fa74e00 ffff88003fa43bb8 ffff88003fad99a0 [ 251.167203] Call Trace: [ 251.167533] [<ffffffff8162ace4>] dump_stack+0x45/0x57 [ 251.168206] [<ffffffff8104da85>] warn_slowpath_common+0x85/0xc0 [ 251.169239] [<ffffffff8104db65>] warn_slowpath_null+0x15/0x20 [ 251.170271] [<ffffffff81559d51>] tcp_v4_err+0x6b1/0x720 [ 251.171408] [<ffffffff81630d03>] ? _raw_read_lock_irq+0x3/0x10 [ 251.172589] [<ffffffff81534e20>] ? inet_del_offload+0x40/0x40 [ 251.173366] [<ffffffff81569295>] icmp_socket_deliver+0x65/0xb0 [ 251.174134] [<ffffffff815693a2>] icmp_unreach+0xc2/0x280 [ 251.174820] [<ffffffff8156a82d>] icmp_rcv+0x2bd/0x3a0 [ 251.175473] [<ffffffff81534ea2>] ip_local_deliver_finish+0x82/0x1e0 [ 251.176282] [<ffffffff815354d8>] ip_local_deliver+0x88/0x90 [ 251.177004] [<ffffffff815350f0>] ip_rcv_finish+0xf0/0x310 [ 251.177693] [<ffffffff815357bc>] ip_rcv+0x2dc/0x390 [ 251.178336] [<ffffffff814f5da3>] __netif_receive_skb_core+0x713/0xa20 [ 251.179170] [<ffffffff814f7fca>] __netif_receive_skb+0x1a/0x80 [ 251.179922] [<ffffffff814f97d4>] process_backlog+0x94/0x120 [ 251.180639] [<ffffffff814f9612>] net_rx_action+0x1e2/0x310 [ 251.181356] [<ffffffff81051267>] __do_softirq+0xa7/0x290 [ 251.182046] [<ffffffff81051469>] run_ksoftirqd+0x19/0x30 [ 251.182726] [<ffffffff8106cc23>] smpboot_thread_fn+0x153/0x1d0 [ 251.183485] [<ffffffff8106cad0>] ? SyS_setgroups+0x130/0x130 [ 251.184228] [<ffffffff8106935e>] kthread+0xee/0x110 [ 251.184871] [<ffffffff81069270>] ? kthread_create_on_node+0x1b0/0x1b0 [ 251.185690] [<ffffffff81631108>] ret_from_fork+0x58/0x90 [ 251.186385] [<ffffffff81069270>] ? kthread_create_on_node+0x1b0/0x1b0 [ 251.187216] ---[ end trace c947fc7b24e42ea1 ]--- [ 259.542268] br0: port 1(eth0) entered forwarding state Remove the double calls to reqsk_put() [edumazet] : I got confused because reqsk_timer_handler() _has_ to call reqsk_put(req) after calling inet_csk_reqsk_queue_drop(), as the timer handler holds a reference on req. Signed-off-by: Fan Du <fan.du@intel.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Erik Hugne <erik.hugne@ericsson.com> Fixes: fa76ce7328 ("inet: get rid of central tcp/dccp listener timer") Signed-off-by: David S. Miller <davem@davemloft.net>		2015-03-23 21:40:48 -04:00
..
ccids	dccp: re-enable debug macro	2014-02-16 23:45:00 -05:00
Kconfig	net/dccp: remove depends on CONFIG_EXPERIMENTAL	2013-01-11 11:39:34 -08:00
Makefile	dccp: Policy-based packet dequeueing infrastructure	2010-12-07 13:47:12 +01:00
ackvec.c	dccp: replace min/casting by min_t	2014-11-18 15:26:32 -05:00
ackvec.h	net: dccp: Remove extern from function prototypes	2013-10-19 19:12:11 -04:00
ccid.c	net/dccp/ccid.c: add __init to ccid_activate	2014-10-01 18:33:13 -04:00
ccid.h	net: dccp: Remove extern from function prototypes	2013-10-19 19:12:11 -04:00
dccp.h	ipv4: dccp: handle ICMP messages on DCCP_NEW_SYN_RECV request sockets	2015-03-23 16:52:26 -04:00
diag.c	inet_diag: add const to inet_diag_req_v2	2015-03-10 13:45:28 -04:00
feat.c	dccp: kerneldoc warning fixes	2014-11-18 15:26:31 -05:00
feat.h	net: dccp: Remove extern from function prototypes	2013-10-19 19:12:11 -04:00
input.c	dccp: spelling s/reseting/resetting	2014-11-18 15:26:32 -05:00
ipv4.c	inet: fix double request socket freeing	2015-03-23 21:40:48 -04:00
ipv6.c	ipv6: dccp: handle ICMP messages on DCCP_NEW_SYN_RECV request sockets	2015-03-23 16:52:26 -04:00
ipv6.h	inet: includes a sock_common in request_sock	2013-10-10 00:08:07 -04:00
minisocks.c	inet: drop prev pointer handling in request sock	2015-03-20 12:40:25 -04:00
options.c	dccp: remove obsolete code	2014-01-04 20:18:49 -05:00
output.c	ipv4: add a sock pointer to ip_queue_xmit()	2014-04-15 12:58:34 -04:00
probe.c	net: Remove iocb argument from sendmsg and recvmsg	2015-03-02 13:06:31 -05:00
proto.c	net: Remove iocb argument from sendmsg and recvmsg	2015-03-02 13:06:31 -05:00
qpolicy.c	dccp qpolicy: Parameter checking of cmsg qpolicy parameters	2010-12-07 13:47:12 +01:00
sysctl.c	dccp: make the request_retries minimum is 1	2014-05-14 15:34:16 -04:00
timer.c	inet: get rid of central tcp/dccp listener timer	2015-03-20 12:40:25 -04:00