Cong Wang 53d374979e net: avoid updating qdisc_xmit_lock_key in netdev_update_lockdep_key() ... syzbot reported some bogus lockdep warnings, for example bad unlock balance in sch_direct_xmit(). They are due to a race condition between slow path and fast path, that is qdisc_xmit_lock_key gets re-registered in netdev_update_lockdep_key() on slow path, while we could still acquire the queue->_xmit_lock on fast path in this small window: CPU A CPU B __netif_tx_lock(); lockdep_unregister_key(qdisc_xmit_lock_key); __netif_tx_unlock(); lockdep_register_key(qdisc_xmit_lock_key); In fact, unlike the addr_list_lock which has to be reordered when the master/slave device relationship changes, queue->_xmit_lock is only acquired on fast path and only when NETIF_F_LLTX is not set, so there is likely no nested locking for it. Therefore, we can just get rid of re-registration of qdisc_xmit_lock_key. Reported-by: syzbot+4ec99438ed7450da6272@syzkaller.appspotmail.com Fixes: ab92d68fc2 ("net: core: add generic lockdep keys") Cc: Taehee Yoo <ap420073@gmail.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Acked-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-01-17 11:02:44 +01:00
..
Makefile	bpf: Introduce bpf sk local storage	2019-04-27 09:07:04 -07:00
bpf_sk_storage.c	bpf: Switch bpf_map ref counter to atomic64_t so bpf_map_inc() never fails	2019-11-18 11:41:59 +01:00
datagram.c	net: add READ_ONCE() annotation in __skb_wait_for_more_packets()	2019-10-28 13:33:41 -07:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev.c	net: avoid updating qdisc_xmit_lock_key in netdev_update_lockdep_key()	2020-01-17 11:02:44 +01:00
dev_addr_lists.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
dev_ioctl.c	net/core: Document all dev_ioctl() arguments	2019-03-27 13:49:43 -07:00
devlink.c	devlink: correct misspelling of snapshot	2020-01-11 14:30:24 -08:00
drop_monitor.c	drop_monitor: Better sanitize notified packets	2019-09-16 21:39:27 +02:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ethtool.c	net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()	2019-10-26 11:20:10 -07:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
filter.c	bpf: Sockmap/tls, msg_push_data may leave end mark in place	2020-01-15 23:26:13 +01:00
flow_dissector.c	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
flow_offload.c	net: core: rename indirect block ingress cb function	2019-12-06 20:45:09 -08:00
gen_estimator.c	net_sched: gen_estimator: extend packet counter to 64bit	2019-11-06 21:51:36 -08:00
gen_stats.c	net_sched: add TCA_STATS_PKT64 attribute	2019-11-05 18:20:55 -08:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: link_watch: prevent starvation when processing linkwatch wq	2019-07-01 19:02:47 -07:00
lwt_bpf.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-04 12:27:13 -08:00
lwtunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
neighbour.c	neighbour: remove neigh_cleanup() method	2019-12-09 09:48:47 -08:00
net-procfs.c	net: procfs: use index hashlist instead of name hashlist	2019-10-01 14:47:19 -07:00
net-sysfs.c	net-sysfs: Call dev_hold always in rx_queue_add_kobject	2019-12-17 22:57:11 -08:00
net-sysfs.h	…
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
net_namespace.c	netns: fix GFP flags in rtnl_net_notifyid()	2019-10-25 20:14:42 -07:00
netclassid_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: fix skb use after free in netpoll	2019-08-27 20:52:02 -07:00
netprio_cgroup.c	netprio: use css ID instead of cgroup ID	2019-11-12 08:18:03 -08:00
page_pool.c	net: page_pool: add the possibility to sync DMA memory for device	2019-11-20 12:34:28 -08:00
pktgen.c	pktgen: remove unnecessary assignment in pktgen_xmit()	2019-10-17 14:25:13 -04:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	net/core: Populate VF index in struct ifla_vf_guid	2019-12-03 11:24:34 -08:00
scm.c	y2038: socket: remove timespec reference in timestamping	2019-11-15 14:38:29 +01:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	net: Fixed updating of ethertype in skb_mpls_push()	2019-12-04 17:11:25 -08:00
skmsg.c	bpf: Sockmap, ensure sock lock held during tear down	2020-01-15 23:26:13 +01:00
sock.c	net: annotate lockless accesses to sk->sk_pacing_shift	2019-12-17 22:09:52 -08:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	bpf: Sockmap, ensure sock lock held during tear down	2020-01-15 23:26:13 +01:00
sock_reuseport.c	net/core: Replace rcu_swap_protected() with rcu_replace_pointer()	2019-10-30 08:45:26 -07:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net, sysctl: Fix compiler warning when only cBPF is present	2019-12-19 17:17:51 +01:00
timestamping.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xdp.c	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00