Ido Schimmel 041f8dc882 ipv4: Fix route deletion when nexthop info is not specified ... [ Upstream commit d5082d386e ] When the kernel receives a route deletion request from user space it tries to delete a route that matches the route attributes specified in the request. If only prefix information is specified in the request, the kernel should delete the first matching FIB alias regardless of its associated FIB info. However, an error is currently returned when the FIB info is backed by a nexthop object: # ip nexthop add id 1 via 192.0.2.2 dev dummy10 # ip route add 198.51.100.0/24 nhid 1 # ip route del 198.51.100.0/24 RTNETLINK answers: No such process Fix by matching on such a FIB info when legacy nexthop attributes are not specified in the request. An earlier check already covers the case where a nexthop ID is specified in the request. Add tests that cover these flows. Before the fix: # ./fib_nexthops.sh -t ipv4_fcnal ... TEST: Delete route when not specifying nexthop attributes [FAIL] Tests passed: 11 Tests failed: 1 After the fix: # ./fib_nexthops.sh -t ipv4_fcnal ... TEST: Delete route when not specifying nexthop attributes [ OK ] Tests passed: 12 Tests failed: 0 No regressions in other tests: # ./fib_nexthops.sh ... Tests passed: 228 Tests failed: 0 # ./fib_tests.sh ... Tests passed: 186 Tests failed: 0 Cc: stable@vger.kernel.org Reported-by: Jonas Gorski <jonas.gorski@gmail.com> Tested-by: Jonas Gorski <jonas.gorski@gmail.com> Fixes: 493ced1ac4 ("ipv4: Allow routes to use nexthop objects") Fixes: 6bf92d70e6 ("net: ipv4: fix route with nexthop object delete warning") Fixes: 61b91eb33a ("ipv4: Handle attempt to delete multipath route when fib_info contains an nh reference") Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20221124210932.2470010-1-idosch@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-08 11:28:44 +01:00
..
accounting	…
arch	x86/cpu: Restore AMD's DE_CFG MSR after resume	2022-11-16 09:58:31 +01:00
bootconfig	…
bpf	bpftool: Fix NULL pointer dereference when pin {PROG, MAP, LINK} without FILE	2022-11-16 09:58:15 +01:00
build	tools build: Switch to new openssl API for test-libcrypto	2022-08-25 11:40:14 +02:00
cgroup	…
debugging	…
edid	…
firewire	…
firmware	…
gpio	…
hv	…
iio	tools: iio: iio_generic_buffer: Fix read size	2022-12-02 17:41:10 +01:00
include	tools/nolibc/string: Fix memcmp() implementation	2022-11-10 18:15:38 +01:00
io_uring	…
kvm/kvm_stat	tools/kvm_stat: fix display of error when multiple processes are found	2022-08-11 13:07:51 +02:00
laptop	…
leds	…
lib	libbpf: Handle size overflow for ringbuf mmap	2022-12-08 11:28:39 +01:00
memory-model	…
objtool	objtool: Preserve special st_shndx indexes in elf_update_symbol	2022-10-26 12:34:37 +02:00
pci	…
pcmcia	…
perf	perf tools: Add the include/perf/ directory to .gitignore	2022-11-16 09:58:20 +01:00
power	…
rcu	…
scripts	…
spi	…
testing	ipv4: Fix route deletion when nexthop info is not specified	2022-12-08 11:28:44 +01:00
thermal/tmon	tools/thermal: Fix possible path truncations	2022-08-17 14:24:15 +02:00
time	…
tracing	…
usb	…
virtio	…
vm	tools/vm/slabinfo-gnuplot: use "grep -E" instead of "egrep"	2022-12-08 11:28:42 +01:00
wmi	…
Makefile	…