ZhengHan Wang ba70887698 Bluetooth: Fix double free in hci_conn_cleanup ... [ Upstream commit a85fb91e3d728bdfc80833167e8162cce8bc7004 ] syzbot reports a slab use-after-free in hci_conn_hash_flush [1]. After releasing an object using hci_conn_del_sysfs in the hci_conn_cleanup function, releasing the same object again using the hci_dev_put and hci_conn_put functions causes a double free. Here's a simplified flow: hci_conn_del_sysfs: hci_dev_put put_device kobject_put kref_put kobject_release kobject_cleanup kfree_const kfree(name) hci_dev_put: ... kfree(name) hci_conn_put: put_device ... kfree(name) This patch drop the hci_dev_put and hci_conn_put function call in hci_conn_cleanup function, because the object is freed in hci_conn_del_sysfs function. This patch also fixes the refcounting in hci_conn_add_sysfs() and hci_conn_del_sysfs() to take into account device_add() failures. This fixes CVE-2023-28464. Link: https://syzkaller.appspot.com/bug?id=1bb51491ca5df96a5f724899d1dbb87afda61419 [1] Signed-off-by: ZhengHan Wang <wzhmmmmm@gmail.com> Co-developed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-28 16:56:16 +00:00
..
6lowpan	…
9p	9p/net: fix possible memory leak in p9_check_errors()	2023-11-20 11:08:26 +01:00
802	mrp: introduce active flags to prevent UAF when applicant uninit	2022-12-31 13:14:42 +01:00
8021q	vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()	2023-05-24 17:36:52 +01:00
appletalk	…
atm	atm: hide unused procfs functions	2023-06-09 10:32:26 +02:00
ax25	…
batman-adv	batman-adv: Hold rtnl lock during MTU update via netlink	2023-08-30 16:18:18 +02:00
bluetooth	Bluetooth: Fix double free in hci_conn_cleanup	2023-11-28 16:56:16 +00:00
bpf	bpf: Move skb->len == 0 checks into __bpf_redirect	2022-12-31 13:14:11 +01:00
bpfilter	…
bridge	net: bridge: use DEV_STATS_INC()	2023-10-06 13:18:07 +02:00
caif	net: caif: Fix use-after-free in cfusbl_device_notify()	2023-03-17 08:48:54 +01:00
can	can: isotp: isotp_sendmsg(): fix TX state detection and wait behavior	2023-11-08 17:26:49 +01:00
ceph	libceph: use kernel_connect()	2023-10-19 23:05:36 +02:00
core	net: annotate data-races around sk->sk_dst_pending_confirm	2023-11-28 16:56:16 +00:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-11 15:13:53 +02:00
dccp	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-20 11:08:28 +01:00
dns_resolver	…
dsa	net: dsa: tag_sja1105: fix MAC DA patching from meta frames	2023-07-23 13:47:30 +02:00
ethernet	…
ethtool	ethtool: Fix uninitialized number of lanes	2023-05-17 11:50:18 +02:00
hsr	hsr: Prevent use after free in prp_create_tagged_frame()	2023-11-20 11:08:28 +01:00
ieee802154	…
ife	…
ipv4	net: annotate data-races around sk->sk_dst_pending_confirm	2023-11-28 16:56:16 +00:00
ipv6	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-20 11:08:28 +01:00
iucv	net/iucv: Fix size of interrupt data	2023-03-22 13:31:28 +01:00
kcm	kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().	2023-09-19 12:23:04 +02:00
key	net: af_key: fix sadb_x_filter validation	2023-08-26 14:23:32 +02:00
l2tp	ipv4, ipv6: Fix handling of transhdrlen in __ip{,6}_append_data()	2023-10-10 21:59:07 +02:00
l3mdev	…
lapb	…
llc	llc: verify mac len before reading mac header	2023-11-20 11:08:28 +01:00
mac80211	wifi: mac80211: don't return unset power in ieee80211_get_tx_power()	2023-11-28 16:56:15 +00:00
mac802154	mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()	2022-12-14 11:37:25 +01:00
mctp	mctp: perform route lookups under a RCU read-side lock	2023-10-25 11:58:59 +02:00
mpls	net: mpls: fix stale pointer if allocation fails during device rename	2023-02-22 12:57:09 +01:00
mptcp	mptcp: more conservative check for zero probes	2023-11-08 17:26:35 +01:00
ncsi	ncsi: Propagate carrier gain/loss events to the NCSI controller	2023-10-06 13:18:18 +02:00
netfilter	netfilter: nat: fix ipv6 nat redirect with mapped and scoped addresses	2023-11-20 11:08:29 +01:00
netlabel	netlabel: fix shift wrapping bug in netlbl_catmap_setlong()	2023-09-19 12:22:29 +02:00
netlink	netlink: Add __sock_i_ino() for __netlink_diag_dump().	2023-07-23 13:46:56 +02:00
netrom	netrom: Deny concurrent connect().	2023-09-19 12:22:35 +02:00
nfc	nfc: nci: fix possible NULL pointer dereference in send_acknowledge()	2023-10-25 11:58:55 +02:00
nsh	net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()	2023-05-24 17:36:51 +01:00
openvswitch	net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()	2023-02-22 12:57:09 +01:00
packet	net/packet: annotate data-races around tp->status	2023-08-16 18:22:01 +02:00
phonet	…
psample	…
qrtr	net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()	2023-04-20 12:13:53 +02:00
rds	net: prevent address rewrite in kernel_bind()	2023-10-19 23:05:33 +02:00
rfkill	net: rfkill: gpio: prevent value glitch during probe	2023-10-25 11:58:57 +02:00
rose	net/rose: Fix to not accept on connected socket	2023-02-22 12:57:02 +01:00
rxrpc	rxrpc: Fix hard call timeout units	2023-05-17 11:50:17 +02:00
sched	net: sched: cls_u32: Fix allocation size in u32_init()	2023-11-08 17:26:45 +01:00
sctp	sctp: update hb timer immediately after users change hb_interval	2023-10-10 21:59:08 +02:00
smc	net/smc: put sk reference if close work was canceled	2023-11-20 11:08:29 +01:00
strparser	…
sunrpc	Revert "SUNRPC dont update timeout value on connection reset"	2023-10-06 13:18:22 +02:00
switchdev	…
tipc	tipc: Change nla_policy for bearer-related names to NLA_NUL_STRING	2023-11-20 11:08:28 +01:00
tls	net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()	2023-09-19 12:23:04 +02:00
unix	af_unix: Fix data-race around unix_tot_inflight.	2023-09-19 12:22:59 +02:00
vmw_vsock	vsock/virtio: initialize the_virtio_vsock before using VQs	2023-11-08 17:26:37 +01:00
wireless	wifi: cfg80211: avoid leaking stack data into trace	2023-10-25 11:59:00 +02:00
x25	net/x25: Fix to not accept on connected socket	2023-02-09 11:26:40 +01:00
xdp	xsk: Fix xsk_diag use-after-free error during socket cleanup	2023-09-19 12:22:58 +02:00
xfrm	xfrm: interface: use DEV_STATS_INC()	2023-10-25 11:58:56 +02:00
Kconfig	Remove DECnet support from kernel	2023-06-21 15:59:15 +02:00
Makefile	Remove DECnet support from kernel	2023-06-21 15:59:15 +02:00
compat.c	…
devres.c	…
socket.c	net: prevent address rewrite in kernel_bind()	2023-10-19 23:05:33 +02:00
sysctl_net.c	…