Jiazi Li d208b89401 dm: fix mempool NULL pointer race when completing IO ... dm_io_dec_pending() calls end_io_acct() first and will then dec md in-flight pending count. But if a task is swapping DM table at same time this can result in a crash due to mempool->elements being NULL: task1 task2 do_resume ->do_suspend ->dm_wait_for_completion bio_endio ->clone_endio ->dm_io_dec_pending ->end_io_acct ->wakeup task1 ->dm_swap_table ->__bind ->__bind_mempools ->bioset_exit ->mempool_exit ->free_io [ 67.330330] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 ...... [ 67.330494] pstate: 80400085 (Nzcv daIf +PAN -UAO) [ 67.330510] pc : mempool_free+0x70/0xa0 [ 67.330515] lr : mempool_free+0x4c/0xa0 [ 67.330520] sp : ffffff8008013b20 [ 67.330524] x29: ffffff8008013b20 x28: 0000000000000004 [ 67.330530] x27: ffffffa8c2ff40a0 x26: 00000000ffff1cc8 [ 67.330535] x25: 0000000000000000 x24: ffffffdada34c800 [ 67.330541] x23: 0000000000000000 x22: ffffffdada34c800 [ 67.330547] x21: 00000000ffff1cc8 x20: ffffffd9a1304d80 [ 67.330552] x19: ffffffdada34c970 x18: 000000b312625d9c [ 67.330558] x17: 00000000002dcfbf x16: 00000000000006dd [ 67.330563] x15: 000000000093b41e x14: 0000000000000010 [ 67.330569] x13: 0000000000007f7a x12: 0000000034155555 [ 67.330574] x11: 0000000000000001 x10: 0000000000000001 [ 67.330579] x9 : 0000000000000000 x8 : 0000000000000000 [ 67.330585] x7 : 0000000000000000 x6 : ffffff80148b5c1a [ 67.330590] x5 : ffffff8008013ae0 x4 : 0000000000000001 [ 67.330596] x3 : ffffff80080139c8 x2 : ffffff801083bab8 [ 67.330601] x1 : 0000000000000000 x0 : ffffffdada34c970 [ 67.330609] Call trace: [ 67.330616] mempool_free+0x70/0xa0 [ 67.330627] bio_put+0xf8/0x110 [ 67.330638] dec_pending+0x13c/0x230 [ 67.330644] clone_endio+0x90/0x180 [ 67.330649] bio_endio+0x198/0x1b8 [ 67.330655] dec_pending+0x190/0x230 [ 67.330660] clone_endio+0x90/0x180 [ 67.330665] bio_endio+0x198/0x1b8 [ 67.330673] blk_update_request+0x214/0x428 [ 67.330683] scsi_end_request+0x2c/0x300 [ 67.330688] scsi_io_completion+0xa0/0x710 [ 67.330695] scsi_finish_command+0xd8/0x110 [ 67.330700] scsi_softirq_done+0x114/0x148 [ 67.330708] blk_done_softirq+0x74/0xd0 [ 67.330716] __do_softirq+0x18c/0x374 [ 67.330724] irq_exit+0xb4/0xb8 [ 67.330732] __handle_domain_irq+0x84/0xc0 [ 67.330737] gic_handle_irq+0x148/0x1b0 [ 67.330744] el1_irq+0xe8/0x190 [ 67.330753] lpm_cpuidle_enter+0x4f8/0x538 [ 67.330759] cpuidle_enter_state+0x1fc/0x398 [ 67.330764] cpuidle_enter+0x18/0x20 [ 67.330772] do_idle+0x1b4/0x290 [ 67.330778] cpu_startup_entry+0x20/0x28 [ 67.330786] secondary_start_kernel+0x160/0x170 Fix this by: 1) Establishing pointers to 'struct dm_io' members in dm_io_dec_pending() so that they may be passed into end_io_acct() _after_ free_io() is called. 2) Moving end_io_acct() after free_io(). Cc: stable@vger.kernel.org Signed-off-by: Jiazi Li <lijiazi@xiaomi.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>		2021-10-12 13:54:10 -04:00
..
bcache	bcache: use bvec_virt	2021-08-16 10:50:33 -06:00
persistent-data	dm btree remove: assign new_root only when removal succeeds	2021-06-25 15:25:24 -04:00
Kconfig	dm: make EBS depend on !HIGHMEM	2021-08-16 10:50:32 -06:00
Makefile	dm ima: measure data on table load	2021-08-10 13:32:40 -04:00
dm-bio-prison-v1.c	…
dm-bio-prison-v1.h	…
dm-bio-prison-v2.c	…
dm-bio-prison-v2.h	…
dm-bio-record.h	block: store a block_device pointer in struct bio	2021-01-24 18:17:20 -07:00
dm-bufio.c	dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size	2021-03-04 14:53:54 -05:00
dm-builtin.c	…
dm-cache-background-tracker.c	…
dm-cache-background-tracker.h	…
dm-cache-block-types.h	…
dm-cache-metadata.c	dm: use bdev_read_only to check if a device is read-only	2021-01-24 18:15:57 -07:00
dm-cache-metadata.h	…
dm-cache-policy-internal.h	…
dm-cache-policy-smq.c	…
dm-cache-policy.c	…
dm-cache-policy.h	…
dm-cache-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-clone-metadata.c	dm clone metadata: remove unused function	2021-04-19 13:20:31 -04:00
dm-clone-metadata.h	…
dm-clone-target.c	dm clone: make array 'descs' static	2021-10-12 13:54:10 -04:00
dm-core.h	dm ima: measure data on table load	2021-08-10 13:32:40 -04:00
dm-crypt.c	dm crypt: use in_hardirq() instead of deprecated in_irq()	2021-08-20 16:25:07 -04:00
dm-delay.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-dust.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ebs-target.c	- Add DM infrastructure for IMA-based remote attestion. These changes	2021-08-31 14:55:09 -07:00
dm-era-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-exception-store.c	…
dm-exception-store.h	…
dm-flakey.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ima.c	integrity-v5.15	2021-09-02 12:51:41 -07:00
dm-ima.h	dm ima: add version info to dm related events in ima log	2021-08-20 15:59:47 -04:00
dm-init.c	…
dm-integrity.c	- Add DM infrastructure for IMA-based remote attestion. These changes	2021-08-31 14:55:09 -07:00
dm-io-tracker.h	dm writecache: make writeback pause configurable	2021-06-28 16:30:13 -04:00
dm-io.c	block: Add bio_max_segs	2021-02-26 15:49:51 -07:00
dm-ioctl.c	dm ima: measure data on device rename	2021-08-10 13:34:23 -04:00
dm-kcopyd.c	dm writecache: have ssd writeback wait if the kcopyd workqueue is busy	2021-06-15 15:42:03 -04:00
dm-linear.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log-userspace-base.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log-userspace-transfer.c	…
dm-log-userspace-transfer.h	…
dm-log-writes.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-log.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-mpath.c	dm ima: update dm target attributes for ima measurements	2021-08-20 16:07:36 -04:00
dm-mpath.h	…
dm-path-selector.c	…
dm-path-selector.h	…
dm-ps-historical-service-time.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-io-affinity.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-queue-length.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-round-robin.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-ps-service-time.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-raid.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-raid1.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-region-hash.c	…
dm-rq.c	dm rq: don't queue request to blk-mq during DM suspend	2021-10-12 13:54:10 -04:00
dm-rq.h	…
dm-snap-persistent.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-snap-transient.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-snap.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-stats.c	…
dm-stats.h	…
dm-stripe.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-switch.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-sysfs.c	…
dm-table.c	libnvdimm for v5.15	2021-09-09 11:39:57 -07:00
dm-target.c	…
dm-thin-metadata.c	dm space maps: improve performance with inc/dec on ranges of blocks	2021-06-04 12:07:22 -04:00
dm-thin-metadata.h	…
dm-thin.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-uevent.c	…
dm-uevent.h	…
dm-unstripe.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-verity-fec.c	dm verity fec: fix misaligned RS roots IO	2021-04-14 14:28:29 -04:00
dm-verity-fec.h	dm verity fec: fix misaligned RS roots IO	2021-04-14 14:28:29 -04:00
dm-verity-target.c	dm verity: skip redundant verity_handle_err() on I/O errors	2021-10-12 13:54:09 -04:00
dm-verity-verify-sig.c	dm verity: fix require_signatures module_param permissions	2021-05-25 16:14:05 -04:00
dm-verity-verify-sig.h	…
dm-verity.h	…
dm-writecache.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-zero.c	dm: add support for REQ_NOWAIT to various targets	2020-12-04 18:04:35 -05:00
dm-zone.c	dm zone: fix dm_revalidate_zones() memory allocation	2021-06-25 15:25:23 -04:00
dm-zoned-metadata.c	dm zoned: check zone capacity	2021-06-04 12:07:28 -04:00
dm-zoned-reclaim.c	dm kcopyd: avoid useless atomic operations	2021-06-04 12:07:24 -04:00
dm-zoned-target.c	dm: update target status functions to support IMA measurement	2021-08-10 13:34:23 -04:00
dm-zoned.h	…
dm.c	dm: fix mempool NULL pointer race when completing IO	2021-10-12 13:54:10 -04:00
dm.h	dm: introduce zone append emulation	2021-06-04 12:07:37 -04:00
md-autodetect.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
md-bitmap.c	md: Constify attribute_group structs	2021-06-14 22:32:07 -07:00
md-bitmap.h	…
md-cluster.c	for-5.11/drivers-2020-12-14	2020-12-16 13:09:32 -08:00
md-cluster.h	…
md-faulty.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-linear.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-linear.h	…
md-multipath.c	md: mark some personalities as deprecated	2021-06-14 22:32:07 -07:00
md-multipath.h	…
md.c	md: fix a lock order reversal in md_alloc	2021-09-22 08:45:58 -07:00
md.h	block: remove GENHD_FL_UP	2021-08-12 10:29:36 -06:00
raid0.c	md: add io accounting for raid0 and raid5	2021-06-14 22:32:06 -07:00
raid0.h	…
raid1-10.c	…
raid1.c	for-5.15/drivers-2021-08-30	2021-08-30 19:01:46 -07:00
raid1.h	md/raid1: enable io accounting	2021-06-14 22:32:07 -07:00
raid5-cache.c	block: rename BIO_MAX_PAGES to BIO_MAX_VECS	2021-03-11 07:47:48 -07:00
raid5-log.h	…
raid5-ppl.c	block: rename BIO_MAX_PAGES to BIO_MAX_VECS	2021-03-11 07:47:48 -07:00
raid5.c	md/raid5: Replace deprecated CPU-hotplug functions.	2021-08-28 01:46:17 +02:00
raid5.h	md/raid5: let multiple devices of stripe_head share page	2020-09-24 16:44:44 -07:00
raid10.c	for-5.15/drivers-2021-08-30	2021-08-30 19:01:46 -07:00
raid10.h	md/raid10: enable io accounting	2021-06-14 22:32:07 -07:00