Guo Ren 69ea463021 irqchip/sifive-plic: Fixup EOI failed when masked ... When using "devm_request_threaded_irq(,,,,IRQF_ONESHOT,,)" in a driver, only the first interrupt is handled, and following interrupts are never delivered (initially reported in [1]). That's because the RISC-V PLIC cannot EOI masked interrupts, as explained in the description of Interrupt Completion in the PLIC spec [2]: <quote> The PLIC signals it has completed executing an interrupt handler by writing the interrupt ID it received from the claim to the claim/complete register. The PLIC does not check whether the completion ID is the same as the last claim ID for that target. If the completion ID does not match an interrupt source that *is currently enabled* for the target, the completion is silently ignored. </quote> Re-enable the interrupt before completion if it has been masked during the handling, and remask it afterwards. [1] http://lists.infradead.org/pipermail/linux-riscv/2021-July/007441.html [2] 8bc15a35d0/riscv-plic.adoc Fixes: bb0fed1c60 ("irqchip/sifive-plic: Switch to fasteoi flow") Reported-by: Vincent Pelletier <plr.vincent@gmail.com> Tested-by: Nikita Shubin <nikita.shubin@maquefel.me> Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Cc: stable@vger.kernel.org Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Atish Patra <atish.patra@wdc.com> Reviewed-by: Anup Patel <anup@brainfault.org> [maz: amended commit message] Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20211105094748.3894453-1-guoren@kernel.org		2021-11-12 16:09:51 +00:00
..
Kconfig	Merge branch irq/mchp-eic into irq/irqchip-next	2021-10-25 09:04:24 +01:00
Makefile	irqchip/mchp-eic: Add support for the Microchip EIC	2021-10-20 19:40:54 +01:00
alphascale_asm9260-icoll.h	…
exynos-combiner.c	…
irq-al-fic.c	…
irq-alpine-msi.c	irqchip/alpine-msi: Switch to bitmap_zalloc()	2021-07-26 18:01:44 +01:00
irq-apple-aic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-armada-370-xp.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-aspeed-i2c-ic.c	…
irq-aspeed-scu-ic.c	…
irq-aspeed-vic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-ath79-cpu.c	…
irq-ath79-misc.c	…
irq-ativic32.c	irq: nds32: avoid CONFIG_HANDLE_DOMAIN_IRQ	2021-10-25 10:05:29 +01:00
irq-atmel-aic-common.c	…
irq-atmel-aic-common.h	…
irq-atmel-aic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-atmel-aic5.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-bcm2835.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-bcm2836.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-bcm6345-l1.c	irq: mips: simplify bcm6345_l1_irq_handle()	2021-10-25 10:04:53 +01:00
irq-bcm7038-l1.c	irqchip/irq-bcm7038-l1: Switch to IRQCHIP_PLATFORM_DRIVER	2021-10-20 20:06:33 +01:00
irq-bcm7120-l2.c	irqchip/irq-bcm7120-l2: Switch to IRQCHIP_PLATFORM_DRIVER	2021-10-20 20:06:34 +01:00
irq-brcmstb-l2.c	irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER	2021-10-20 20:06:33 +01:00
irq-clps711x.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-crossbar.c	…
irq-csky-apb-intc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-csky-mpintc.c	irqchip/csky-mpintc: Fixup mask/unmask implementation	2021-11-12 16:09:50 +00:00
irq-davinci-aintc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-davinci-cp-intc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-digicolor.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-dw-apb-ictl.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-ftintc010.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-gic-common.c	…
irq-gic-common.h	…
irq-gic-pm.c	…
irq-gic-realview.c	…
irq-gic-v2m.c	irqchip/gic-v2m: Switch to bitmap_zalloc()	2021-07-26 18:01:44 +01:00
irq-gic-v3-its-fsl-mc-msi.c	…
irq-gic-v3-its-pci-msi.c	…
irq-gic-v3-its-platform-msi.c	…
irq-gic-v3-its.c	irqchip/gic-v3-its: Fix potential VPE leak on error	2021-09-22 14:37:04 +01:00
irq-gic-v3-mbi.c	irqchip/gic-v3: Switch to bitmap_zalloc()	2021-07-26 18:04:01 +01:00
irq-gic-v3.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-gic-v4.c	…
irq-gic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-goldfish-pic.c	…
irq-hip04.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-i8259.c	…
irq-idt3243x.c	…
irq-imgpdc.c	…
irq-imx-gpcv2.c	…
irq-imx-intmux.c	…
irq-imx-irqsteer.c	…
irq-ingenic-tcu.c	…
irq-ingenic.c	…
irq-ixp4xx.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-jcore-aic.c	…
irq-keystone.c	…
irq-loongson-htpic.c	…
irq-loongson-htvec.c	…
irq-loongson-liointc.c	…
irq-loongson-pch-msi.c	…
irq-loongson-pch-pic.c	irqchip/loongson-pch-pic: Improve edge triggered interrupt support	2021-08-12 07:57:23 +01:00
irq-lpc32xx.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-ls-extirq.c	…
irq-ls-scfg-msi.c	irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc()	2021-07-26 18:04:10 +01:00
irq-ls1x.c	…
irq-madera.c	…
irq-mbigen.c	irqchip/mbigen: Repair non-kernel-doc notation	2021-09-22 14:32:26 +01:00
irq-mchp-eic.c	irqchip/mchp-eic: Fix return value check in mchp_eic_init()	2021-10-25 09:02:18 +01:00
irq-meson-gpio.c	irqchip/meson-gpio: Make it possible to build as a module	2021-10-20 19:38:01 +01:00
irq-mips-cpu.c	irqchip/mips: Fix RCU violation when using irqdomain lookup on interrupt entry	2021-07-09 10:18:58 +01:00
irq-mips-gic.c	irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()	2021-10-26 11:19:38 +01:00
irq-mmp.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-mscc-ocelot.c	…
irq-mst-intc.c	…
irq-mtk-cirq.c	…
irq-mtk-sysirq.c	irqchip/mtk-sysirq: Skip setting irq-wake	2021-08-12 08:15:15 +01:00
irq-mvebu-gicp.c	irqchip/mvebu-gicp: Switch to devm_bitmap_zalloc()	2021-07-26 18:04:10 +01:00
irq-mvebu-icu.c	irqchip/irq-mvebu-icu: Make use of the helper function devm_platform_ioremap_resource()	2021-10-19 11:22:34 +01:00
irq-mvebu-odmi.c	irqchip/mvebu-odmi: Switch to bitmap_zalloc()	2021-07-26 18:04:11 +01:00
irq-mvebu-pic.c	irqchip/irq-mvebu-pic: Make use of the helper function devm_platform_ioremap_resource()	2021-10-19 11:22:59 +01:00
irq-mvebu-sei.c	…
irq-mxs.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-nvic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-omap-intc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-ompic.c	…
irq-or1k-pic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-orion.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-owl-sirq.c	…
irq-partition-percpu.c	irqchip/partitions: Switch to bitmap_zalloc()	2021-07-26 18:01:27 +01:00
irq-pic32-evic.c	irqchip/mips: Fix RCU violation when using irqdomain lookup on interrupt entry	2021-07-09 10:18:58 +01:00
irq-pruss-intc.c	…
irq-rda-intc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-realtek-rtl.c	…
irq-renesas-h8s.c	…
irq-renesas-h8300h.c	…
irq-renesas-intc-irqpin.c	…
irq-renesas-irqc.c	…
irq-renesas-rza1.c	irqchip/renesas-rza1: Use semicolons instead of commas	2021-09-22 14:37:59 +01:00
irq-riscv-intc.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-sa11x0.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-sifive-plic.c	irqchip/sifive-plic: Fixup EOI failed when masked	2021-11-12 16:09:51 +00:00
irq-sl28cpld.c	…
irq-sni-exiu.c	…
irq-st.c	…
irq-stm32-exti.c	irqchip/stm32: Make use of the helper function devm_platform_ioremap_resource()	2021-10-19 11:24:05 +01:00
irq-sun4i.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-sun6i-r.c	…
irq-sunxi-nmi.c	…
irq-tb10x.c	…
irq-tegra.c	…
irq-ti-sci-inta.c	irqchip/ti-sci-inta: Make use of the helper function devm_platform_ioremap_resource()	2021-10-19 11:24:28 +01:00
irq-ti-sci-intr.c	…
irq-ts4800.c	irqchip/irq-ts4800: Make use of the helper function devm_platform_ioremap_resource()	2021-10-19 11:23:44 +01:00
irq-uniphier-aidet.c	…
irq-versatile-fpga.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-vf610-mscm-ir.c	…
irq-vic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-vt8500.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-wpcm450-aic.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irq-xilinx-intc.c	…
irq-xtensa-mx.c	…
irq-xtensa-pic.c	…
irq-zevio.c	irq: remove handle_domain_{irq,nmi}()	2021-10-26 10:13:31 +01:00
irqchip.c	…
qcom-irq-combiner.c	…
qcom-pdc.c	irqchip/qcom-pdc: Trim unused levels of the interrupt hierarchy	2021-08-23 09:45:31 +01:00
spear-shirq.c	…