Jean Delvare 573cb560b4 firmware: dmi_scan: Fix handling of empty DMI strings ... [ Upstream commit a7770ae194 ] The handling of empty DMI strings looks quite broken to me: * Strings from 1 to 7 spaces are not considered empty. * True empty DMI strings (string index set to 0) are not considered empty, and result in allocating a 0-char string. * Strings with invalid index also result in allocating a 0-char string. * Strings starting with 8 spaces are all considered empty, even if non-space characters follow (sounds like a weird thing to do, but I have actually seen occurrences of this in DMI tables before.) * Strings which are considered empty are reported as 8 spaces, instead of being actually empty. Some of these issues are the result of an off-by-one error in memcmp, the rest is incorrect by design. So let's get it square: missing strings and strings made of only spaces, regardless of their length, should be treated as empty and no memory should be allocated for them. All other strings are non-empty and should be allocated. Signed-off-by: Jean Delvare <jdelvare@suse.de> Fixes: 79da472111 ("x86: fix DMI out of memory problems") Cc: Parag Warudkar <parag.warudkar@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-26 11:02:16 +02:00
..
broadcom	…
efi	x86/efi: Clarify that reset attack mitigation needs appropriate userspace	2018-02-03 17:39:25 +01:00
google	firmware: vpd: Fix platform driver and device registration/unregistration	2017-12-14 09:52:50 +01:00
meson	…
tegra	firmware: tegra: set drvdata earlier	2017-08-17 13:08:08 +02:00
Kconfig	…
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
arm_scpi.c	ARM SCPI fixes for v4.14	2017-08-24 15:51:54 +02:00
dcdbas.c	firmware/dcdbas: Constify attribute_group structures	2017-08-21 09:43:51 +02:00
dcdbas.h	…
dell_rbu.c	…
dmi-id.c	…
dmi-sysfs.c	x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappings	2017-07-18 11:37:58 +02:00
dmi_scan.c	firmware: dmi_scan: Fix handling of empty DMI strings	2018-04-26 11:02:16 +02:00
edd.c	…
iscsi_ibft.c	…
iscsi_ibft_find.c	…
memmap.c	…
pcdp.c	x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappings	2017-07-18 11:37:58 +02:00
pcdp.h	…
psci.c	firmware/psci: Expose SMCCC version through psci_ops	2018-02-16 20:22:56 +01:00
psci_checker.c	…
qcom_scm-32.c	…
qcom_scm-64.c	…
qcom_scm.c	…
qcom_scm.h	…
qemu_fw_cfg.c	…
raspberrypi.c	…
scpi_pm_domain.c	…
ti_sci.c	…
ti_sci.h	…