Prarit Bhargava 6af8bef14d PCI hotplug: acpiphp: Prevent deadlock on PCI-to-PCI bridge remove ... I originally submitted a patch to workaround this by pushing all Ejection Requests and Device Checks onto the kacpi_hotplug queue. http://marc.info/?l=linux-acpi&m=131678270930105&w=2 The patch is still insufficient in that Bus Checks also need to be added. Rather than add all events, including non-PCI-hotplug events, to the hotplug queue, mjg suggested that a better approach would be to modify the acpiphp driver so only acpiphp events would be added to the kacpi_hotplug queue. It's a longer patch, but at least we maintain the benefit of having separate queues in ACPI. This, of course, is still only a workaround the problem. As Bjorn and mjg pointed out, we have to refactor a lot of this code to do the right thing but at this point it is a better to have this code working. The acpi core places all events on the kacpi_notify queue. When the acpiphp driver is loaded and a PCI card with a PCI-to-PCI bridge is removed the following call sequence occurs: cleanup_p2p_bridge() -> cleanup_bridge() -> acpi_remove_notify_handler() -> acpi_os_wait_events_complete() -> flush_workqueue(kacpi_notify_wq) which is the queue we are currently executing on and the process will hang. Move all hotplug acpiphp events onto the kacpi_hotplug workqueue. In handle_hotplug_event_bridge() and handle_hotplug_event_func() we can simply push the rest of the work onto the kacpi_hotplug queue and then avoid the deadlock. Signed-off-by: Prarit Bhargava <prarit@redhat.com> Cc: mjg@redhat.com Cc: bhelgaas@google.com Cc: linux-acpi@vger.kernel.org Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>		2011-10-14 09:05:31 -07:00
..
accessibility	…
acpi	PCI hotplug: acpiphp: Prevent deadlock on PCI-to-PCI bridge remove	2011-10-14 09:05:31 -07:00
amba	…
ata	drivers/ata/sata_dwc_460ex.c: add missing kfree	2011-08-18 23:58:11 -04:00
atm	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
auxdisplay	…
base	PM / Clocks: Do not acquire a mutex under a spinlock	2011-09-26 19:40:23 +02:00
bcma	bcma: add uevent to the bus, to autoload drivers	2011-08-22 14:21:41 -04:00
block	floppy: use del_timer_sync() in init cleanup	2011-09-21 10:22:11 +02:00
bluetooth	Bluetooth: add support for 2011 mac mini	2011-09-17 17:16:03 -03:00
cdrom	drivers/cdrom/cdrom.c: relax check on dvd manufacturer value	2011-08-02 12:43:50 +02:00
char	TPM: Zero buffer after copying to userspace	2011-09-23 09:46:41 +10:00
clk	…
clocksource	Merge branch 'common/core' into sh-latest	2011-08-08 16:33:54 +09:00
connector	proc_fork_connector: a lockless ->real_parent usage is not safe	2011-07-28 18:26:32 -07:00
cpufreq	drivers/cpufreq/pcc-cpufreq.c: avoid NULL pointer dereference	2011-09-14 18:09:38 -07:00
cpuidle	cpuidle: stop depending on pm_idle	2011-08-03 19:06:37 -04:00
crypto	n2_crypto: Attach on Niagara-T3.	2011-07-28 01:30:07 -07:00
dca	…
dio	…
dma	dmaengine/ste_dma40: fix memory leak due to prepared descriptors	2011-09-05 17:08:26 +05:30
edac	i7core_edac: fixed typo in error count calculation	2011-08-18 14:07:15 -07:00
eisa	eisa/pci_eisa.c: fix BUG introduced by 005bdad7b8	2011-08-04 06:32:51 -10:00
firewire	firewire: ohci: add no MSI quirk for O2Micro controller	2011-09-16 22:22:10 +02:00
firmware	firmware: fix google/gsmi.c build warning	2011-08-08 13:53:49 -07:00
gpio	gpio-pca953x: fix gpio_base	2011-10-13 13:49:37 -06:00
gpu	drm/radeon/kms: use hardcoded dig encoder to transmitter mapping for DCE4.1	2011-10-06 11:45:30 +01:00
hid	Merge branch 'for-linus' of git://github.com/dtor/input	2011-09-16 14:09:19 -07:00
hwmon	hwmon: (coretemp) Avoid leaving around dangling pointer	2011-09-28 08:19:21 -07:00
hwspinlock	…
i2c	i2c-tegra: fix possible race condition after tx	2011-09-07 00:13:40 +01:00
ide	ide: Fix file references in drivers/ide/	2011-10-13 18:25:11 +12:00
idle	…
ieee802154	…
infiniband	[SCSI] cxgb3i: convert cdev->l2opt to use rcu to prevent NULL dereference	2011-09-26 09:28:01 -05:00
input	Merge branch 'for-linus' of git://github.com/dtor/input	2011-10-05 09:22:38 -07:00
iommu	x86, iommu: Mark DMAR IRQ as non-threaded	2011-09-13 23:44:53 +02:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2011-07-28 05:58:19 -07:00
leds	drivers/leds/ledtrig-timer.c: fix broken sysfs delay handling	2011-09-14 18:09:38 -07:00
lguest	…
macintosh	…
mca	…
md	Merge branch 'for-linus' of http://people.redhat.com/agk/git/linux-dm	2011-10-06 08:31:47 -07:00
media	[media] omap3isp: Fix build error in ispccdc.c	2011-09-21 22:18:26 -03:00
memstick	…
message	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6	2011-07-30 08:36:02 -10:00
mfd	mfd: Fix generic irq chip ack function name for jz4740-adc	2011-09-21 13:06:34 +02:00
misc	lis3: fix regression of HP DriveGuard with 8bit chip	2011-10-03 20:51:51 -07:00
mmc	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2011-09-21 13:20:21 -07:00
mtd	UBI: do not link debug messages when debugging is disabled	2011-08-19 19:02:27 +03:00
net	PCI: Add Solarflare vendor ID and SFC4000 device IDs	2011-10-14 09:05:27 -07:00
nfc	NFC: pn533: use after free in pn533_disconnect()	2011-07-26 16:27:24 -04:00
nubus	…
of	Revert "dt: add of_alias_scan and of_alias_get_id"	2011-08-04 11:26:24 +01:00
oprofile	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
parisc	…
parport	Merge branch 'tty-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6	2011-07-25 23:09:27 -07:00
pci	PCI hotplug: acpiphp: Prevent deadlock on PCI-to-PCI bridge remove	2011-10-14 09:05:31 -07:00
pcmcia	Merge git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6	2011-07-31 06:23:08 -10:00
platform	acer-wmi: support Lenovo ideapad S205 wifi switch	2011-08-05 15:21:52 -04:00
pnp	Merge 'akpm' patch series	2011-07-25 21:00:19 -07:00
power	s3c-adc-battery: Fix compilation error due to missing header (module.h)	2011-08-19 21:01:46 +04:00
pps	…
ps3	…
ptp	…
rapidio	rapidio: fix use of non-compatible registers	2011-08-25 16:25:34 -07:00
regulator	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6	2011-08-01 14:05:46 -10:00
rtc	drivers/rtc/rtc-s3c.c: fix no occurrence of alarm interrupt	2011-09-14 18:09:38 -07:00
s390	[S390] cio: fix cio_tpi ignoring adapter interrupts	2011-09-26 16:40:50 +02:00
sbus	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
scsi	[SCSI] libsas: fix panic when single phy is disabled on a wide port	2011-10-02 13:28:55 -05:00
sfi	…
sh	Merge branch 'common/core' into sh-latest	2011-08-08 16:33:54 +09:00
sn	…
spi	spi-topcliff-pch: Fix overrun issue	2011-10-04 10:10:50 -06:00
ssb	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2011-07-25 13:56:39 -07:00
staging	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/upstream-linus	2011-10-10 14:39:03 +12:00
target	iscsi-target: Fix sendpage breakage with proper padding+DataDigest iovec offsets	2011-09-16 23:47:07 +00:00
tc	…
telephony	…
thermal	thermal: make THERMAL_HWMON implementation fully internal	2011-08-02 14:51:57 -04:00
tty	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/upstream-linus	2011-10-10 14:39:03 +12:00
uio	Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6	2011-07-25 23:06:24 -07:00
usb	USB: xHCI: prevent infinite loop when processing MSE event	2011-09-19 17:15:47 -07:00
uwb	…
vhost	atomic: use <linux/atomic.h>	2011-07-26 16:49:47 -07:00
video	backlight: Declare backlight_types[] const	2011-09-10 14:00:02 -07:00
virt	…
virtio	…
vlynq	…
w1	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00
watchdog	watchdog: Initconst section fixes for watchdog	2011-09-20 14:32:00 +02:00
xen	xen/irq: Alter the locking to use a mutex instead of a spinlock.	2011-09-15 04:32:02 -04:00
zorro	zorro: Defer device_register() until all devices have been identified	2011-09-22 12:59:35 -07:00
Kconfig	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2011-07-25 22:59:39 -07:00
Makefile	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2011-07-25 22:59:39 -07:00